<div dir="ltr">Thanks - sorry I didn't catch that when committing.</div><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 28, 2017 at 5:54 PM Bruno Cardoso Lopes via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: bruno<br>
Date: Tue Nov 28 17:53:49 2017<br>
New Revision: 319273<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=319273&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=319273&view=rev</a><br>
Log:<br>
[Modules] Add textual headers for recently added .def files<br>
<br>
Keep module.modulemap up to date and get rid of -Wincomplete-umbrella warnings<br>
<br>
rdar://problem/35711925<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/module.modulemap<br>
<br>
Modified: llvm/trunk/include/llvm/module.modulemap<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/module.modulemap?rev=319273&r1=319272&r2=319273&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/module.modulemap?rev=319273&r1=319272&r2=319273&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/module.modulemap (original)<br>
+++ llvm/trunk/include/llvm/module.modulemap Tue Nov 28 17:53:49 2017<br>
@@ -25,6 +25,7 @@ module LLVM_Backend {<br>
     exclude header "CodeGen/LinkAllCodegenComponents.h"<br>
<br>
     // These are intended for (repeated) textual inclusion.<br>
+    textual header "CodeGen/CommandFlags.def"<br>
     textual header "CodeGen/DIEValue.def"<br>
     textual header "CodeGen/RuntimeLibcalls.def"<br>
     textual header "CodeGen/TargetOpcodes.def"<br>
@@ -228,8 +229,7 @@ module LLVM_MC {<br>
   umbrella "MC"<br>
   module * { export * }<br>
<br>
-  // Exclude this; it's fundamentally non-modular.<br>
-  exclude header "MC/MCTargetOptionsCommandFlags.h"<br>
+  textual header "MC/MCTargetOptionsCommandFlags.def"<br>
 }<br>
<br>
 // Used by llvm-tblgen<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>