<div dir="ltr">Working on a fix.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 4, 2017 at 6:15 AM, Yvan Roux <span dir="ltr"><<a href="mailto:yvan.roux@linaro.org" target="_blank">yvan.roux@linaro.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
AArch64 bot is broken since this commit, the issue is that these<br>
compiler-rt tests are not flagged as x86 specific and/or are not<br>
skipped if HAS_80_BIT_LONG_DOUBLE is not defined.<br>
<br>
builtins/Unit/divxc3_test.c<br>
builtins/Unit/mulxc3_test.c<br>
builtins/Unit/powixf2_test.c<br>
<br>
Yvan<br>
<br>
On 30 November 2017 at 20:39, Sterling Augustine via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: saugustine<br>
> Date: Thu Nov 30 11:39:33 2017<br>
> New Revision: 319464<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=319464&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=319464&view=rev</a><br>
> Log:<br>
> Move x86-specific sources to x86-specific source lists.<br>
><br>
> Modified:<br>
>     compiler-rt/trunk/lib/<wbr>builtins/CMakeLists.txt<br>
><br>
> Modified: compiler-rt/trunk/lib/<wbr>builtins/CMakeLists.txt<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/CMakeLists.txt?rev=319464&r1=319463&r2=319464&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/lib/<wbr>builtins/CMakeLists.txt?rev=<wbr>319464&r1=319463&r2=319464&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- compiler-rt/trunk/lib/<wbr>builtins/CMakeLists.txt (original)<br>
> +++ compiler-rt/trunk/lib/<wbr>builtins/CMakeLists.txt Thu Nov 30 11:39:33 2017<br>
> @@ -51,7 +51,6 @@ set(GENERIC_SOURCES<br>
>    cmpti2.c<br>
>    comparedf2.c<br>
>    comparesf2.c<br>
> -  cpu_model.c<br>
>    ctzdi2.c<br>
>    ctzsi2.c<br>
>    ctzti2.c<br>
> @@ -66,7 +65,6 @@ set(GENERIC_SOURCES<br>
>    divtc3.c<br>
>    divti3.c<br>
>    divtf3.c<br>
> -  divxc3.c<br>
>    extendsfdf2.c<br>
>    extendhfsf2.c<br>
>    ffsdi2.c<br>
> @@ -84,27 +82,18 @@ set(GENERIC_SOURCES<br>
>    fixunssfdi.c<br>
>    fixunssfsi.c<br>
>    fixunssfti.c<br>
> -  fixunsxfdi.c<br>
> -  fixunsxfsi.c<br>
> -  fixunsxfti.c<br>
> -  fixxfdi.c<br>
> -  fixxfti.c<br>
>    floatdidf.c<br>
>    floatdisf.c<br>
> -  floatdixf.c<br>
>    floatsidf.c<br>
>    floatsisf.c<br>
>    floattidf.c<br>
>    floattisf.c<br>
> -  floattixf.c<br>
>    floatundidf.c<br>
>    floatundisf.c<br>
> -  floatundixf.c<br>
>    floatunsidf.c<br>
>    floatunsisf.c<br>
>    floatuntidf.c<br>
>    floatuntisf.c<br>
> -  floatuntixf.c<br>
>    int_util.c<br>
>    lshrdi3.c<br>
>    lshrti3.c<br>
> @@ -124,7 +113,6 @@ set(GENERIC_SOURCES<br>
>    mulvdi3.c<br>
>    mulvsi3.c<br>
>    mulvti3.c<br>
> -  mulxc3.c<br>
>    negdf2.c<br>
>    negdi2.c<br>
>    negsf2.c<br>
> @@ -142,7 +130,6 @@ set(GENERIC_SOURCES<br>
>    powidf2.c<br>
>    powisf2.c<br>
>    powitf2.c<br>
> -  powixf2.c<br>
>    subdf3.c<br>
>    subsf3.c<br>
>    subvdi3.c<br>
> @@ -226,6 +213,23 @@ if (NOT FUCHSIA)<br>
>      clear_cache.c)<br>
>  endif()<br>
><br>
> +# These sources work on all x86 variants, but only x86 variants.<br>
> +set(x86_ARCH_SOURCES<br>
> +  cpu_model.c<br>
> +  divxc3.c<br>
> +  fixxfdi.c<br>
> +  fixxfti.c<br>
> +  fixunsxfdi.c<br>
> +  fixunsxfsi.c<br>
> +  fixunsxfti.c<br>
> +  floatdixf.c<br>
> +  floattixf.c<br>
> +  floatundixf.c<br>
> +  floatuntixf.c<br>
> +  mulxc3.c<br>
> +  powixf2.c<br>
> +)<br>
> +<br>
>  if (NOT MSVC)<br>
>    set(x86_64_SOURCES<br>
>        x86_64/chkstk.S<br>
> @@ -284,6 +288,11 @@ else () # MSVC<br>
>    set(i386_SOURCES ${GENERIC_SOURCES})<br>
>  endif () # if (NOT MSVC)<br>
><br>
> +set(x86_64h_SOURCES ${x86_64h_SOURCES} ${x86_ARCH_SOURCES})<br>
> +set(x86_64_SOURCES ${x86_64_SOURCES} ${x86_ARCH_SOURCES})<br>
> +set(i386_SOURCES ${i386_SOURCES} ${x86_ARCH_SOURCES})<br>
> +set(i686_SOURCES ${i686_SOURCES} ${x86_ARCH_SOURCES})<br>
> +<br>
>  set(arm_SOURCES<br>
>    arm/bswapdi2.S<br>
>    arm/bswapsi2.S<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>