<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Times New Roman \(Body CS\)";
panose-1:2 11 6 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;
font-weight:normal;
font-style:normal;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;
font-weight:normal;
font-style:normal;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Hi Nirav,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Some good news.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">I ran AArch64 NEON Emperor tests on r319547 (D40701). They all passed. So there are only the crash and Eli’s comment to deal with.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Evgeny<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Evgeny Astigeevich <Evgeny.Astigeevich@arm.com><br>
<b>Date: </b>Friday, 1 December 2017 at 23:55<br>
<b>To: </b>Nirav Davé <niravd@google.com><br>
<b>Cc: </b>"reviews+D40701+public+80177a37c4360e77@reviews.llvm.org" <reviews+D40701+public+80177a37c4360e77@reviews.llvm.org>, "Friedman, Eli" <efriedma@codeaurora.org>, "aemerson@apple.com" <aemerson@apple.com>, Javed Absar <Javed.Absar@arm.com>, Kristof
Beyls <Kristof.Beyls@arm.com>, "hiraditya@msn.com" <hiraditya@msn.com>, llvm-commits <llvm-commits@lists.llvm.org>, nd <nd@arm.com><br>
<b>Subject: </b>Re: [PATCH] D40701: [ARM][DAG] Reenable post-legalize store merge<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Hi Nirav,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">I am sending you a test reduced from spec2k6 which crashes llc. The crash does not happen on r319031. It happens on r319036 (D33675) and on r319547 (D40701).</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">$ llc -O3 -filetype=asm test_crash.ll</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">llc: ../lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:992: void (anonymous namespace)::SelectionDAGLegalize::LegalizeOp(llvm::SDNode *): Assertion `(TLI.getTypeAction(*DAG.getContext(), Op.getValueType())
== TargetLowering::TypeLegal || TLI.isTypeLegal(Op.getValueType()) || Op.getOpcode() == ISD::TargetConstant || Op.getOpcode() == ISD::Register) && "Unexpected illegal type!"' failed.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#0 0x0000000004ba9979 llvm::sys::PrintStackTrace(llvm::raw_ostream&) /work/repos/llvm01/build.d/../lib/Support/Unix/Signals.inc:398:11</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#1 0x0000000004ba9b29 PrintStackTraceSignalHandler(void*) /work/repos/llvm01/build.d/../lib/Support/Unix/Signals.inc:462:1</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#2 0x0000000004ba80d3 llvm::sys::RunSignalHandlers() /work/repos/llvm01/build.d/../lib/Support/Signals.cpp:0:5</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#3 0x0000000004ba9e84 SignalHandler(int) /work/repos/llvm01/build.d/../lib/Support/Unix/Signals.inc:252:1</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#4 0x00007f69bb817330 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x10330)</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#5 0x00007f69ba3f7c37 gsignal (/lib/x86_64-linux-gnu/libc.so.6+0x36c37)</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#6 0x00007f69ba3fb028 abort (/lib/x86_64-linux-gnu/libc.so.6+0x3a028)</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#7 0x00007f69ba3f0bf6 (/lib/x86_64-linux-gnu/libc.so.6+0x2fbf6)</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#8 0x00007f69ba3f0ca2 (/lib/x86_64-linux-gnu/libc.so.6+0x2fca2)</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#9 0x0000000004889029 (anonymous namespace)::SelectionDAGLegalize::LegalizeOp(llvm::SDNode*) /work/repos/llvm01/build.d/../lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:986:3</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#10 0x0000000004888b98 llvm::SelectionDAG::Legalize() /work/repos/llvm01/build.d/../lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:4672:13</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#11 0x00000000049c12ff llvm::SelectionDAGISel::CodeGenAndEmitDAG() /work/repos/llvm01/build.d/../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:821:13</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#12 0x00000000049bfba0 llvm::SelectionDAGISel::SelectBasicBlock(llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::Instruction, true, false, void>, false, true>, llvm::ilist_iterator<llvm::ilist_detail::node_options<llvm::Instruction,
true, false, void>, false, true>, bool&) /work/repos/llvm01/build.d/../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:665:1</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#13 0x00000000049bf8a1 llvm::SelectionDAGISel::SelectAllBasicBlocks(llvm::Function const&) /work/repos/llvm01/build.d/../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:0:7</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#14 0x00000000049bcc09 llvm::SelectionDAGISel::runOnMachineFunction(llvm::MachineFunction&) /work/repos/llvm01/build.d/../lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:467:22</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#15 0x0000000002609568 (anonymous namespace)::AArch64DAGToDAGISel::runOnMachineFunction(llvm::MachineFunction&) /work/repos/llvm01/build.d/../lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:58:5</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#16 0x0000000003dc41d1 llvm::MachineFunctionPass::runOnFunction(llvm::Function&) /work/repos/llvm01/build.d/../lib/CodeGen/MachineFunctionPass.cpp:62:8</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#17 0x000000000425faaf llvm::FPPassManager::runOnFunction(llvm::Function&) /work/repos/llvm01/build.d/../lib/IR/LegacyPassManager.cpp:1514:27</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#18 0x000000000425fdc5 llvm::FPPassManager::runOnModule(llvm::Module&) /work/repos/llvm01/build.d/../lib/IR/LegacyPassManager.cpp:1535:16</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#19 0x000000000426055a (anonymous namespace)::MPPassManager::runOnModule(llvm::Module&) /work/repos/llvm01/build.d/../lib/IR/LegacyPassManager.cpp:1591:27</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#20 0x0000000004260086 llvm::legacy::PassManagerImpl::run(llvm::Module&) /work/repos/llvm01/build.d/../lib/IR/LegacyPassManager.cpp:1694:16</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#21 0x0000000004260a71 llvm::legacy::PassManager::run(llvm::Module&) /work/repos/llvm01/build.d/../lib/IR/LegacyPassManager.cpp:1725:3</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#22 0x000000000246622d compileModule(char**, llvm::LLVMContext&) /work/repos/llvm01/build.d/../tools/llc/llc.cpp:572:41</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#23 0x000000000246488a main /work/repos/llvm01/build.d/../tools/llc/llc.cpp:346:13</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#24 0x00007f69ba3e2f45 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f45)</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">#25 0x0000000002464029 _start (/work/repos/llvm01/build.d/bin/llc+0x2464029)</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Thanks,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Evgeny</span><o:p></o:p></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"> </span><o:p></o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Nirav Davé <niravd@google.com><br>
<b>Date: </b>Friday, 1 December 2017 at 21:49<br>
<b>To: </b>Evgeny Astigeevich <Evgeny.Astigeevich@arm.com><br>
<b>Cc: </b>"reviews+D40701+public+80177a37c4360e77@reviews.llvm.org" <reviews+D40701+public+80177a37c4360e77@reviews.llvm.org>, "Friedman, Eli" <efriedma@codeaurora.org>, "aemerson@apple.com" <aemerson@apple.com>, Javed Absar <Javed.Absar@arm.com>, Kristof
Beyls <Kristof.Beyls@arm.com>, "hiraditya@msn.com" <hiraditya@msn.com>, llvm-commits <llvm-commits@lists.llvm.org>, nd <nd@arm.com><br>
<b>Subject: </b>Re: [PATCH] D40701: [ARM][DAG] Reenable post-legalize store merge</span><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a name="_MailOriginalBody">So to be clear: There are pending were pending issues in AArch64 as of r319036? <o:p></o:p></a></p>
</div>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody">On Fri, Dec 1, 2017 at 4:45 PM, Evgeny Astigeevich <</span><a href="mailto:Evgeny.Astigeevich@arm.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody">Evgeny.Astigeevich@arm.com</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody">>
wrote:<o:p></o:p></span></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody">Hi Nirav,<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody">I’ve just finished analysis of failures which had happened before this commit. Bisecting them I got r319036.<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody">Evgeny
<o:p></o:p></span></p>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"><b><span style="font-size:12.0pt;color:black">From:
</span></b></span><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">Nirav Davé <</span></span><a href="mailto:niravd@google.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">niravd@google.com</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">><br>
<b>Date: </b>Friday, 1 December 2017 at 21:41<br>
<b>To: </b>"</span></span><a href="mailto:reviews%2BD40701%2Bpublic%2B80177a37c4360e77@reviews.llvm.org" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">reviews+D40701+public+80177a37c4360e77@reviews.llvm.org</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">"
<</span></span><a href="mailto:reviews%2BD40701%2Bpublic%2B80177a37c4360e77@reviews.llvm.org" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">reviews+D40701+public+80177a37c4360e77@reviews.llvm.org</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">><br>
<b>Cc: </b>Evgeny Astigeevich <</span></span><a href="mailto:Evgeny.Astigeevich@arm.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">Evgeny.Astigeevich@arm.com</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">>,
"Friedman, Eli" <</span></span><a href="mailto:efriedma@codeaurora.org" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">efriedma@codeaurora.org</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">>,
"</span></span><a href="mailto:aemerson@apple.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">aemerson@apple.com</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">"
<</span></span><a href="mailto:aemerson@apple.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">aemerson@apple.com</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">>,
Javed Absar <</span></span><a href="mailto:Javed.Absar@arm.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">Javed.Absar@arm.com</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">>,
Kristof Beyls <</span></span><a href="mailto:Kristof.Beyls@arm.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">Kristof.Beyls@arm.com</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">>,
"</span></span><a href="mailto:hiraditya@msn.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">hiraditya@msn.com</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">"
<</span></span><a href="mailto:hiraditya@msn.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">hiraditya@msn.com</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">>,
llvm-commits <</span></span><a href="mailto:llvm-commits@lists.llvm.org" target="_blank"><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt">llvm-commits@lists.llvm.org</span></span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><span style="font-size:12.0pt;color:black">><br>
<b>Subject: </b>Re: [PATCH] D40701: [ARM][DAG] Reenable post-legalize store merge</span><o:p></o:p></span></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"><a name="m_-213997508068888985__MailOriginalBody">... and AArch64 was working correctly before this.</a><o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody">On Fri, Dec 1, 2017 at 4:40 PM, Nirav Davé <</span><a href="mailto:niravd@google.com" target="_blank"><span style="mso-bookmark:_MailOriginalBody">niravd@google.com</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody">>
wrote:<o:p></o:p></span></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody">Let me back out the last commit. Presumably the constant store merge fix I made was wrong. <o:p></o:p></span></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody">On Fri, Dec 1, 2017 at 4:33 PM, Evgeny Astigeevich via Phabricator <</span><a href="mailto:reviews@reviews.llvm.org" target="_blank"><span style="mso-bookmark:_MailOriginalBody">reviews@reviews.llvm.org</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody">>
wrote:<o:p></o:p></span></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody">eastig added a comment.<br>
<br>
Nirav,<br>
<br>
There are stability and correctness issues on AArch64. The similar issues might exist on other ARM targets. Could you please disable MergeConsecutiveStores for all ARM targets including AArch64?<br>
<br>
Thanks,<br>
Evgeny<o:p></o:p></span></p>
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;margin-bottom:12.0pt"><span style="mso-bookmark:_MailOriginalBody"><br>
<br>
Repository:<br>
rL LLVM<br>
<br>
</span><a href="https://reviews.llvm.org/D40701" target="_blank"><span style="mso-bookmark:_MailOriginalBody">https://reviews.llvm.org/D40701</span><span style="mso-bookmark:_MailOriginalBody"></span></a><span style="mso-bookmark:_MailOriginalBody"><br>
<br>
<br>
<o:p></o:p></span></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><span style="mso-bookmark:_MailOriginalBody"> <o:p></o:p></span></p>
</div>
</div>
</body>
</html>