<div dir="ltr">So to be clear: There are pending were pending issues in AArch64 as of r319036? </div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 1, 2017 at 4:45 PM, Evgeny Astigeevich <span dir="ltr"><<a href="mailto:Evgeny.Astigeevich@arm.com" target="_blank">Evgeny.Astigeevich@arm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">





<div lang="EN-GB" link="blue" vlink="purple">
<div class="m_-213997508068888985WordSection1">
<p class="MsoNormal"><span>Hi Nirav,<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>I’ve just finished analysis of failures which had happened before this commit. Bisecting them I got r319036.<u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<p class="MsoNormal"><span>Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span>Evgeny <u></u><u></u></span></p>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">Nirav Davé <<a href="mailto:niravd@google.com" target="_blank">niravd@google.com</a>><br>
<b>Date: </b>Friday, 1 December 2017 at 21:41<br>
<b>To: </b>"<a href="mailto:reviews%2BD40701%2Bpublic%2B80177a37c4360e77@reviews.llvm.org" target="_blank">reviews+D40701+public+<wbr>80177a37c4360e77@reviews.llvm.<wbr>org</a>" <<a href="mailto:reviews%2BD40701%2Bpublic%2B80177a37c4360e77@reviews.llvm.org" target="_blank">reviews+D40701+public+<wbr>80177a37c4360e77@reviews.llvm.<wbr>org</a>><br>
<b>Cc: </b>Evgeny Astigeevich <<a href="mailto:Evgeny.Astigeevich@arm.com" target="_blank">Evgeny.Astigeevich@arm.com</a>>, "Friedman, Eli" <<a href="mailto:efriedma@codeaurora.org" target="_blank">efriedma@codeaurora.org</a>>, "<a href="mailto:aemerson@apple.com" target="_blank">aemerson@apple.com</a>" <<a href="mailto:aemerson@apple.com" target="_blank">aemerson@apple.com</a>>, Javed Absar <<a href="mailto:Javed.Absar@arm.com" target="_blank">Javed.Absar@arm.com</a>>, Kristof Beyls <<a href="mailto:Kristof.Beyls@arm.com" target="_blank">Kristof.Beyls@arm.com</a>>, "<a href="mailto:hiraditya@msn.com" target="_blank">hiraditya@msn.com</a>" <<a href="mailto:hiraditya@msn.com" target="_blank">hiraditya@msn.com</a>>,
 llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Subject: </b>Re: [PATCH] D40701: [ARM][DAG] Reenable post-legalize store merge<u></u><u></u></span></p>
</div><div><div class="h5">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal"><a name="m_-213997508068888985__MailOriginalBody">... and AArch64 was working correctly before this.<u></u><u></u></a></p>
</div>
<div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<div>
<p class="MsoNormal"><span>On Fri, Dec 1, 2017 at 4:40 PM, Nirav Davé <</span><a href="mailto:niravd@google.com" target="_blank"><span>niravd@google.com</span><span></span></a><span>>
 wrote:<u></u><u></u></span></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<p class="MsoNormal"><span>Let me back out the last commit. Presumably the constant store merge fix I made was wrong. <u></u><u></u></span></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
<div>
<p class="MsoNormal"><span>On Fri, Dec 1, 2017 at 4:33 PM, Evgeny Astigeevich via Phabricator <</span><a href="mailto:reviews@reviews.llvm.org" target="_blank"><span>reviews@reviews.llvm.org</span><span></span></a><span>>
 wrote:<u></u><u></u></span></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><span>eastig added a comment.<br>
<br>
Nirav,<br>
<br>
There are stability and correctness issues on AArch64. The similar issues might exist on other ARM targets. Could you please disable MergeConsecutiveStores for all ARM targets including AArch64?<br>
<br>
Thanks,<br>
Evgeny<u></u><u></u></span></p>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
</span><a href="https://reviews.llvm.org/D40701" target="_blank"><span>https://reviews.llvm.org/<wbr>D40701</span><span></span></a><span><br>
<br>
<br>
<u></u><u></u></span></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><span><u></u> <u></u></span></p>
</div>
</div></div></div>
</div>

</blockquote></div><br></div>