<div dir="ltr">This almost works.  I'm getting some errors about multiprocessing.cpu_count() being unable to determine the number of CPUs on my machine.  It looks like llvm has its own cpu count detection function in lit/lit/util.py.  I guess we should use that?  Not sure why it's broken on my machine.  I can fix this later since it seems to be specific to my machine.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 29, 2017 at 9:11 AM Adam Nemet <<a href="mailto:anemet@apple.com">anemet@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><blockquote type="cite"><div>On Nov 28, 2017, at 5:44 PM, Adam Nemet <<a href="mailto:anemet@apple.com" target="_blank">anemet@apple.com</a>> wrote:</div><br class="m_-6934813564913237323Apple-interchange-newline"><div><blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br class="m_-6934813564913237323Apple-interchange-newline">On Nov 28, 2017, at 5:39 PM, Davide Italiano <<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>> wrote:<br><br>On Tue, Nov 28, 2017 at 4:12 PM, Adam Nemet via llvm-commits<br><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br><blockquote type="cite"><br>On Nov 28, 2017, at 3:56 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br><br>This is failing for me on Windows.<br><br>$ "C:\Python27\python.exe"<br>"D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py" "-s"<br>"D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs" "-o"<br>"D:\src\llvmbuild\clang\Debug\x86\test\tools\opt-viewer\Output\basic.test.tmp"<br>"D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs/basic/or.yaml"<br>"--no-highlight"<br># command stderr:<br>Traceback (most recent call last):<br>File "D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py", line 20, in<br><module><br>  import optrecord<br>File "D:\src\llvm-mono\llvm\tools\opt-viewer\optrecord.py", line 30, in<br><module><br>  p = subprocess.Popen(['c++filt', '-n'], stdin=subprocess.PIPE,<br>stdout=subprocess.PIPE)<br>File "C:\Python27\lib\subprocess.py", line 390, in __init__<br>  errread, errwrite)<br>File "C:\Python27\lib\subprocess.py", line 640, in _execute_child<br>  startupinfo)<br>WindowsError: [Error 2] The system cannot find the file specified<br><br>error: command failed with exit status: 1<br><br>What is c++filt supposed to be, because I don't have it.<br><br></blockquote><br>You can probably fallback on llvm-cxxfilt, for Itanium, and leave the<br>symbol unmangled on Windows.<br></blockquote><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">Yeah, I think I just add an option to override the demangler and pass in llvm-cxxfilt from the build when running the test.  The main problem was that macOS does not have llvm-cxxfilt installed.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"></div></blockquote><div><br></div></div></div><div style="word-wrap:break-word"><div>r319324 implements this.  Please let me know if this works on Windows.</div><div><br></div><div>Thanks,</div><div>Adam</div></div><div style="word-wrap:break-word"><div><br><blockquote type="cite"><div><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><br><blockquote type="cite"><br>It’s the binutils demangler, I’ll fix it later.  Reverted in r319262.  Sorry<br>about the breakage.<br><br><br>On Mon, Nov 27, 2017 at 11:01 AM Adam Nemet via Phabricator via llvm-commits<br><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br><blockquote type="cite"><br>This revision was automatically updated to reflect the committed changes.<br>Closed by commit rL319073: Add opt-viewer testing (authored by anemet).<br><br>Repository:<br>rL LLVM<br><br><a href="https://reviews.llvm.org/D40202" target="_blank">https://reviews.llvm.org/D40202</a><br><br>Files:<br>llvm/trunk/cmake/config-ix.cmake<br>llvm/trunk/test/<a href="http://lit.cfg.py" target="_blank">lit.cfg.py</a><br>llvm/trunk/test/<a href="http://lit.site.cfg.py.in" target="_blank">lit.site.cfg.py.in</a><br>llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.c<br>llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.h<br>llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.yaml<br>llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.c.html<br>llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.h.html<br>llvm/trunk/test/tools/opt-viewer/Outputs/basic/index.html<br>llvm/trunk/test/tools/opt-viewer/Outputs/basic/style.css<br>llvm/trunk/test/tools/opt-viewer/basic.test<br>llvm/trunk/test/tools/opt-viewer/lit.local.cfg<br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br></blockquote><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br><br></blockquote><br>--<span class="m_-6934813564913237323Apple-converted-space"> </span><br>Davide<br><br>"There are no solved problems; there are only problems that are more<br>or less solved" -- Henri Poincare</blockquote></div></blockquote></div><br></div></blockquote></div>