<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 28, 2017, at 5:44 PM, Adam Nemet <<a href="mailto:anemet@apple.com" class="">anemet@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class="Apple-interchange-newline">On Nov 28, 2017, at 5:39 PM, Davide Italiano <<a href="mailto:davide@freebsd.org" class="">davide@freebsd.org</a>> wrote:<br class=""><br class="">On Tue, Nov 28, 2017 at 4:12 PM, Adam Nemet via llvm-commits<br class=""><<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><blockquote type="cite" class=""><br class="">On Nov 28, 2017, at 3:56 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:<br class=""><br class="">This is failing for me on Windows.<br class=""><br class="">$ "C:\Python27\python.exe"<br class="">"D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py" "-s"<br class="">"D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs" "-o"<br class="">"D:\src\llvmbuild\clang\Debug\x86\test\tools\opt-viewer\Output\basic.test.tmp"<br class="">"D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs/basic/or.yaml"<br class="">"--no-highlight"<br class=""># command stderr:<br class="">Traceback (most recent call last):<br class="">File "D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py", line 20, in<br class=""><module><br class=""> import optrecord<br class="">File "D:\src\llvm-mono\llvm\tools\opt-viewer\optrecord.py", line 30, in<br class=""><module><br class=""> p = subprocess.Popen(['c++filt', '-n'], stdin=subprocess.PIPE,<br class="">stdout=subprocess.PIPE)<br class="">File "C:\Python27\lib\subprocess.py", line 390, in __init__<br class=""> errread, errwrite)<br class="">File "C:\Python27\lib\subprocess.py", line 640, in _execute_child<br class=""> startupinfo)<br class="">WindowsError: [Error 2] The system cannot find the file specified<br class=""><br class="">error: command failed with exit status: 1<br class=""><br class="">What is c++filt supposed to be, because I don't have it.<br class=""><br class=""></blockquote><br class="">You can probably fallback on llvm-cxxfilt, for Itanium, and leave the<br class="">symbol unmangled on Windows.<br class=""></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Yeah, I think I just add an option to override the demangler and pass in llvm-cxxfilt from the build when running the test. The main problem was that macOS does not have llvm-cxxfilt installed.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div>r319324 implements this. Please let me know if this works on Windows.</div><div><br class=""></div><div>Thanks,</div><div>Adam</div><div><br class=""><blockquote type="cite" class=""><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class=""><blockquote type="cite" class=""><br class="">It’s the binutils demangler, I’ll fix it later. Reverted in r319262. Sorry<br class="">about the breakage.<br class=""><br class=""><br class="">On Mon, Nov 27, 2017 at 11:01 AM Adam Nemet via Phabricator via llvm-commits<br class=""><<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><blockquote type="cite" class=""><br class="">This revision was automatically updated to reflect the committed changes.<br class="">Closed by commit rL319073: Add opt-viewer testing (authored by anemet).<br class=""><br class="">Repository:<br class="">rL LLVM<br class=""><br class=""><a href="https://reviews.llvm.org/D40202" class="">https://reviews.llvm.org/D40202</a><br class=""><br class="">Files:<br class="">llvm/trunk/cmake/config-ix.cmake<br class="">llvm/trunk/test/lit.cfg.py<br class="">llvm/trunk/test/lit.site.cfg.py.in<br class="">llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.c<br class="">llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.h<br class="">llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.yaml<br class="">llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.c.html<br class="">llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.h.html<br class="">llvm/trunk/test/tools/opt-viewer/Outputs/basic/index.html<br class="">llvm/trunk/test/tools/opt-viewer/Outputs/basic/style.css<br class="">llvm/trunk/test/tools/opt-viewer/basic.test<br class="">llvm/trunk/test/tools/opt-viewer/lit.local.cfg<br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class="">llvm-commits@lists.llvm.org<br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></blockquote><br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""><br class=""></blockquote><br class="">--<span class="Apple-converted-space"> </span><br class="">Davide<br class=""><br class="">"There are no solved problems; there are only problems that are more<br class="">or less solved" -- Henri Poincare</blockquote></div></blockquote></div><br class=""></body></html>