<div dir="ltr">I do have the environment variable set, so I'm not sure why it's failing. That said, I also haven't investigated, I'm letting the test fail for now until I have time to look into it.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 29, 2017 at 2:34 PM Shoaib Meenai <<a href="mailto:smeenai@fb.com">smeenai@fb.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="m_5974600922436171904WordSection1">
<p class="MsoNormal">Are you on Windows? Python 2.7 (and maybe early versions of 3, not sure, but it's definitely fixed to do things a proper way in 3.4 and above) rely on the NUMBER_OF_PROCESSORS environment variable to determine CPU count, so if you don't
have this environment variable set for some reason (e.g. if you're running over Cygwin SSH, shudder), you'll get that error.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">llvm-commits <<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@lists.llvm.org</a>> on behalf of Zachary Turner via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
<b>Reply-To: </b>Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>><br>
<b>Date: </b>Wednesday, November 29, 2017 at 4:38 PM<br>
<b>To: </b>Adam Nemet <<a href="mailto:anemet@apple.com" target="_blank">anemet@apple.com</a>><br>
<b>Cc: </b>llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>, "<a href="mailto:reviews%2BD40202%2Bpublic%2B40c851d838b3bc18@reviews.llvm.org" target="_blank">reviews+D40202+public+40c851d838b3bc18@reviews.llvm.org</a>" <<a href="mailto:reviews%2BD40202%2Bpublic%2B40c851d838b3bc18@reviews.llvm.org" target="_blank">reviews+D40202+public+40c851d838b3bc18@reviews.llvm.org</a>><br>
<b>Subject: </b>Re: [PATCH] D40202: Add opt-viewer testing<u></u><u></u></span></p>
</div></div></div><div bgcolor="white" lang="EN-US" link="blue" vlink="purple"><div class="m_5974600922436171904WordSection1">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">This almost works. I'm getting some errors about multiprocessing.cpu_count() being unable to determine the number of CPUs on my machine. It looks like llvm has its own cpu count detection function in lit/lit/util.py. I guess we should
use that? Not sure why it's broken on my machine. I can fix this later since it seems to be specific to my machine.<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Nov 29, 2017 at 9:11 AM Adam Nemet <<a href="mailto:anemet@apple.com" target="_blank">anemet@apple.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On Nov 28, 2017, at 5:44 PM, Adam Nemet <<a href="mailto:anemet@apple.com" target="_blank">anemet@apple.com</a>> wrote:<u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt;font-variant-caps:normal;text-align:start;word-spacing:0px">
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
On Nov 28, 2017, at 5:39 PM, Davide Italiano <<a href="mailto:davide@freebsd.org" target="_blank">davide@freebsd.org</a>> wrote:<br>
<br>
On Tue, Nov 28, 2017 at 4:12 PM, Adam Nemet via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
<br>
<u></u><u></u></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
On Nov 28, 2017, at 3:56 PM, Zachary Turner <<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>> wrote:<br>
<br>
This is failing for me on Windows.<br>
<br>
$ "C:\Python27\python.exe"<br>
"D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py" "-s"<br>
"D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs" "-o"<br>
"D:\src\llvmbuild\clang\Debug\x86\test\tools\opt-viewer\Output\basic.test.tmp"<br>
"D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs/basic/or.yaml"<br>
"--no-highlight"<br>
# command stderr:<br>
Traceback (most recent call last):<br>
File "D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py", line 20, in<br>
<module><br>
import optrecord<br>
File "D:\src\llvm-mono\llvm\tools\opt-viewer\optrecord.py", line 30, in<br>
<module><br>
p = subprocess.Popen(['c++filt', '-n'], stdin=subprocess.PIPE,<br>
stdout=subprocess.PIPE)<br>
File "C:\Python27\lib\subprocess.py", line 390, in __init__<br>
errread, errwrite)<br>
File "C:\Python27\lib\subprocess.py", line 640, in _execute_child<br>
startupinfo)<br>
WindowsError: [Error 2] The system cannot find the file specified<br>
<br>
error: command failed with exit status: 1<br>
<br>
What is c++filt supposed to be, because I don't have it.<u></u><u></u></span></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
You can probably fallback on llvm-cxxfilt, for Itanium, and leave the<br>
symbol unmangled on Windows.<u></u><u></u></span></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
Yeah, I think I just add an option to override the demangler and pass in llvm-cxxfilt from the build when running the test. The main problem was that macOS does not have llvm-cxxfilt installed.</span><u></u><u></u></p>
</div>
</blockquote>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div>
<div>
<div>
<p class="MsoNormal">r319324 implements this. Please let me know if this works on Windows.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Adam<u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><br>
<br>
<u></u><u></u></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br style="font-variant-caps:normal;text-align:start;word-spacing:0px">
<br>
</span><u></u><u></u></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
<br>
<u></u><u></u></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
It’s the binutils demangler, I’ll fix it later. Reverted in r319262. Sorry<br>
about the breakage.<br>
<br>
<br>
On Mon, Nov 27, 2017 at 11:01 AM Adam Nemet via Phabricator via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
<br>
<u></u><u></u></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL319073: Add opt-viewer testing (authored by anemet).<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D40202&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=ZNEuwtNRZW8u4eaFSVmMyuiiN8FGgkN3M2Tm5MavjVk&s=tUg2afM68teE08YQcwoEyAwp1kEQ9ZrdXY1PJXIWRx8&e=" target="_blank">https://reviews.llvm.org/D40202</a><br>
<br>
Files:<br>
llvm/trunk/cmake/config-ix.cmake<br>
llvm/trunk/test/<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lit.cfg.py&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=ZNEuwtNRZW8u4eaFSVmMyuiiN8FGgkN3M2Tm5MavjVk&s=TuI4rB-uMaSUXYCXTVKDaMd4UmbeWXS8g_IDRbwvgWg&e=" target="_blank">lit.cfg.py</a><br>
llvm/trunk/test/<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lit.site.cfg.py.in&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=ZNEuwtNRZW8u4eaFSVmMyuiiN8FGgkN3M2Tm5MavjVk&s=mQHZ_QfhLd1SuqIT2DgXY_gklcVdky1-Z1NqC3rpE8Y&e=" target="_blank">lit.site.cfg.py.in</a><br>
llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.c<br>
llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.h<br>
llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.yaml<br>
llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.c.html<br>
llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.h.html<br>
llvm/trunk/test/tools/opt-viewer/Outputs/basic/index.html<br>
llvm/trunk/test/tools/opt-viewer/Outputs/basic/style.css<br>
llvm/trunk/test/tools/opt-viewer/basic.test<br>
llvm/trunk/test/tools/opt-viewer/lit.local.cfg<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=ZNEuwtNRZW8u4eaFSVmMyuiiN8FGgkN3M2Tm5MavjVk&s=zxkCoQu0Jo_eXcDT9-rbokeQy1L-XgeGgS089h9rQQk&e=" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></span></p>
</blockquote>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=ZNEuwtNRZW8u4eaFSVmMyuiiN8FGgkN3M2Tm5MavjVk&s=zxkCoQu0Jo_eXcDT9-rbokeQy1L-XgeGgS089h9rQQk&e=" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></span></p>
</blockquote>
<p class="MsoNormal"><span style="font-size:9.0pt;font-family:"Helvetica",sans-serif"><br>
--<span class="m_5974600922436171904m-6934813564913237323apple-converted-space"> </span><br>
Davide<br>
<br>
"There are no solved problems; there are only problems that are more<br>
or less solved" -- Henri Poincare<u></u><u></u></span></p>
</blockquote>
</div>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</blockquote>
</div>
</div></div></blockquote></div>