<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 28, 2017, at 3:56 PM, Zachary Turner <<a href="mailto:zturner@google.com" class="">zturner@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">This is failing for me on Windows.<div class=""><br class=""></div><div class=""><div class="">$ "C:\Python27\python.exe" "D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py" "-s" "D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs" "-o" "D:\src\llvmbuild\clang\Debug\x86\test\tools\opt-viewer\Output\basic.test.tmp" "D:\src\llvm-mono\llvm\test\tools\opt-viewer/Inputs/basic/or.yaml" "--no-highlight"</div><div class=""># command stderr:</div><div class="">Traceback (most recent call last):</div><div class=""> File "D:/src/llvm-mono/llvm/tools/opt-viewer/opt-viewer.py", line 20, in <module></div><div class=""> import optrecord</div><div class=""> File "D:\src\llvm-mono\llvm\tools\opt-viewer\optrecord.py", line 30, in <module></div><div class=""> p = subprocess.Popen(['c++filt', '-n'], stdin=subprocess.PIPE, stdout=subprocess.PIPE)</div><div class=""> File "C:\Python27\lib\subprocess.py", line 390, in __init__</div><div class=""> errread, errwrite)</div><div class=""> File "C:\Python27\lib\subprocess.py", line 640, in _execute_child</div><div class=""> startupinfo)</div><div class="">WindowsError: [Error 2] The system cannot find the file specified</div><div class=""><br class=""></div><div class="">error: command failed with exit status: 1</div></div><div class=""><br class=""></div><div class="">What is c++filt supposed to be, because I don't have it.</div></div></div></blockquote><div><br class=""></div><div>It’s the binutils demangler, I’ll fix it later. Reverted in r319262. Sorry about the breakage.</div><br class=""><blockquote type="cite" class=""><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_quote" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr" class="">On Mon, Nov 27, 2017 at 11:01 AM Adam Nemet via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex;">This revision was automatically updated to reflect the committed changes.<br class="">Closed by commit rL319073: Add opt-viewer testing (authored by anemet).<br class=""><br class="">Repository:<br class=""> <span class="Apple-converted-space"> </span>rL LLVM<br class=""><br class=""><a href="https://reviews.llvm.org/D40202" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D40202</a><br class=""><br class="">Files:<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/cmake/config-ix.cmake<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/<a href="http://lit.cfg.py/" rel="noreferrer" target="_blank" class="">lit.cfg.py</a><br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/<a href="http://lit.site.cfg.py.in/" rel="noreferrer" target="_blank" class="">lit.site.cfg.py.in</a><br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.c<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.h<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/tools/opt-viewer/Inputs/basic/or.yaml<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.c.html<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/tools/opt-viewer/Outputs/basic/basic_or.h.html<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/tools/opt-viewer/Outputs/basic/index.html<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/tools/opt-viewer/Outputs/basic/style.css<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/tools/opt-viewer/basic.test<br class=""> <span class="Apple-converted-space"> </span>llvm/trunk/test/tools/opt-viewer/lit.local.cfg<br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class=""><a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a></blockquote></div></div></blockquote></div><br class=""></body></html>