<div dir="ltr">Right.  Looking into it.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 28, 2017 at 4:50 PM, Galina Kistanova <span dir="ltr"><<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div><span style="font-family:monospace,monospace">One more builder is affected:<br><a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win" target="_blank">http://lab.llvm.org:8011/<wbr>builders/llvm-clang-x86_64-<wbr>expensive-checks-win</a><br><br></span></div></div><span style="font-family:monospace,monospace">Thanks<span class="HOEnZb"><font color="#888888"><br><br></font></span></span></div><span class="HOEnZb"><font color="#888888"><span style="font-family:monospace,monospace">Galina</span><br></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 28, 2017 at 3:41 PM, Galina Kistanova <span dir="ltr"><<a href="mailto:gkistanova@gmail.com" target="_blank">gkistanova@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span style="font-family:monospace,monospace">Hello Don,<br><br>This commit broke few bots.<br>Could you take care of this, please?<br><br>The some of the bots are heavy and slow, so sooner you will make them back green, the better.<br><br>r319175 is green: <a href="http://lab.llvm.org:8011/builders/lld-x86_64-win7/builds/16088" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/lld-x86_64-win7/builds/<wbr>16088</a><br>r319176 is red: <a href="http://lab.llvm.org:8011/builders/lld-x86_64-win7/builds/16094" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/lld-x86_64-win7/builds/<wbr>16094</a><br><br>. . . <br>FAILED: cmd.exe /C "cd /D C:\lld-x86_64_win7\lld-x86_64-<wbr>win7\llvm.obj\NATIVE && "C:\Program Files (x86)\CMake\bin\cmake.exe" -G Ninja C:/lld-x86_64_win7/lld-x86_64-<wbr>win7/llvm.src -DLLVM_TARGET_IS_CROSSCOMPILE_<wbr>HOST=TRUE -DLLVM_TARGETS_TO_BUILD=AArch6<wbr>4 AMDGPU ARM BPF Hexagon Lanai Mips MSP430 NVPTX PowerPC Sparc SystemZ X86 XCore -DCMAKE_BUILD_TYPE=Release"<br>CMake Error: The source directory "C:/lld-x86_64_win7/lld-x86_64<wbr>-win7/llvm.obj/NATIVE/XCore" does not exist.<br><br><br>Also at least two more bots are affected:<br><br><a href="http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/6965" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/clang-with-thin-lto-ubuntu<wbr>/builds/6965</a><br>. . .<br>FAILED: NATIVE/CMakeCache.txt <br>cd /home/buildslave/ps4-buildslav<wbr>e1/clang-with-thin-lto-ubuntu/<wbr>build/stage2/NATIVE && /usr/local/bin/cmake -G Ninja /home/buildslave/ps4-buildslav<wbr>e1/clang-with-thin-lto-ubuntu/<wbr>llvm.src -DLLVM_TARGET_IS_CROSSCOMPILE_<wbr>HOST=TRUE -DLLVM_TARGETS_TO_BUILD=AArch6<wbr>4 AMDGPU ARM BPF Hexagon Lanai Mips MSP430 NVPTX PowerPC Sparc SystemZ X86 XCore -DCMAKE_BUILD_TYPE=Release<br>CMake Error: The source directory "/home/buildslave/ps4-buildsla<wbr>ve1/clang-with-thin-lto-<wbr>ubuntu/build/stage2/NATIVE/<wbr>XCore" does not exist.<br><br><br><a href="http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/6970" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/clang-with-thin-lto-ubuntu<wbr>/builds/6970</a><br></span><span style="font-family:monospace,monospace"><span style="font-family:monospace,monospace">. . .<br></span>FAILED: NATIVE/CMakeCache.txt <br>cd /home/buildslave/ps4-buildslav<wbr>e1/clang-with-thin-lto-ubuntu/<wbr>build/stage2/NATIVE && /usr/local/bin/cmake -G Ninja /home/buildslave/ps4-buildslav<wbr>e1/clang-with-thin-lto-ubuntu/<wbr>llvm.src -DLLVM_TARGET_IS_CROSSCOMPILE_<wbr>HOST=TRUE -DLLVM_TARGETS_TO_BUILD=AArch6<wbr>4 AMDGPU ARM BPF Hexagon Lanai Mips MSP430 NVPTX PowerPC Sparc SystemZ X86 XCore -DCMAKE_BUILD_TYPE=Release<br>CMake Error: The source directory "/home/buildslave/ps4-buildsla<wbr>ve1/clang-with-thin-lto-<wbr>ubuntu/build/stage2/NATIVE/<wbr>XCore" does not exist.<br><br>Thanks<span class="m_5639254082856579115HOEnZb"><font color="#888888"><br><br>Galina<br></font></span></span></div><div class="m_5639254082856579115HOEnZb"><div class="m_5639254082856579115h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 28, 2017 at 8:08 AM, Don Hinton via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dhinton<br>
Date: Tue Nov 28 08:08:57 2017<br>
New Revision: 319176<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=319176&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=319176&view=rev</a><br>
Log:<br>
[cmake] Remove redundant call to cmake when building host tools.<br>
<br>
Summary:<br>
Remove the redundant, config-time call to cmake when<br>
building host tools for cross compiles or optimized tablegen..<br>
<br>
The config-time call to cmake is redundant because it will always get<br>
called again when the CONFIGURE_LLVM_${target_name} target fires at<br>
build-time.  This speeds up initial configuration, but has no affect<br>
on build behavior.<br>
<br>
Reviewers: beanz<br>
<br>
Reviewed By: beanz<br>
<br>
Subscribers: mgorny, llvm-commits<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D40229" rel="noreferrer" target="_blank">https://reviews.llvm.org/D4022<wbr>9</a><br>
<br>
Modified:<br>
    llvm/trunk/cmake/modules/Cross<wbr>Compile.cmake<br>
<br>
Modified: llvm/trunk/cmake/modules/Cross<wbr>Compile.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/cmake/modules/CrossCompile.cmake?rev=319176&r1=319175&r2=319176&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/cmake/modules<wbr>/CrossCompile.cmake?rev=319176<wbr>&r1=319175&r2=319176&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/cmake/modules/Cross<wbr>Compile.cmake (original)<br>
+++ llvm/trunk/cmake/modules/Cross<wbr>Compile.cmake Tue Nov 28 08:08:57 2017<br>
@@ -12,6 +12,14 @@ function(llvm_create_cross_tar<wbr>get_intern<br>
         CACHE STRING "Toolchain file for ${target_name}")<br>
   endif()<br>
<br>
+  if (buildtype)<br>
+    set(build_type_flags "-DCMAKE_BUILD_TYPE=${buildtyp<wbr>e}")<br>
+  endif()<br>
+  if (LLVM_EXTERNAL_CLANG_SOURCE_DI<wbr>R)<br>
+    # Propagate LLVM_EXTERNAL_CLANG_SOURCE_DIR so that clang-tblgen can be built<br>
+    set(external_clang_dir "-DLLVM_EXTERNAL_CLANG_SOURCE_<wbr>DIR=${LLVM_EXTERNAL_CLANG_SOUR<wbr>CE_DIR}")<br>
+  endif()<br>
+<br>
   add_custom_command(OUTPUT ${LLVM_${target_name}_BUILD}<br>
     COMMAND ${CMAKE_COMMAND} -E make_directory ${LLVM_${target_name}_BUILD}<br>
     COMMENT "Creating ${LLVM_${target_name}_BUILD}..<wbr>.")<br>
@@ -23,6 +31,8 @@ function(llvm_create_cross_tar<wbr>get_intern<br>
     COMMAND ${CMAKE_COMMAND} -G "${CMAKE_GENERATOR}"<br>
         ${CROSS_TOOLCHAIN_FLAGS_${tar<wbr>get_name}} ${CMAKE_SOURCE_DIR}<br>
         -DLLVM_TARGET_IS_CROSSCOMPILE<wbr>_HOST=TRUE<br>
+        -DLLVM_TARGETS_TO_BUILD=${LLVM<wbr>_TARGETS_TO_BUILD}<br>
+        ${build_type_flags} ${external_clang_dir}<br>
     WORKING_DIRECTORY ${LLVM_${target_name}_BUILD}<br>
     DEPENDS CREATE_LLVM_${target_name}<br>
     COMMENT "Configuring ${target_name} LLVM...")<br>
@@ -30,32 +40,6 @@ function(llvm_create_cross_tar<wbr>get_intern<br>
   add_custom_target(CONFIGURE_L<wbr>LVM_${target_name}<br>
                     DEPENDS ${LLVM_${target_name}_BUILD}/C<wbr>MakeCache.txt)<br>
<br>
-  set_directory_properties(PROPE<wbr>RTIES ADDITIONAL_MAKE_CLEAN_FILES<br>
-                                      ${LLVM_${target_name}_BUILD})<br>
-<br>
-  if(NOT IS_DIRECTORY ${LLVM_${target_name}_BUILD})<br>
-<br>
-<br>
-    message(STATUS "Configuring ${target_name} build...")<br>
-    execute_process(COMMAND ${CMAKE_COMMAND} -E make_directory<br>
-      ${LLVM_${target_name}_BUILD} )<br>
-<br>
-    message(STATUS "Configuring ${target_name} targets...")<br>
-    if (buildtype)<br>
-      set(build_type_flags "-DCMAKE_BUILD_TYPE=${buildtyp<wbr>e}")<br>
-    endif()<br>
-       if (LLVM_EXTERNAL_CLANG_SOURCE_DI<wbr>R)<br>
-         # Propagate LLVM_EXTERNAL_CLANG_SOURCE_DIR so that clang-tblgen can be built<br>
-         set(external_clang_dir "-DLLVM_EXTERNAL_CLANG_SOURCE_<wbr>DIR=${LLVM_EXTERNAL_CLANG_SOUR<wbr>CE_DIR}")<br>
-       endif()<br>
-    execute_process(COMMAND ${CMAKE_COMMAND} ${build_type_flags}<br>
-        -G "${CMAKE_GENERATOR}" -DLLVM_TARGETS_TO_BUILD=${LLVM<wbr>_TARGETS_TO_BUILD}<br>
-        ${CROSS_TOOLCHAIN_FLAGS_${targ<wbr>et_name}} ${CMAKE_SOURCE_DIR}<br>
-        -DLLVM_TARGET_IS_CROSSCOMPILE_<wbr>HOST=TRUE<br>
-        ${external_clang_dir}<br>
-      WORKING_DIRECTORY ${LLVM_${target_name}_BUILD} )<br>
-  endif(NOT IS_DIRECTORY ${LLVM_${target_name}_BUILD})<br>
-<br>
 endfunction()<br>
<br>
 function(llvm_create_cross_ta<wbr>rget target_name sysroot)<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>