<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.stdout
{mso-style-name:stdout;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Eli,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">The instructions that are failing in the build are the ones that I removed support for in this patch. They are pre-UAL syntax, and we don’t support this generally,
so I think the long-term solution is to fix the code to use the UAL syntax instead.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Do you know who I should contact in AOSP about getting that code updated?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">The alternative would be to revert this and keep these aliases, but I’d rather not do that for the reasons discussed in
<a href="https://reviews.llvm.org/D39196">https://reviews.llvm.org/D39196</a>.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Oliver<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext"> Friedman, Eli [mailto:efriedma@codeaurora.org]
<br>
<b>Sent:</b> 22 November 2017 19:34<br>
<b>To:</b> Oliver Stannard; llvm-commits@lists.llvm.org<br>
<b>Subject:</b> Re: [llvm] r318777 - [ARM] Remove pre-UAL FLDM/FSTM aliases<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 11/21/2017 8:20 AM, Oliver Stannard via llvm-commits wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>Author: olista01<o:p></o:p></pre>
<pre>Date: Tue Nov 21 08:20:25 2017<o:p></o:p></pre>
<pre>New Revision: 318777<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=318777&view=rev">http://llvm.org/viewvc/llvm-project?rev=318777&view=rev</a><o:p></o:p></pre>
<pre>Log:<o:p></o:p></pre>
<pre>[ARM] Remove pre-UAL FLDM/FSTM aliases<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>These are pre-UAL syntax, and we don't support any other pre-UAL instructions,<o:p></o:p></pre>
<pre>with the exception of FLDMX/FSTMX, which don't have a UAL equivalent. Therefore<o:p></o:p></pre>
<pre>there's no reason to keep them or their AsmParser hacks around.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>With the AsmParser hacks removed, the FLDMX and FSTMX instructions get the same<o:p></o:p></pre>
<pre>operand diagnostics as the UAL instructions.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Differential revision: <a href="https://reviews.llvm.org/D39196">https://reviews.llvm.org/D39196</a><o:p></o:p></pre>
</blockquote>
<p class="MsoNormal"><br>
This is causing a failure on the polly AOSP buildbot (<a href="http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/336/steps/build-aosp/logs/stdio">http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/336/steps/build-aosp/logs/stdio</a>).
Error message:<br>
<br>
<br>
<o:p></o:p></p>
<pre><span class="stdout"><span style="font-size:13.5pt">frameworks/av/media/libstagefright/codecs/aacenc/src/asm/ARMV7/PrePostMDCT_v7.s:31:2: error: invalid instruction<o:p></o:p></span></span></pre>
<pre><span class="stdout"><span style="font-size:13.5pt"> fstmfdd sp!, {d8 - d15}<o:p></o:p></span></span></pre>
<pre><span class="stdout"><span style="font-size:13.5pt"> ^<o:p></o:p></span></span></pre>
<p class="MsoNormal">-Eli<br>
<br>
<o:p></o:p></p>
<pre>-- <o:p></o:p></pre>
<pre>Employee of Qualcomm Innovation Center, Inc.<o:p></o:p></pre>
<pre>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project<o:p></o:p></pre>
</div>
</div>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
or store or copy the information in any medium. Thank you.
</body>
</html>