If it works and you’re already done that’s fine.  I was just trying to save you some time :)<br><br>Lgtm<br><div class="gmail_quote"><div dir="ltr">On Mon, Nov 20, 2017 at 4:26 PM Ying Yi <<a href="mailto:maggieyi666@gmail.com">maggieyi666@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Zachary,<br><br>

<p class="MsoNormal">Sorry just see your email. I have updated the internal diff
shell command to support the --strip-trailing-cr option. <span> </span>The option might be useful for comparing the files
which are generated on the different platform. Could you please let me know what
do you think?</p><p class="MsoNormal"><br></p><p class="MsoNormal">Regards,</p><p class="MsoNormal"><br></p><p class="MsoNormal">Maggie<br></p>

</div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 21, 2017 at 12:23 AM, Ying Yi via Phabricator <span dir="ltr"><<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">MaggieYi updated this revision to Diff 123687.<br>
MaggieYi added a comment.<br>
<br>
The test of MC/AsmParser/preserve-comments-crlf.s failed since it uses the unsupported diff option --strip-trailing-cr. I updated the internal diff shell command to support this option.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D39567" rel="noreferrer" target="_blank">https://reviews.llvm.org/D39567</a><br>
<br>
Files:<br>
  utils/lit/lit/TestRunner.py<br>
  utils/lit/tests/Inputs/shtest-shell/check_path.py<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-1.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-2.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-3.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-4.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-5.txt<br>
  utils/lit/tests/Inputs/shtest-shell/diff-error-6.txt<br>
  utils/lit/tests/Inputs/shtest-shell/mkdir-error-0.txt<br>
  utils/lit/tests/Inputs/shtest-shell/mkdir-error-1.txt<br>
  utils/lit/tests/Inputs/shtest-shell/mkdir-error-2.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-0.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-1.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-2.txt<br>
  utils/lit/tests/Inputs/shtest-shell/rm-error-3.txt<br>
  utils/lit/tests/Inputs/shtest-shell/valid-shell.txt<br>
  utils/lit/tests/max-failures.py<br>
  utils/lit/tests/shtest-shell.py<br>
<br>
</blockquote></div><br><br clear="all"><br></div><div class="gmail_extra">-- <br><div class="m_-5127742934708392242gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><font size="2"><span style="font-family:arial,helvetica,sans-serif"></span></font><font face="Calibri" size="2"><span style="font-size:11pt"><font size="2"><span style="font-size:10pt"><font color="#1F497D" face="Arial">Ying Yi<br>SN Systems - Sony Interactive Entertainment</font></span></font></span></font><br></div></div></div></div></div></div></div></div>
</div></blockquote></div>