<div dir="ltr">Well, you never get anything if you don't ask :)</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 16, 2017 at 5:51 PM, Rafael Avila de Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It is probably better if you do it.<br>
<br>
Thanks,<br>
Rafael<br>
<div class="HOEnZb"><div class="h5"><br>
bd1976 llvm <<a href="mailto:bd1976llvm@gmail.com">bd1976llvm@gmail.com</a>> writes:<br>
<br>
> Shall I make the change to the gold test or are you happy to do it?<br>
><br>
> On Thu, Nov 16, 2017 at 5:43 PM, Rafael Avila de Espindola <<br>
> <a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br>
><br>
>> Oh, looks like the list is just really slow.<br>
>><br>
>> I reverted this since it broke a gold test. From your commit to lld it<br>
>> looks like the test is just missing an option to force pruning too.<br>
>><br>
>> Cheers,<br>
>> Rafael<br>
>><br>
>> Ben Dunbobbin via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> writes:<br>
>><br>
>> > Author: bd1976llvm<br>
>> > Date: Thu Nov 16 05:15:56 2017<br>
>> > New Revision: 318397<br>
>> ><br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=318397&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=318397&view=rev</a><br>
>> > Log:<br>
>> > [Support][CachePruning] Fix regression in pruning interval<br>
>> ><br>
>> > Fixed broken comparison.<br>
>> > borked by: rL284966 (see: <a href="https://reviews.llvm.org/D25730" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D25730</a>).<br>
>> ><br>
>> > Differential Revision: <a href="https://reviews.llvm.org/D40119" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D40119</a><br>
>> ><br>
>> > Modified:<br>
>> >     llvm/trunk/lib/Support/<wbr>CachePruning.cpp<br>
>> ><br>
>> > Modified: llvm/trunk/lib/Support/<wbr>CachePruning.cpp<br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/</a><br>
>> Support/CachePruning.cpp?rev=<wbr>318397&r1=318396&r2=318397&<wbr>view=diff<br>
>> > ==============================<wbr>==============================<br>
>> ==================<br>
>> > --- llvm/trunk/lib/Support/<wbr>CachePruning.cpp (original)<br>
>> > +++ llvm/trunk/lib/Support/<wbr>CachePruning.cpp Thu Nov 16 05:15:56 2017<br>
>> > @@ -161,7 +161,7 @@ bool llvm::pruneCache(StringRef Path, Ca<br>
>> >        return false;<br>
>> >      }<br>
>> >    } else {<br>
>> > -    if (Policy.Interval == seconds(0)) {<br>
>> > +    if (Policy.Interval != seconds(0)) {<br>
>> >        // Check whether the time stamp is older than our pruning<br>
>> interval.<br>
>> >        // If not, do nothing.<br>
>> >        const auto TimeStampModTime = FileStatus.<br>
>> getLastModificationTime();<br>
>> ><br>
>> ><br>
>> > ______________________________<wbr>_________________<br>
>> > llvm-commits mailing list<br>
>> > <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
>> > <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
>><br>
</div></div></blockquote></div><br></div>