<div dir="ltr">Nice. Thanks!</div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Nov 11, 2017 at 10:59 AM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Fri Nov 10 17:59:47 2017<br>
New Revision: 317965<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=317965&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=317965&view=rev</a><br>
Log:<br>
Simplify. NFC.<br>
<br>
copyFrom doesn't copy the Binding, so this was a nop.<br>
<br>
Modified:<br>
    lld/trunk/ELF/SymbolTable.cpp<br>
    lld/trunk/ELF/SymbolTable.h<br>
<br>
Modified: lld/trunk/ELF/SymbolTable.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.cpp?rev=317965&r1=317964&r2=317965&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/<wbr>SymbolTable.cpp?rev=317965&r1=<wbr>317964&r2=317965&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/SymbolTable.cpp (original)<br>
+++ lld/trunk/ELF/SymbolTable.cpp Fri Nov 10 17:59:47 2017<br>
@@ -156,7 +156,7 @@ template <class ELFT> void SymbolTable::<br>
     return;<br>
   Symbol *Real = addUndefined<ELFT>(Saver.save(<wbr>"__real_" + Name));<br>
   Symbol *Wrap = addUndefined<ELFT>(Saver.save(<wbr>"__wrap_" + Name));<br>
-  WrappedSymbols.push_back({Sym, Real, Wrap, Sym->Binding, Real->Binding});<br>
+  WrappedSymbols.push_back({Sym, Real, Wrap});<br>
<br>
   // We want to tell LTO not to inline symbols to be overwritten<br>
   // because LTO doesn't know the final symbol contents after renaming.<br>
@@ -192,9 +192,7 @@ void SymbolTable::applySymbolWrap() {<br>
<br>
     // Replace __real_sym with sym and sym with __wrap_sym.<br>
     W.Real->copyFrom(W.Sym);<br>
-    W.Real->Binding = W.RealBinding;<br>
     W.Sym->copyFrom(W.Wrap);<br>
-    W.Sym->Binding = W.SymBinding;<br>
<br>
     // We now have two copies of __wrap_sym. Drop one.<br>
     W.Wrap->IsUsedInRegularObj = false;<br>
<br>
Modified: lld/trunk/ELF/SymbolTable.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SymbolTable.h?rev=317965&r1=317964&r2=317965&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/<wbr>SymbolTable.h?rev=317965&r1=<wbr>317964&r2=317965&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/SymbolTable.h (original)<br>
+++ lld/trunk/ELF/SymbolTable.h Fri Nov 10 17:59:47 2017<br>
@@ -127,8 +127,6 @@ private:<br>
     Symbol *Sym;<br>
     Symbol *Real;<br>
     Symbol *Wrap;<br>
-    uint8_t SymBinding;<br>
-    uint8_t RealBinding;<br>
   };<br>
<br>
   // For -wrap.<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>