<div dir="ltr">Thanks. I'll fix it ASAP.<div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 14, 2017 at 1:23 PM, Hans Wennborg <span dir="ltr"><<a href="mailto:hans@chromium.org" target="_blank">hans@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Nov 14, 2017 at 11:14 AM, Artem Belevich via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
>  void NVPTXDAGToDAGISel::<wbr>SelectMatchAll(SDNode *N) {<br>
>    SDLoc DL(N);<br>
> +  SDValue Chain = N->getOperand(0);<br>
<br>
</span>Clang is warning that Chain isn't used anywhere:<br>
<br>
[2764/3792] Building CXX object<br>
lib/Target/NVPTX/CMakeFiles/<wbr>LLVMNVPTXCodeGen.dir/<wbr>NVPTXISelDAGToDAG.cpp.o<br>
../lib/Target/NVPTX/<wbr>NVPTXISelDAGToDAG.cpp:1078:11: warning: unused<br>
variable 'Chain' [-Wunused-variable]<br>
<span class="">  SDValue Chain = N->getOperand(0);<br>
</span>          ^<br>
1 warning generated.<br>
<div class="HOEnZb"><div class="h5"><br>
>    enum { IS_I64 = 4, HAS_CONST_VALUE = 2, HAS_CONST_MASK = 1 };<br>
> -  unsigned IID = cast<ConstantSDNode>(N-><wbr>getOperand(0))->getZExtValue()<wbr>;<br>
> +  unsigned IID = cast<ConstantSDNode>(N-><wbr>getOperand(1))->getZExtValue()<wbr>;<br>
>    unsigned OpcodeIndex =<br>
>        (IID == Intrinsic::nvvm_match_all_<wbr>sync_i64p) ? IS_I64 : 0;<br>
> -  SDValue MaskOp = N->getOperand(1);<br>
> -  SDValue ValueOp = N->getOperand(2);<br>
> +  SDValue MaskOp = N->getOperand(2);<br>
> +  SDValue ValueOp = N->getOperand(3);<br>
>    if (ConstantSDNode *ValueConst = dyn_cast<ConstantSDNode>(<wbr>ValueOp)) {<br>
>      OpcodeIndex |= HAS_CONST_VALUE;<br>
>      ValueOp = CurDAG->getTargetConstant(<wbr>ValueConst->getZExtValue(), DL,<br>
> @@ -1097,9 +1098,9 @@ void NVPTXDAGToDAGISel::<wbr>SelectMatchAll(S<br>
>        NVPTX::MATCH_ALLP_SYNC_32ir, NVPTX::MATCH_ALLP_SYNC_32ii,<br>
>        NVPTX::MATCH_ALLP_SYNC_64rr, NVPTX::MATCH_ALLP_SYNC_64ri,<br>
>        NVPTX::MATCH_ALLP_SYNC_64ir, NVPTX::MATCH_ALLP_SYNC_64ii};<br>
> -  SDNode *NewNode = CurDAG->getMachineNode(<wbr>Opcodes[OpcodeIndex], DL,<br>
> -                                           {ValueOp->getValueType(0), MVT::i1},<br>
> -                                           {MaskOp, ValueOp});<br>
> +  SDNode *NewNode = CurDAG->getMachineNode(<br>
> +      Opcodes[OpcodeIndex], DL, {ValueOp->getValueType(0), MVT::i1, MVT::Other},<br>
> +      {MaskOp, ValueOp});<br>
>    ReplaceNode(N, NewNode);<br>
>  }<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">--Artem Belevich</div></div>
</div>