Lgtm, thanks for working on this!<br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 9, 2017 at 1:59 PM Ying Yi via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">MaggieYi updated this revision to Diff 122330.<br>
MaggieYi added a comment.<br>
<br>
Updated the builtin diff shell to support ‘-u’, ‘-b’ and ‘-w’ options. Now, all llvm, and clang tests passed with both Python 2 and Python 3.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D39567" rel="noreferrer" target="_blank">https://reviews.llvm.org/D39567</a><br>
<br>
Files:<br>
  lit/lit/TestRunner.py<br>
  lit/tests/Inputs/shtest-shell/check_path.py<br>
  lit/tests/Inputs/shtest-shell/diff-error-0.txt<br>
  lit/tests/Inputs/shtest-shell/diff-error-1.txt<br>
  lit/tests/Inputs/shtest-shell/diff-error-2.txt<br>
  lit/tests/Inputs/shtest-shell/diff-error-3.txt<br>
  lit/tests/Inputs/shtest-shell/diff-error-4.txt<br>
  lit/tests/Inputs/shtest-shell/diff-error-5.txt<br>
  lit/tests/Inputs/shtest-shell/diff-error-6.txt<br>
  lit/tests/Inputs/shtest-shell/mkdir-error-0.txt<br>
  lit/tests/Inputs/shtest-shell/mkdir-error-1.txt<br>
  lit/tests/Inputs/shtest-shell/mkdir-error-2.txt<br>
  lit/tests/Inputs/shtest-shell/rm-error-0.txt<br>
  lit/tests/Inputs/shtest-shell/rm-error-1.txt<br>
  lit/tests/Inputs/shtest-shell/rm-error-2.txt<br>
  lit/tests/Inputs/shtest-shell/rm-error-3.txt<br>
  lit/tests/Inputs/shtest-shell/valid-shell.txt<br>
  lit/tests/max-failures.py<br>
  lit/tests/shtest-shell.py<br>
<br>
</blockquote></div>