<div dir="ltr">

<p class="MsoNormal">Thanks for your code review. I optimised the patch by using
python ‘getopt’ function and will update the phabricator soon. </p>

</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Nov 10, 2017 at 3:42 AM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Lgtm, thanks for working on this!<div class="HOEnZb"><div class="h5"><br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 9, 2017 at 1:59 PM Ying Yi via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">MaggieYi updated this revision to Diff 122330.<br>
MaggieYi added a comment.<br>
<br>
Updated the builtin diff shell to support ‘-u’, ‘-b’ and ‘-w’ options. Now, all llvm, and clang tests passed with both Python 2 and Python 3.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D39567" rel="noreferrer" target="_blank">https://reviews.llvm.org/<wbr>D39567</a><br>
<br>
Files:<br>
  lit/lit/TestRunner.py<br>
  lit/tests/Inputs/shtest-shell/<wbr>check_path.py<br>
  lit/tests/Inputs/shtest-shell/<wbr>diff-error-0.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>diff-error-1.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>diff-error-2.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>diff-error-3.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>diff-error-4.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>diff-error-5.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>diff-error-6.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>mkdir-error-0.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>mkdir-error-1.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>mkdir-error-2.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>rm-error-0.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>rm-error-1.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>rm-error-2.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>rm-error-3.txt<br>
  lit/tests/Inputs/shtest-shell/<wbr>valid-shell.txt<br>
  lit/tests/max-failures.py<br>
  lit/tests/shtest-shell.py<br>
<br>
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><font size="2"><span style="font-family:arial,helvetica,sans-serif"></span></font><font face="Calibri" size="2"><span style="font-size:11pt"><font size="2"><span style="font-size:10pt"><font color="#1F497D" face="Arial">Ying Yi<br>SN Systems - Sony Interactive Entertainment</font></span></font></span></font><br></div></div></div></div></div></div></div></div>
</div>