<div dir="ltr">If we can do it in the .gitattributes file so that people will automatically have this set, that would actually be great.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 9, 2017 at 1:59 PM Zhen Cao <<a href="mailto:zhen.cao@autodesk.com">zhen.cao@autodesk.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_8810444382045651088WordSection1">
<p class="MsoNormal">Thanks. But do you think it is better to require the user to run “git config --local core.autocrlf false” rather than to use .gitattributes to automatically set the repository?<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_8810444382045651088WordSection1"><p class="MsoNormal"><b>From:</b> Zachary Turner [mailto:<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>] <br>
</p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_8810444382045651088WordSection1"><p class="MsoNormal"><b>Sent:</b> Thursday, November 9, 2017 4:52 PM</p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_8810444382045651088WordSection1"><p class="MsoNormal"><br>
<b>To:</b> Zhen Cao <<a href="mailto:zhen.cao@autodesk.com" target="_blank">zhen.cao@autodesk.com</a>><br>
<b>Cc:</b> <a href="mailto:reviews%2BD39737%2Bpublic%2Ba17c03644213de66@reviews.llvm.org" target="_blank">reviews+D39737+public+a17c03644213de66@reviews.llvm.org</a>; Eli Friedman via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>>; <a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>; <a href="mailto:grosbach@apple.com" target="_blank">grosbach@apple.com</a>; <a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>; <a href="mailto:javed.absar@arm.com" target="_blank">javed.absar@arm.com</a>; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<b>Subject:</b> Re: [PATCH] D39737: [MC] Fix regression tests on Windows when git “core.autocrlf” is set to true<u></u><u></u></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div class="m_8810444382045651088WordSection1">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">You can set it locally for a specific repo.<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">git config --local core.autocrlf false<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">This won't affect other repositories.<u></u><u></u></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, Nov 9, 2017 at 1:51 PM Zhen Cao <<a href="mailto:zhen.cao@autodesk.com" target="_blank">zhen.cao@autodesk.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal">Some people use git for other projects as well. They may not want to set “core.autocrlf=false” for all the repos. On the other hand, if some version control system settings have
to be required to pass all the regression tests, I think it is better to have documentation on it.<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><b>From:</b> Zachary Turner [mailto:<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>]
<u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><b>Sent:</b> Thursday, November 9, 2017 4:31 PM<br>
<b>To:</b> Zhen Cao <<a href="mailto:zhen.cao@autodesk.com" target="_blank">zhen.cao@autodesk.com</a>><br>
<b>Cc:</b> <a href="mailto:reviews%2BD39737%2Bpublic%2Ba17c03644213de66@reviews.llvm.org" target="_blank">
reviews+D39737+public+a17c03644213de66@reviews.llvm.org</a>; Eli Friedman via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>>;
<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>; <a href="mailto:grosbach@apple.com" target="_blank">
grosbach@apple.com</a>; <a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>;
<a href="mailto:javed.absar@arm.com" target="_blank">javed.absar@arm.com</a>; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">
llvm-commits@lists.llvm.org</a><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><br>
<b>Subject:</b> Re: [PATCH] D39737: [MC] Fix regression tests on Windows when git “core.autocrlf” is set to true<u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">I guess, going back to my original question, can we just require core.autocrlf=false and call it a day?<br>
<br>
I’m not sure why you’re having trouble checking out with svn, but what I’ve always done is use a monorepo and then you’ll have an svn checkout locally, and you can use Tortoise Svn to modify the props in a gui<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Thu, Nov 9, 2017 at 1:25 PM Zhen Cao <<a href="mailto:zhen.cao@autodesk.com" target="_blank">zhen.cao@autodesk.com</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal">What about I add the following to the “Getting Started” section of the page (<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_GettingStartedVS.html&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=UW85ZemgrJlItSvSy9cLehlsQ2aLniu3SryzULBLG5U&s=kgkrRbqp-j4XQ1u19DS9ak2mlKFctKTu4d1ySfRv3HU&e=" target="_blank">http://llvm.org/docs/GettingStartedVS.html</a>)?<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">Note: some regression tests require Linux style line ending (\n). To pass all regression tests, please add the following two lines to “C:\Users\<username>\AppData\Roaming\Subversion\config”:<u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal" style="text-autospace:none">
<span style="font-family:"Courier New"">enable-auto-props = yes</span><u></u><u></u></p>
<p class="MsoNormal" style="text-autospace:none">
<span style="font-family:"Courier New"">* = svn:mime-type=application/octet-stream</span><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><b>From:</b> Zachary Turner [mailto:<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>]
<br>
<b>Sent:</b> Wednesday, November 8, 2017 7:39 PM<br>
<b>To:</b> <a href="mailto:reviews%2BD39737%2Bpublic%2Ba17c03644213de66@reviews.llvm.org" target="_blank">
reviews+D39737+public+a17c03644213de66@reviews.llvm.org</a>; Eli Friedman via Phabricator <<a href="mailto:reviews@reviews.llvm.org" target="_blank">reviews@reviews.llvm.org</a>><br>
<b>Cc:</b> Zhen Cao <<a href="mailto:zhen.cao@autodesk.com" target="_blank">zhen.cao@autodesk.com</a>>;
<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>; <a href="mailto:grosbach@apple.com" target="_blank">
grosbach@apple.com</a>; <a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>;
<a href="mailto:javed.absar@arm.com" target="_blank">javed.absar@arm.com</a>; <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">
llvm-commits@lists.llvm.org</a><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><b>Subject:</b> Re: [PATCH] D39737: [MC] Fix regression tests on Windows when git “core.autocrlf” is set to true<u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<p class="MsoNormal">By “your git or svn client”, you mean everyone right (ie what I said earlier)? Because it’s not sufficient for Zhen just to fix this locally before pushing a patch<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal">On Wed, Nov 8, 2017 at 4:09 PM Eli Friedman via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal">efriedma added a comment.<br>
<br>
With svn, this is controlled by svn:eol-style and svn:mime-type.<br>
<br>
That said, we don't have to worry about any of this if you just configure your git or svn client not to mess with line endings.<br>
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D39737&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=QiVMrF__xcFR41pB7Dx8zjHdggqK6rIFVvSD2-LR9I0&s=vHN0zUMQzdfO93b_VDKUuj20gOQSoAJjnZrQmzgP7kw&e=" target="_blank">https://reviews.llvm.org/D39737</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=QiVMrF__xcFR41pB7Dx8zjHdggqK6rIFVvSD2-LR9I0&s=dcj06dTL4nPn9WulSgRnOkVnF4IlLkhZLJPAlwnm49k&e=" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</blockquote>
</div>
</div></div></blockquote></div>