<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 9, 2017 at 10:46 PM, Teresa Johnson <span dir="ltr"><<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 9, 2017 at 10:56 AM, Roman Lebedev <span dir="ltr"><<a href="mailto:lebedev.ri@gmail.com" target="_blank">lebedev.ri@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="m_2647202090912696097gmail-">On Thu, Nov 9, 2017 at 9:54 PM, Teresa Johnson via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 9, 2017 at 10:14 AM, Evgenii Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">It's failing on my desktop right now, because BFD is the default linker and there is nothing on the test run line to use gold or lld. I believe this is a common configuration.</div></blockquote><div><br></div><div>It sounds like the best path forward is to revert this new test, then add it again after</div></div></div></div></blockquote></span></div></div></div></blockquote><div><br></div><div>Reverted it for now.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="m_2647202090912696097gmail-"><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>adding support to test/asan/lit.cfg to use lto_flags.</div></div></div></div></blockquote></span><div>I *think* this is roughly the direction in which <a href="https://reviews.llvm.org/D39508" target="_blank">https://reviews.llvm.org<wbr>/D39508</a> is moving.</div></div></div></div></blockquote><div><br></div><div>I tried the same approach used currently in test/profile/lit.cfg (see below), with a corresponding change to use the new %clangxx_lto_asan command in the test. The downside is that I still have to specify -flto=thin on the command line in the test since that option is only enabled when config.use_thinlto is enabled. Is there a way to enable that just for a single command?</div></div></div></div></blockquote><div>Uhm, good point. As far as i can tell - no, at least right now. </div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div> diff --git a/test/asan/lit.cfg b/test/asan/lit.cfg</div><div>index 6a4044a44..6f46029bb 100644</div><div>--- a/test/asan/lit.cfg</div><div>+++ b/test/asan/lit.cfg</div><div>@@ -95,13 +95,20 @@ if platform.system() == 'Windows':</div><div> win_runtime_feature = "win32-static-asan"</div><div> config.available_features.<wbr>add(win_runtime_feature)</div><div> </div><div>-def build_invocation(compile_<wbr>flags):</div><div>- return " " + " ".join([config.compile_<wbr>wrapper, config.clang] + compile_flags) + " "</div><div>+def build_invocation(compile_<wbr>flags, with_lto = False):</div><div>+ lto_flags = []</div><div>+ lto_prefix = []</div><div>+ if with_lto and config.lto_supported:</div><div>+ lto_flags += config.lto_flags</div><div>+ lto_prefix += config.lto_launch</div><div>+ return " " + " ".join(lto_prefix + [config.compile_wrapper, config.clang] + lto_flags + compile_flags) + " "</div><div> </div><div><div> config.substitutions.append( ("%clang ", build_invocation(target_<wbr>cflags)) )</div><div> config.substitutions.append( ("%clangxx ", build_invocation(target_<wbr>cxxflags)) )</div><div> config.substitutions.append( ("%clang_asan ", build_invocation(clang_asan_<wbr>cflags)) )</div><div> config.substitutions.append( ("%clangxx_asan ", build_invocation(clang_asan_<wbr>cxxflags)) )</div><div>+config.substitutions.append( ("%clang_lto_asan ", build_invocation(clang_asan_<wbr>cflags, True)) )</div><div>+config.substitutions.append( ("%clangxx_lto_asan ", build_invocation(clang_asan_<wbr>cxxflags, True)) )</div><div> config.substitutions.append( ("%shared_libasan", "libclang_rt.asan-%s.so" % config.target_arch))</div><div> if config.asan_dynamic:</div><div> config.substitutions.append( ("%clang_asan_static ", build_invocation(clang_asan_<wbr>static_cflags)) )</div></div><div><br></div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="m_2647202090912696097gmail-h5"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>I can then move it back to the OS-independent directory.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div><br></div></div><div class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421HOEnZb"><div class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421h5"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Nov 8, 2017 at 6:16 PM, Teresa Johnson <span dir="ltr"><<a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span>On Wed, Nov 8, 2017 at 2:49 PM, Evgenii Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">See config.lto_flags and tests/cfi/lit.cfg<br>
<div class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421m_8596082587804384570m_8686767159811979865m_-2155953439885813153HOEnZb"><div class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421m_8596082587804384570m_8686767159811979865m_-2155953439885813153h5"><br>
On Wed, Nov 8, 2017 at 2:47 PM, Evgenii Stepanov<br>
<<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>> wrote:<br>
> This also needs -fuse-ld=gold, at least.<br></div></div></blockquote><div><br></div></span><div>All the bots that were failing are now succeeding after adding the REQUIRES. It would work with lld as well.</div><div><div class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421m_8596082587804384570h5"><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421m_8596082587804384570m_8686767159811979865m_-2155953439885813153HOEnZb"><div class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421m_8596082587804384570m_8686767159811979865m_-2155953439885813153h5">
><br>
> On Wed, Nov 8, 2017 at 1:48 PM, Teresa Johnson via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>> Author: tejohnson<br>
>> Date: Wed Nov 8 13:48:27 2017<br>
>> New Revision: 317728<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=317728&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=317728&view=rev</a><br>
>> Log:<br>
>> [ThinLTO] New test needs to require LTO<br>
>><br>
>> Fix buildbot failures:<br>
>> <a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/5262/steps/annotate/logs/stdio" rel="noreferrer" target="_blank">http://lab.llvm.org:8011/build<wbr>ers/sanitizer-x86_64-linux/bui<wbr>lds/5262/steps/annotate/logs/s<wbr>tdio</a><br>
>><br>
>> Modified:<br>
>> compiler-rt/trunk/test/asan/T<wbr>estCases/Linux/contiguous_cont<wbr>ainer_crash_thinlto.cc<br>
>><br>
>> Modified: compiler-rt/trunk/test/asan/Te<wbr>stCases/Linux/contiguous_conta<wbr>iner_crash_thinlto.cc<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Linux/contiguous_container_crash_thinlto.cc?rev=317728&r1=317727&r2=317728&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/test/a<wbr>san/TestCases/Linux/contiguous<wbr>_container_crash_thinlto.cc?re<wbr>v=317728&r1=317727&r2=317728&v<wbr>iew=diff</a><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/test/asan/Te<wbr>stCases/Linux/contiguous_conta<wbr>iner_crash_thinlto.cc (original)<br>
>> +++ compiler-rt/trunk/test/asan/Te<wbr>stCases/Linux/contiguous_conta<wbr>iner_crash_thinlto.cc Wed Nov 8 13:48:27 2017<br>
>> @@ -6,6 +6,8 @@<br>
>> //<br>
>> // Test crash due to __sanitizer_annotate_contiguou<wbr>s_container.<br>
>><br>
>> +// REQUIRES: lto<br>
>> +<br>
>> #include <assert.h><br>
>> #include <string.h><br>
>><br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div></div></div><span class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421m_8596082587804384570HOEnZb"><font color="#888888"><br><br clear="all"><span class="m_2647202090912696097gmail-m_-3273979794719773471gmail-HOEnZb"><font color="#888888"><div><br></div>-- <br><div class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421m_8596082587804384570m_8686767159811979865m_-2155953439885813153gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top:2px solid rgb(213,15,37)">Teresa Johnson |</td><td nowrap style="border-top:2px solid rgb(51,105,232)"> Software Engineer |</td><td nowrap style="border-top:2px solid rgb(0,153,57)"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top:2px solid rgb(238,178,17)"> <a href="tel:(408)%20460-2413" value="+14084602413" target="_blank">408-460-2413</a></td></tr></tbody></table></span></div>
</font></span></font></span></div></div><span class="m_2647202090912696097gmail-m_-3273979794719773471gmail-HOEnZb"><font color="#888888">
</font></span></blockquote></div><span class="m_2647202090912696097gmail-m_-3273979794719773471gmail-HOEnZb"><font color="#888888"><br></font></span></div><span class="m_2647202090912696097gmail-m_-3273979794719773471gmail-HOEnZb"><font color="#888888">
</font></span></div></div></blockquote></div><span class="m_2647202090912696097gmail-m_-3273979794719773471gmail-HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_2647202090912696097gmail-m_-3273979794719773471gmail-m_-8436821794483930504m_-3016809793800181421gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top:2px solid rgb(213,15,37)">Teresa Johnson |</td><td nowrap style="border-top:2px solid rgb(51,105,232)"> Software Engineer |</td><td nowrap style="border-top:2px solid rgb(0,153,57)"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top:2px solid rgb(238,178,17)"> <a href="tel:(408)%20460-2413" value="+14084602413" target="_blank">408-460-2413</a></td></tr></tbody></table></span></div></font></span></div></div></blockquote></div></div><span class="m_2647202090912696097gmail-HOEnZb"><font color="#888888"><div>Roman. </div></font></span><span class="m_2647202090912696097gmail-"><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
<br></blockquote></span></div><br></div></div><span class="HOEnZb"><font color="#888888">
</font></span></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div class="m_2647202090912696097gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top:2px solid rgb(213,15,37)">Teresa Johnson |</td><td nowrap style="border-top:2px solid rgb(51,105,232)"> Software Engineer |</td><td nowrap style="border-top:2px solid rgb(0,153,57)"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top:2px solid rgb(238,178,17)"> 408-460-2413</td></tr></tbody></table></span></div>
</font></span></div></div>
</blockquote></div><br></div></div>