<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Thanks Zachary. I agree with your concern, but I think adding the file “.gitattributes” that sets the test files as binary has the same effect as requiring “core.autocrlf=false”.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>From:</b> Zachary Turner [mailto:zturner@google.com] <br>
<b>Sent:</b> Tuesday, November 7, 2017 5:58 PM<br>
<b>To:</b> reviews+D39737+public+a17c03644213de66@reviews.llvm.org; Reid Kleckner via Phabricator <reviews@reviews.llvm.org><br>
<b>Cc:</b> Zhen Cao <zhen.cao@autodesk.com>; grosbach@apple.com; bigcheesegs@gmail.com; javed.absar@arm.com; llvm-commits@lists.llvm.org<br>
<b>Subject:</b> Re: [PATCH] D39737: [MC] Fix regression tests on Windows when git “core.autocrlf” is set to true<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Honestly this is exactly the reason I think core.autocrlf=false should be required. A test whose correctness depends on a property of the source control system is broken. What if someone is using svn, not git? Now that needs a different
solution <o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Nov 7, 2017 at 2:43 PM Reid Kleckner via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">rnk added a comment.<br>
<br>
In <a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D39737-23918425&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=v1o3BA_P5gR207FWdrASaohpRGx5L9i-wllYLr0xnDA&s=1xaeIGYCdUSgYQ-ocHisoz8YM06hYvqy29UZbT5BPRE&e=" target="_blank">
https://reviews.llvm.org/D39737#918425</a>, @caoz wrote:<br>
<br>
> Thanks Reid. The fix doesn't have regressions on Linux, as it supports both styles of line ending ("\r\n" and "\n").<br>
<br>
<br>
I'm sure it's possible to add regression tests that run on Linux with .gitattributes.<br>
<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__reviews.llvm.org_D39737&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=v1o3BA_P5gR207FWdrASaohpRGx5L9i-wllYLr0xnDA&s=B5SqFfLWfiZdVpOc55xf7lLW1XoZ2URLYHrnaXluv7k&e=" target="_blank">https://reviews.llvm.org/D39737</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwMFaQ&c=76Q6Tcqc-t2x0ciWn7KFdCiqt6IQ7a_IF9uzNzd_2pA&r=5bO7zfHLitDTGEV53jsIoKY9YZM-dEXQXjvwmt4K1Xs&m=v1o3BA_P5gR207FWdrASaohpRGx5L9i-wllYLr0xnDA&s=pdySAm6H_e5CeoeVyYzZwTvz59D_qeWeLSpgMC9X7QQ&e=" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>