<div dir="ltr">Thanks. The original code should be considered as having a bug even if it didn't cause any issue.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Nov 6, 2017 at 6:00 PM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Mon Nov  6 18:00:51 2017<br>
New Revision: 317536<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=317536&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=317536&view=rev</a><br>
Log:<br>
Use Path instead of Config->OutputFile. NFC.<br>
<br>
This function is always called with Config->OutputFile. That is not<br>
obvious from reading the function. It should always use Path or take<br>
no argument and always use Config->OutputFile.<br>
<br>
Modified:<br>
    lld/trunk/ELF/Filesystem.cpp<br>
<br>
Modified: lld/trunk/ELF/Filesystem.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Filesystem.cpp?rev=317536&r1=317535&r2=317536&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/<wbr>Filesystem.cpp?rev=317536&r1=<wbr>317535&r2=317536&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/Filesystem.cpp (original)<br>
+++ lld/trunk/ELF/Filesystem.cpp Mon Nov  6 18:00:51 2017<br>
@@ -38,8 +38,8 @@ using namespace lld::elf;<br>
 // This function spawns a background thread to call unlink.<br>
 // The calling thread returns almost immediately.<br>
 void elf::unlinkAsync(StringRef Path) {<br>
-  if (!ThreadsEnabled || !sys::fs::exists(Config-><wbr>OutputFile) ||<br>
-      !sys::fs::is_regular_file(<wbr>Config->OutputFile))<br>
+  if (!ThreadsEnabled || !sys::fs::exists(Path) ||<br>
+      !sys::fs::is_regular_file(<wbr>Path))<br>
     return;<br>
<br>
   // First, rename Path to avoid race condition. We cannot remove<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>