<div dir="ltr">That's too large even for 64bit<div><a href="http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-ubsan/builds/225/steps/check-lld%20ubsan/logs/stdio" target="_blank" class="cremed">http://lab.llvm.org:<wbr>8011/builders/sanitizer-x86_<wbr>64-linux-bootstrap-ubsan/<wbr>builds/225/steps/check-lld%<wbr>20ubsan/logs/stdio</a><div><pre style="font-family:"Courier New",courier,monotype,monospace;color:rgb(0,0,0);font-size:medium"><span class="m_5020628530684023870gmail-stdout">/b/sanitizer-x86_64-linux-<wbr>bootstrap-ubsan/build/llvm/<wbr>tools/lld/ELF/InputFiles.cpp:<wbr>766:31: runtime error: shift exponent 64 is too large for 64-bit type 'unsigned long long'
    #0 0x5ae623 in lld::elf::SharedFile<llvm::<wbr>object::ELFType<(llvm::<wbr>support::endianness)1, true> >::parseRest() /b/sanitizer-x86_64-linux-<wbr>bootstrap-ubsan/build/llvm/<wbr>tools/lld/ELF/InputFiles.cpp:<wbr>766:31
    #1 0x6267ed in void lld::elf::SymbolTable::<wbr>addFile<llvm::object::ELFType<<wbr>(llvm::support::endianness)1, true> >(lld::elf::InputFile*) /b/sanitizer-x86_64-linux-<wbr>bootstrap-ubsan/build/llvm/<wbr>tools/lld/ELF/SymbolTable.cpp:<wbr>97:8
    #2 0x5649d1 in void lld::elf::LinkerDriver::link<<wbr>llvm::object::ELFType<(llvm::<wbr>support::endianness)1, true> >(llvm::opt::InputArgList&) /b/sanitizer-x86_64-linux-<wbr>bootstrap-ubsan/build/llvm/<wbr>tools/lld/ELF/Driver.cpp:1044:<wbr>13
    #3 0x55b5fa in lld::elf::LinkerDriver::main(<wbr>llvm::ArrayRef<char const*>, bool) /b/sanitizer-x86_64-linux-<wbr>bootstrap-ubsan/build/llvm/<wbr>tools/lld/ELF/Driver.cpp:407:5
    #4 0x55a1c3 in lld::elf::link(llvm::ArrayRef<<wbr>char const*>, bool, llvm::raw_ostream&) /b/sanitizer-x86_64-linux-<wbr>bootstrap-ubsan/build/llvm/<wbr>tools/lld/ELF/Driver.cpp:95:11
    #5 0x464944 in main /b/sanitizer-x86_64-linux-<wbr>bootstrap-ubsan/build/llvm/<wbr>tools/lld/tools/lld/lld.cpp:<wbr>116:13
    #6 0x7f7068c082b0 in __libc_start_main (/lib/x86_64-linux-gnu/libc.<wbr>so.6+0x202b0)
    #7 0x44cdb9 in _start (/b/sanitizer-x86_64-linux-<wbr>bootstrap-ubsan/build/llvm_<wbr>build_ubsan/bin/lld+0x44cdb9)
</span></pre></div><div><span class="m_5020628530684023870gmail-stdout"><br></span></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Oct 28, 2017 at 3:18 PM, Rui Ueyama via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="cremed">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Sat Oct 28 15:18:29 2017<br>
New Revision: 316849<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=316849&view=rev" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=316849&view=rev</a><br>
Log:<br>
Fix ubsan error.<br>
<br>
This patch fixes ubsan's "shift exponent 64 is too large for 32-bit type<br>
'int'" error.<br>
<br>
Modified:<br>
    lld/trunk/ELF/InputFiles.cpp<br>
<br>
Modified: lld/trunk/ELF/InputFiles.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=316849&r1=316848&r2=316849&view=diff" rel="noreferrer" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-pr<wbr>oject/lld/trunk/ELF/InputFiles<wbr>.cpp?rev=316849&r1=316848&r2=<wbr>316849&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/InputFiles.cpp (original)<br>
+++ lld/trunk/ELF/InputFiles.cpp Sat Oct 28 15:18:29 2017<br>
@@ -763,7 +763,7 @@ template <class ELFT> void SharedFile<EL<br>
     // files because the loader takes care of it. However, if we promote a<br>
     // DSO symbol to point to .bss due to copy relocation, we need to keep<br>
     // the original alignment requirements. We infer it here.<br>
-    uint32_t Alignment = 1 << countTrailingZeros((uint64_t)S<wbr>ym.st_value);<br>
+    uint32_t Alignment = 1ULL << countTrailingZeros((uint64_t)S<wbr>ym.st_value);<br>
     if (0 < Sym.st_shndx && Sym.st_shndx < Sections.size()) {<br>
       uint32_t SecAlign = Sections[Sym.st_shndx].sh_addr<wbr>align;<br>
       Alignment = std::min(Alignment, SecAlign);<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="cremed">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="cremed">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></div>