<div dir="ltr">I'm guessing a small/empty module might be sufficiently stable to hash?<br><br>Otherwise, not perfect, but lower false positive, would be a test with a regex for [0-9]* to ensure there are no hex digits?</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Oct 18, 2017 at 11:53 AM Teresa Johnson <<a href="mailto:tejohnson@google.com">tejohnson@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Oct 9, 2017 at 3:40 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Test case?<br></div></blockquote><div><br></div><div>Sorry for the slow response. I considered adding a test but didn't, for the same reason that we don't currently have any tests that check for the actual suffix value - it is a hash of the IR and therefore any future changes to IR would require the tests to be updated. It seems like this would be too noisy. WDYT?</div><div><br></div><div>Teresa</div></div></div></div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_quote"><div><div class="m_-7724966398470199279h5"><div dir="ltr">On Fri, Sep 29, 2017 at 8:08 AM Teresa Johnson via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="m_-7724966398470199279h5">tejohnson created this revision.<br>
Herald added a subscriber: inglorion.<br>
<br>
Demanglers such as libiberty know how to strip suffixes of the form<br>
\.[a-zA-Z]+\.\d+, but our current promoted value suffixes are<br>
.llvm.${modulehash}, where the module hash is in hex. Change the<br>
module hash to decimal to allow demanglers to handle this.<br>
<br>
<br>
<a href="https://reviews.llvm.org/D38405" rel="noreferrer" target="_blank">https://reviews.llvm.org/D38405</a><br>
<br>
Files:<br>
include/llvm/IR/ModuleSummaryIndex.h<br>
<br>
<br>
Index: include/llvm/IR/ModuleSummaryIndex.h<br>
===================================================================<br>
--- include/llvm/IR/ModuleSummaryIndex.h<br>
+++ include/llvm/IR/ModuleSummaryIndex.h<br>
@@ -743,7 +743,7 @@<br>
static std::string getGlobalNameForLocal(StringRef Name, ModuleHash ModHash) {<br>
SmallString<256> NewName(Name);<br>
NewName += ".llvm.";<br>
- NewName += utohexstr(ModHash[0]); // Take the first 32 bits<br>
+ NewName += utostr(ModHash[0]); // Take the first 32 bits<br>
return NewName.str();<br>
}<br>
<br>
<br>
<br></div></div>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>
</blockquote></div></div></div><div dir="ltr"><div class="gmail_extra"><br><br clear="all"><div><br></div>-- <br><div class="m_-7724966398470199279gmail_signature" data-smartmail="gmail_signature"><span style="font-family:Times;font-size:medium"><table cellspacing="0" cellpadding="0"><tbody><tr style="color:rgb(85,85,85);font-family:sans-serif;font-size:small"><td nowrap style="border-top-style:solid;border-top-color:rgb(213,15,37);border-top-width:2px">Teresa Johnson |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(51,105,232);border-top-width:2px"> Software Engineer |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(0,153,57);border-top-width:2px"> <a href="mailto:tejohnson@google.com" target="_blank">tejohnson@google.com</a> |</td><td nowrap style="border-top-style:solid;border-top-color:rgb(238,178,17);border-top-width:2px"> <a href="tel:(408)%20460-2413" value="+14084602413" target="_blank">408-460-2413</a></td></tr></tbody></table></span></div>
</div></div></blockquote></div>