<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:56.7pt 42.5pt 56.7pt 85.05pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I’m going to recommit the patch.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I didn’t manage to reproduce the timeout.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please let me know if you have any objections.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Olga<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> llvm-commits [mailto:llvm-commits-bounces@lists.llvm.org]
<b>On Behalf Of </b>Chupina, Olga via llvm-commits<br>
<b>Sent:</b> Wednesday, 27 September, 2017 2:25 PM<br>
<b>To:</b> Evgeny Astigeevich <Evgeny.Astigeevich@arm.com>; Chandler Carruth <chandlerc@gmail.com>; Bozhenov, Nikolai <nikolai.bozhenov@intel.com><br>
<b>Cc:</b> nd <nd@arm.com>; LLVM Commits <llvm-commits@lists.llvm.org><br>
<b>Subject:</b> RE: [llvm] r310583 - [ValueTracking] Enabling ValueTracking patch by default (recommit). Part 2.<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Evgeny,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">No, I could not reproduce the timeout. Yes, it is safe.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">And we also see no stability issues in our testing.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Currently I’m updating lit tests and plan to recommit on the next week.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Olga<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Evgeny Astigeevich [<a href="mailto:Evgeny.Astigeevich@arm.com">mailto:Evgeny.Astigeevich@arm.com</a>]
<br>
<b>Sent:</b> Tuesday, 26 September, 2017 10:37 PM<br>
<b>To:</b> Chandler Carruth <<a href="mailto:chandlerc@gmail.com">chandlerc@gmail.com</a>>; Bozhenov, Nikolai <<a href="mailto:nikolai.bozhenov@intel.com">nikolai.bozhenov@intel.com</a>>; Chupina, Olga <<a href="mailto:olga.chupina@intel.com">olga.chupina@intel.com</a>><br>
<b>Cc:</b> nd <<a href="mailto:nd@arm.com">nd@arm.com</a>>; LLVM Commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>><br>
<b>Subject:</b> RE: [llvm] r310583 - [ValueTracking] Enabling ValueTracking patch by default (recommit). Part 2.<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Did you manage to reproduce the timeout? Is it safe to enable it?<o:p></o:p></p>
<p class="MsoNormal">The optimization works for Arm architectures as well. We see ~16% performance improvement in our benchmarks on Cortex-M7. In fact we found this when we got regressions because of the disabled optimization.<o:p></o:p></p>
<p class="MsoNormal">We did not have any stability issues when the optimization was enabled.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Evgeny<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">From: Chupina, Olga<o:p></o:p></p>
<p class="MsoNormal">Sent: Thursday, 31 August, 2017 11:25 AM<o:p></o:p></p>
<p class="MsoNormal">To: 'Chandler Carruth' <chandlerc at gmail.com><o:p></o:p></p>
<p class="MsoNormal">Cc: 'llvm-commits at lists.llvm.org' <llvm-commits at lists.llvm.org>; Bozhenov, Nikolai <nikolai.bozhenov at intel.com><o:p></o:p></p>
<p class="MsoNormal">Subject: RE: [llvm] r310583 - [ValueTracking] Enabling ValueTracking patch by default (recommit). Part 2.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Chandler,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Could you please provide more information on the fail you’ve observed?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Olga<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">From: Chupina, Olga<o:p></o:p></p>
<p class="MsoNormal">Sent: Wednesday, 23 August, 2017 3:28 PM<o:p></o:p></p>
<p class="MsoNormal">To: Bozhenov, Nikolai <nikolai.bozhenov at intel.com<<a href="mailto:nikolai.bozhenov%20at%20intel.com">mailto:nikolai.bozhenov at intel.com</a>>>; Chandler Carruth <chandlerc at gmail.com<<a href="mailto:chandlerc%20at%20gmail.com">mailto:chandlerc
at gmail.com</a>>><o:p></o:p></p>
<p class="MsoNormal">Cc: llvm-commits at lists.llvm.org<<a href="mailto:llvm-commits%20at%20lists.llvm.org">mailto:llvm-commits at lists.llvm.org</a>><o:p></o:p></p>
<p class="MsoNormal">Subject: RE: [llvm] r310583 - [ValueTracking] Enabling ValueTracking patch by default (recommit). Part 2.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Chandler,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’m investigating the issue with core.c file and could not reproduce the problem you’ve mentioned.<o:p></o:p></p>
<p class="MsoNormal">I’ve checked out sources for stable-1.0 branch and build it with:<o:p></o:p></p>
<p class="MsoNormal">$ ./configure --cc=<path-to-my-clang><o:p></o:p></p>
<p class="MsoNormal">$ make<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Here are my compile line and clang version:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">$ clang -I/tmpdir/qemu/slirp -I. -I/tmpdir/qemu -I/tmpdir/qemu/fpu -fPIE -DPIE -m64 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes
-fno-strict-aliasing -fstack-protector-all -Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -I/usr/include/libpng15 -I/tmpdir/qemu/libcacard
-I/usr/include/nss3 -I/usr/include/nspr4 -DTARGET_PHYS_ADDR_BITS=64 -I.. -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -MMD -MP -MT ide/core.o -MF ide/core.d -O2 -g -c -o
ide/core.o /tmpdir/qemu/hw/ide/core.c<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">$ clang -v<o:p></o:p></p>
<p class="MsoNormal">clang version 6.0.0 (trunk 310583)<o:p></o:p></p>
<p class="MsoNormal">Target: x86_64-unknown-linux-gnu<o:p></o:p></p>
<p class="MsoNormal">Thread model: posix<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I also checked qemu trunk version, it also has no problems. Compilation time is the same for r310582 and r310583.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Could you please provide additional information on how to reproduce the timeout issue?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Olga<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>