<div dir="ltr">Nice!</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Oct 16, 2017 at 10:25 PM Daniel Sanders <<a href="mailto:daniel_l_sanders@apple.com">daniel_l_sanders@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">I managed to find one amongst the rules currently imported for X86. Added in r315972</div><div style="word-wrap:break-word;line-break:after-white-space"><br><div><br><blockquote type="cite"><div>On 16 Oct 2017, at 13:47, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br class="m_1246912287420976382Apple-interchange-newline"><div><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 13, 2017 at 6:51 PM Daniel Sanders via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dsanders<br>
Date: Fri Oct 13 18:51:46 2017<br>
New Revision: 315788<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=315788&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=315788&view=rev</a><br>
Log:<br>
[globalisel][tablegen] Fix an unused variable warning caused by a typo (corrected OtherInsnID->OtherOpIdx).<br>
<br>
The tests were passing by luck since the instruction ID and operand index happened to be the same.<br></blockquote><div><br>Worth adding a test where that's not the case?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h<br>
<br>
Modified: llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h?rev=315788&r1=315787&r2=315788&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h?rev=315788&r1=315787&r2=315788&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h (original)<br>
+++ llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h Fri Oct 13 18:51:46 2017<br>
@@ -345,7 +345,7 @@ bool InstructionSelector::executeMatchTa<br>
       assert(State.MIs[InsnID] != nullptr && "Used insn before defined");<br>
       assert(State.MIs[OtherInsnID] != nullptr && "Used insn before defined");<br>
       if (!State.MIs[InsnID]->getOperand(OpIdx).isIdenticalTo(<br>
-              State.MIs[OtherInsnID]->getOperand(OtherInsnID))) {<br>
+              State.MIs[OtherInsnID]->getOperand(OtherOpIdx))) {<br>
         if (handleReject() == RejectAndGiveUp)<br>
           return false;<br>
       }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>
</div></blockquote></div><br></div></blockquote></div>