<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">I managed to find one amongst the rules currently imported for X86. Added in r315972<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 16 Oct 2017, at 13:47, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><br class=""><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Oct 13, 2017 at 6:51 PM Daniel Sanders via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dsanders<br class="">
Date: Fri Oct 13 18:51:46 2017<br class="">
New Revision: 315788<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=315788&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=315788&view=rev</a><br class="">
Log:<br class="">
[globalisel][tablegen] Fix an unused variable warning caused by a typo (corrected OtherInsnID->OtherOpIdx).<br class="">
<br class="">
The tests were passing by luck since the instruction ID and operand index happened to be the same.<br class=""></blockquote><div class=""><br class="">Worth adding a test where that's not the case?<br class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h<br class="">
<br class="">
Modified: llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h?rev=315788&r1=315787&r2=315788&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h?rev=315788&r1=315787&r2=315788&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h (original)<br class="">
+++ llvm/trunk/include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h Fri Oct 13 18:51:46 2017<br class="">
@@ -345,7 +345,7 @@ bool InstructionSelector::executeMatchTa<br class="">
assert(State.MIs[InsnID] != nullptr && "Used insn before defined");<br class="">
assert(State.MIs[OtherInsnID] != nullptr && "Used insn before defined");<br class="">
if (!State.MIs[InsnID]->getOperand(OpIdx).isIdenticalTo(<br class="">
- State.MIs[OtherInsnID]->getOperand(OtherInsnID))) {<br class="">
+ State.MIs[OtherInsnID]->getOperand(OtherOpIdx))) {<br class="">
if (handleReject() == RejectAndGiveUp)<br class="">
return false;<br class="">
}<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div></div>
</div></blockquote></div><br class=""></body></html>