<div dir="ltr">By the way, I think isInCurrentDSO isn't a precisely correct name, because it may not be a shared object file but an executable.<div><br></div><div>What is a generic name for both executables and DSOs? I thought that ELF module could be the one, but since "module" is a overloaded term, it might not be a good name. So, maybe "ELF binary"? Or, something else?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 13, 2017 at 11:32 AM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Fri Oct 13 11:32:16 2017<br>
New Revision: 315727<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=315727&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=315727&view=rev</a><br>
Log:<br>
Handle shared symbols in --gc-sections.<br>
<br>
We don't want to gc a section if it is used via __start_*, but we were<br>
doing that if the same symbol was visible in a shared library.<br>
<br>
Modified:<br>
    lld/trunk/ELF/MarkLive.cpp<br>
    lld/trunk/test/ELF/startstop-<wbr>gccollect.s<br>
<br>
Modified: lld/trunk/ELF/MarkLive.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/MarkLive.cpp?rev=315727&r1=315726&r2=315727&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/<wbr>MarkLive.cpp?rev=315727&r1=<wbr>315726&r2=315727&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/MarkLive.cpp (original)<br>
+++ lld/trunk/ELF/MarkLive.cpp Fri Oct 13 11:32:16 2017<br>
@@ -74,7 +74,7 @@ static void resolveReloc(InputSectionBas<br>
     return;<br>
   }<br>
<br>
-  if (B.isUndefined())<br>
+  if (!B.isInCurrentDSO())<br>
     for (InputSectionBase *Sec : CNamedSections.lookup(B.<wbr>getName()))<br>
       Fn(Sec, 0);<br>
 }<br>
<br>
Modified: lld/trunk/test/ELF/startstop-<wbr>gccollect.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/startstop-gccollect.s?rev=315727&r1=315726&r2=315727&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/test/ELF/<wbr>startstop-gccollect.s?rev=<wbr>315727&r1=315726&r2=315727&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/test/ELF/startstop-<wbr>gccollect.s (original)<br>
+++ lld/trunk/test/ELF/startstop-<wbr>gccollect.s Fri Oct 13 11:32:16 2017<br>
@@ -11,6 +11,12 @@<br>
 # RUN: ld.lld %t --gc-sections -o %tout<br>
 # RUN: llvm-objdump -d %tout | FileCheck -check-prefix=DISASM %s<br>
<br>
+# RUN: echo ".global __start_foo; __start_foo:" > %t2.s<br>
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %t2.s -o %t2.o<br>
+# RUN: ld.lld -shared %t2.o -o %t2.so<br>
+# RUN: ld.lld %t --gc-sections -o %tout %t2.so<br>
+# RUN: llvm-objdump -d %tout | FileCheck -check-prefix=DISASM %s<br>
+<br>
 # DISASM:      _start:<br>
 # DISASM-NEXT: 201000:        e8 05 00 00 00  callq   5 <__start_foo><br>
 # DISASM-NEXT: 201005:        e8 02 00 00 00  callq   2 <__stop_bar><br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>