<div dir="ltr">Sorry I never saw this David.<div><br></div><div>Generally, I wouldn't expect this to be expensive, so I suspect this is fine. That said, I'm happy if others prefer hiding the variable entirely.</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Aug 28, 2017 at 6:10 PM David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Is getting the alt opcode expensive enough that it's worth avoiding rolling this into the assert? (& is it worth wrapping it then in a #ifndef NDEBUG?)</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Aug 18, 2017 at 10:07 PM Chandler Carruth via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chandlerc<br>
Date: Fri Aug 18 22:06:23 2017<br>
New Revision: 311227<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=311227&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=311227&view=rev</a><br>
Log:<br>
[SLP] Fix an unused variable warning in non-asserts builds.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=311227&r1=311226&r2=311227&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp?rev=311227&r1=311226&r2=311227&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp Fri Aug 18 22:06:23 2017<br>
@@ -2349,6 +2349,7 @@ void BoUpSLP::reorderAltShuffleOperands(<br>
                                         SmallVectorImpl<Value *> &Right) {<br>
   // Push left and right operands of binary operation into Left and Right<br>
   unsigned AltOpcode = getAltOpcode(Opcode);<br>
+  (void)AltOpcode;<br>
   for (Value *V : VL) {<br>
     auto *I = cast<Instruction>(V);<br>
     assert(sameOpcodeOrAlt(Opcode, AltOpcode, I->getOpcode()) &&<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>