<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi Francis,<div class=""><br class=""></div><div class="">This commit has broken the ASan bot for almost a week now.</div><div class=""><br class=""></div><div class="">Could you fix or revert please?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">-Quentin<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 3, 2017, at 11:18 PM, Mike Edwards via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><span style="font-size:12.8px" class="">Hi,</span><div style="font-size:12.8px" class="">Our Stage 2 ASAN bot (<a href="http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/" target="_blank" class="">http://green.lab.llvm.org/<wbr class="">green/job/clang-stage2-cmake-<wbr class="">RgSan/</a>) is having trouble with this commit. </div><div style="font-size:12.8px" class=""><br class=""></div><div style="font-size:12.8px" class="">I believe this issue lies in this line:</div><div style="font-size:12.8px" class=""><span style="font-size:12.8px" class="">Modified: llvm/trunk/utils/lit/lit/llvm/</span><span style="font-size:12.8px" class=""><wbr class="">config.py</span><br class=""></div><span class="gmail-im" style="font-size:12.8px"><div class=""><span style="font-size:12.8px" class="">+ self.with_environment('ASAN_</span><span style="font-size:12.8px" class="">OP<wbr class="">TIONS', 'detect_leaks=1', </span><span style="font-size:12.8px" class="">append_path=<wbr class="">True</span><span style="font-size:12.8px" class="">)</span><span style="font-size:12.8px" class=""><br class=""></span></div><div class=""><span style="font-size:12.8px" class=""><br class=""></span></div></span><div style="font-size:12.8px" class=""><span style="font-size:12.8px" class="">I am pretty sure the </span><span style="font-size:12.8px" class="">append_path=True is causing the output of the function to append the following to the config.environment dict:</span></div><div style="font-size:12.8px" class=""><span style="font-size:12.8px" class="">'ASAN_OPTIONS': 'detect_leaks=1:.'</span></div><div style="font-size:12.8px" class=""><span style="font-size:12.8px" class=""><br class=""></span></div><div style="font-size:12.8px" class=""><span style="font-size:12.8px" class="">This output causes an error to be thrown when config.py is run because the extra ':.' appended to the 'detect_leaks=1' value causes an error when parsing the key. Would it be possible to remove the argument '</span><span style="font-size:12.8px" class="">append_path=True' from the function call? I tried commenting the argument out and re-running the lit command and everything worked again as expected. Any help you can provide here would be greatly appreciated.</span></div><div style="font-size:12.8px" class=""><span style="font-size:12.8px" class=""><br class=""></span></div><div style="font-size:12.8px" class=""><span style="font-size:12.8px" class="">Respectfully,</span></div><div style="font-size:12.8px" class=""><span style="font-size:12.8px" class="">Mike Edwards</span></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Fri, Sep 29, 2017 at 9:51 AM, Francis Ricci via llvm-commits <span dir="ltr" class=""><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="">llvm-commits@lists.llvm.org</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: fjricci<br class="">
Date: Fri Sep 29 09:51:50 2017<br class="">
New Revision: 314535<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314535&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=314535&view=rev</a><br class="">
Log:<br class="">
[test] Enable LeakSanitizer on 64-bit Darwin ASan llvm builds<br class="">
<br class="">
Summary:<br class="">
Also disables leak checking on lto tests, due to many leaks reported<br class="">
in the system's ld64.<br class="">
<br class="">
Reviewers: kcc, pcc, bogner, kubamracek<br class="">
<br class="">
Subscribers: mehdi_amini, llvm-commits<br class="">
<br class="">
Differential Revision: <a href="https://reviews.llvm.org/D37781" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/<wbr class="">D37781</a><br class="">
<br class="">
Modified:<br class="">
llvm/trunk/test/tools/lto/lit.<wbr class="">local.cfg<br class="">
llvm/trunk/utils/lit/lit/llvm/<wbr class="">config.py<br class="">
<br class="">
Modified: llvm/trunk/test/tools/lto/lit.<wbr class="">local.cfg<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/lto/lit.local.cfg?rev=314535&r1=314534&r2=314535&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/test/tools/<wbr class="">lto/lit.local.cfg?rev=314535&<wbr class="">r1=314534&r2=314535&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/test/tools/lto/lit.<wbr class="">local.cfg (original)<br class="">
+++ llvm/trunk/test/tools/lto/lit.<wbr class="">local.cfg Fri Sep 29 09:51:50 2017<br class="">
@@ -1,2 +1,6 @@<br class="">
if not ('ld64_plugin' in config.available_features and 'X86' in config.root.targets):<br class="">
- config.unsupported = True<br class="">
+ config.unsupported = True<br class="">
+<br class="">
+# These tests invoke ld64 from the system, which is not leak-free<br class="">
+if "Address" in config.llvm_use_sanitizer:<br class="">
+ config.environment['ASAN_<wbr class="">OPTIONS'] = 'detect_leaks=0'<br class="">
<br class="">
Modified: llvm/trunk/utils/lit/lit/llvm/<wbr class="">config.py<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/llvm/config.py?rev=314535&r1=314534&r2=314535&view=diff" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/llvm/trunk/utils/lit/<wbr class="">lit/llvm/config.py?rev=314535&<wbr class="">r1=314534&r2=314535&view=diff</a><br class="">
==============================<wbr class="">==============================<wbr class="">==================<br class="">
--- llvm/trunk/utils/lit/lit/llvm/<wbr class="">config.py (original)<br class="">
+++ llvm/trunk/utils/lit/lit/llvm/<wbr class="">config.py Fri Sep 29 09:51:50 2017<br class="">
@@ -75,6 +75,9 @@ class LLVMConfig(object):<br class="">
features.add("long_tests")<br class="">
<br class="">
if target_triple:<br class="">
+ if re.match(r'^x86_64.*-apple', target_triple):<br class="">
+ if 'address' in sanitizers:<br class="">
+ self.with_environment('ASAN_<wbr class="">OPTIONS', 'detect_leaks=1', append_path=True)<br class="">
if re.match(r'^x86_64.*-linux', target_triple):<br class="">
features.add("x86_64-linux")<br class="">
if re.match(r'.*-win32$', target_triple):<br class="">
<br class="">
<br class="">
______________________________<wbr class="">_________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div></div>
_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></body></html>