<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hmm, the report says<div class=""><span style="color: rgb(51, 51, 51); font-family: monospace; font-size: 13px; white-space: pre-wrap;" class=""> Unexpected Failures: 4762</span><br class=""><div><br class=""></div><div>It does not seem to be just this one test.</div><div>I talked with Anna and she said that detecting leaks is not supported on the Mac [with ASan].</div><div>Which matches what I see locally:</div><pre style="box-sizing: border-box; white-space: pre-wrap; word-wrap: break-word; margin-top: 0px; margin-bottom: 0px; color: rgb(51, 51, 51); font-size: 13px;" class="">==5185==AddressSanitizer: detect_leaks is not supported on this platform.</pre><div class=""><br class=""></div><div>I admit I didn’t follow this works and my config may be out of date, still there is more than one test failing on the bot :).</div><div> </div><div><blockquote type="cite" class=""><div class="">On Oct 9, 2017, at 11:31 AM, Francis Ricci <<a href="mailto:francisjricci@gmail.com" class="">francisjricci@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">I didn't realize it was still broken because I didn't get an email.<br class="">Looks like there's only one leaky test -<br class="">tools/llvm-objdump/macho-LLVM-bundle.test (which doesn't repro<br class="">locally). I'll commit a diff to disable leak checking on that test.<br class=""><br class="">On Mon, Oct 9, 2017 at 2:27 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com" class="">qcolombet@apple.com</a>> wrote:<br class=""><blockquote type="cite" class="">Hi Francis,<br class=""><br class="">This commit has broken the ASan bot for almost a week now.<br class=""><br class="">Could you fix or revert please?<br class=""><br class="">Thanks,<br class="">-Quentin<br class=""><br class=""><br class="">On Oct 3, 2017, at 11:18 PM, Mike Edwards via llvm-commits<br class=""><<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><br class="">Hi,<br class="">Our Stage 2 ASAN bot<br class="">(<a href="http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/" class="">http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan/</a>) is having<br class="">trouble with this commit.<br class=""><br class="">I believe this issue lies in this line:<br class="">Modified: llvm/trunk/utils/lit/lit/llvm/config.py<br class="">+ self.with_environment('ASAN_OPTIONS', 'detect_leaks=1',<br class="">append_path=True)<br class=""><br class="">I am pretty sure the append_path=True is causing the output of the function<br class="">to append the following to the config.environment dict:<br class="">'ASAN_OPTIONS': 'detect_leaks=1:.'<br class=""><br class="">This output causes an error to be thrown when config.py is run because the<br class="">extra ':.' appended to the 'detect_leaks=1' value causes an error when<br class="">parsing the key. Would it be possible to remove the argument<br class="">'append_path=True' from the function call? I tried commenting the argument<br class="">out and re-running the lit command and everything worked again as expected.<br class="">Any help you can provide here would be greatly appreciated.<br class=""><br class="">Respectfully,<br class="">Mike Edwards<br class=""><br class="">On Fri, Sep 29, 2017 at 9:51 AM, Francis Ricci via llvm-commits<br class=""><<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class=""><blockquote type="cite" class=""><br class="">Author: fjricci<br class="">Date: Fri Sep 29 09:51:50 2017<br class="">New Revision: 314535<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314535&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=314535&view=rev</a><br class="">Log:<br class="">[test] Enable LeakSanitizer on 64-bit Darwin ASan llvm builds<br class=""><br class="">Summary:<br class="">Also disables leak checking on lto tests, due to many leaks reported<br class="">in the system's ld64.<br class=""><br class="">Reviewers: kcc, pcc, bogner, kubamracek<br class=""><br class="">Subscribers: mehdi_amini, llvm-commits<br class=""><br class="">Differential Revision: <a href="https://reviews.llvm.org/D37781" class="">https://reviews.llvm.org/D37781</a><br class=""><br class="">Modified:<br class=""> llvm/trunk/test/tools/lto/lit.local.cfg<br class=""> llvm/trunk/utils/lit/lit/llvm/config.py<br class=""><br class="">Modified: llvm/trunk/test/tools/lto/lit.local.cfg<br class="">URL:<br class=""><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/lto/lit.local.cfg?rev=314535&r1=314534&r2=314535&view=diff" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/lto/lit.local.cfg?rev=314535&r1=314534&r2=314535&view=diff</a><br class=""><br class="">==============================================================================<br class="">--- llvm/trunk/test/tools/lto/lit.local.cfg (original)<br class="">+++ llvm/trunk/test/tools/lto/lit.local.cfg Fri Sep 29 09:51:50 2017<br class="">@@ -1,2 +1,6 @@<br class=""> if not ('ld64_plugin' in config.available_features and 'X86' in<br class="">config.root.targets):<br class="">- config.unsupported = True<br class="">+ config.unsupported = True<br class="">+<br class="">+# These tests invoke ld64 from the system, which is not leak-free<br class="">+if "Address" in config.llvm_use_sanitizer:<br class="">+ config.environment['ASAN_OPTIONS'] = 'detect_leaks=0'<br class=""><br class="">Modified: llvm/trunk/utils/lit/lit/llvm/config.py<br class="">URL:<br class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/llvm/config.py?rev=314535&r1=314534&r2=314535&view=diff<br class=""><br class="">==============================================================================<br class="">--- llvm/trunk/utils/lit/lit/llvm/config.py (original)<br class="">+++ llvm/trunk/utils/lit/lit/llvm/config.py Fri Sep 29 09:51:50 2017<br class="">@@ -75,6 +75,9 @@ class LLVMConfig(object):<br class=""> features.add("long_tests")<br class=""><br class=""> if target_triple:<br class="">+ if re.match(r'^x86_64.*-apple', target_triple):<br class="">+ if 'address' in sanitizers:<br class="">+ self.with_environment('ASAN_OPTIONS',<br class="">'detect_leaks=1', append_path=True)<br class=""> if re.match(r'^x86_64.*-linux', target_triple):<br class=""> features.add("x86_64-linux")<br class=""> if re.match(r'.*-win32$', target_triple):<br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class="">llvm-commits@lists.llvm.org<br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></blockquote><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""><br class=""><br class=""></blockquote></div></div></blockquote></div><br class=""></div></body></html>