<div dir="ltr">Is this error path tested? I'm guessing not because I think llvm::Error would fail on that error handling, since it doesn't actually handle the error (doesn't print the failure or otherwise deal with it). If that's really the intended behavior, you may need a "consumeError" call here - and a test in either case</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 5, 2017 at 12:37 PM Francis Ricci via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: fjricci<br>
Date: Thu Oct  5 12:35:55 2017<br>
New Revision: 315006<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=315006&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=315006&view=rev</a><br>
Log:<br>
[dsymutil] Fix unused variable warning<br>
<br>
Modified:<br>
    llvm/trunk/tools/dsymutil/DwarfLinker.cpp<br>
<br>
Modified: llvm/trunk/tools/dsymutil/DwarfLinker.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/DwarfLinker.cpp?rev=315006&r1=315005&r2=315006&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/dsymutil/DwarfLinker.cpp?rev=315006&r1=315005&r2=315006&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/dsymutil/DwarfLinker.cpp (original)<br>
+++ llvm/trunk/tools/dsymutil/DwarfLinker.cpp Thu Oct  5 12:35:55 2017<br>
@@ -3493,7 +3493,7 @@ bool DwarfLinker::link(const DebugMap &M<br>
     if (Obj->getType() == MachO::N_AST) {<br>
       auto ErrOrMemBufferRefs = BinHolder.GetMemoryBuffersForFile(<br>
           Obj->getObjectFilename(), Obj->getTimestamp());<br>
-      if (auto Err = ErrOrMemBufferRefs.getError())<br>
+      if (ErrOrMemBufferRefs.getError())<br>
         continue;<br>
       if (!Options.NoOutput)<br>
         Streamer->emitSwiftAST(ErrOrMemBufferRefs.get());<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>