<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hey Adrian,<div class=""><br class=""></div><div class="">Could you share where the "not_asan" lit feature is defined? I'm running into some problems with it.</div><div class=""><br class=""></div><div class="">Specifically the code coverage bot defines "not_asan" (somehow.. not sure how yet!), even though it doesn't build the ASan runtime. This is causing the bot to break.</div><div class=""><br class=""></div><div class=""><a href="http://green.lab.llvm.org/green//job/clang-stage2-coverage-R/1801" class="">http://green.lab.llvm.org/green//job/clang-stage2-coverage-R/1801</a></div><div class=""><br class=""></div><div class="">vedant</div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On Apr 17, 2017, at 10:57 AM, Adrian Prantl via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">Author: adrian<br class="">Date: Mon Apr 17 12:57:01 2017<br class="">New Revision: 300467<br class=""><br class="">URL: <a href="http://llvm.org/viewvc/llvm-project?rev=300467&view=rev" class="">http://llvm.org/viewvc/llvm-project?rev=300467&view=rev</a><br class="">Log:<br class="">Revert "Revert "Add a test for __block variables + asan.""<br class=""><br class="">This reapplies commit r300228.<br class=""><br class="">Modified:<br class=""> debuginfo-tests/trunk/asan.c<br class=""> debuginfo-tests/trunk/llgdb.py<br class=""><br class="">Modified: debuginfo-tests/trunk/asan.c<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/asan.c?rev=300467&r1=300466&r2=300467&view=diff" class="">http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/asan.c?rev=300467&r1=300466&r2=300467&view=diff</a><br class="">==============================================================================<br class="">--- debuginfo-tests/trunk/asan.c (original)<br class="">+++ debuginfo-tests/trunk/asan.c Mon Apr 17 12:57:01 2017<br class="">@@ -3,24 +3,38 @@<br class=""> // REQUIRES: not_asan<br class=""> // Zorg configures the ASAN stage2 bots to not build the asan<br class=""> // compiler-rt. Only run this test on non-asanified configurations.<br class="">-//<br class="">-// DEBUGGER: break 24<br class="">-// DEBUGGER: r<br class="">-// DEBUGGER: p s<br class="">-//<br class="">-// CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)<br class="">-<br class="">+void b();<br class=""> struct S {<br class=""> int a[8];<br class=""> };<br class=""><br class=""> int f(struct S s, unsigned i) {<br class="">+ // DEBUGGER: break 16<br class="">+ // DEBUGGER: r<br class="">+ // DEBUGGER: p s<br class="">+ // CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)<br class=""> return s.a[i];<br class=""> }<br class=""><br class=""> int main(int argc, const char **argv) {<br class=""> struct S s = {{0, 1, 2, 3, 4, 5, 6, 7}};<br class="">- if (f(s, 4) == 4)<br class="">- return f(s, 0);<br class="">+ if (f(s, 4) == 4) {<br class="">+ // DEBUGGER: break 26<br class="">+ // DEBUGGER: c<br class="">+ // DEBUGGER: p s<br class="">+ // CHECK: a = ([0] = 0, [1] = 1, [2] = 2, [3] = 3, [4] = 4, [5] = 5, [6] = 6, [7] = 7)<br class="">+ b();<br class="">+ }<br class=""> return 0;<br class=""> }<br class="">+<br class="">+void c() {}<br class="">+<br class="">+void b() {<br class="">+ // DEBUGGER: break 39<br class="">+ // DEBUGGER: c<br class="">+ // DEBUGGER: p x<br class="">+ // CHECK: 42<br class="">+ __block int x = 42;<br class="">+ c();<br class="">+}<br class=""><br class="">Modified: debuginfo-tests/trunk/llgdb.py<br class="">URL: <a href="http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/llgdb.py?rev=300467&r1=300466&r2=300467&view=diff" class="">http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/llgdb.py?rev=300467&r1=300466&r2=300467&view=diff</a><br class="">==============================================================================<br class="">--- debuginfo-tests/trunk/llgdb.py (original)<br class="">+++ debuginfo-tests/trunk/llgdb.py Mon Apr 17 12:57:01 2017<br class="">@@ -139,6 +139,10 @@ NOTE: There are several reasons why this<br class=""> frame = thread.GetFrameAtIndex(0)<br class=""> print frame.EvaluateExpression(' '.join(cmd[1:]))<br class=""><br class="">+ elif re.match('^n|(next)$', cmd[0]):<br class="">+ thread = process.GetThreadAtIndex(0)<br class="">+ thread.StepOver()<br class="">+<br class=""> elif re.match('^q|(quit)$', cmd[0]):<br class=""> sys.exit(0)<br class=""><br class=""><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<br class=""></div></div></blockquote></div><br class=""></div></body></html>