<div dir="ltr">Do you have a simple reproducible?<div><br></div><div>David</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 29, 2017 at 3:20 PM, Evgenii Stepanov <span dir="ltr"><<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is crashing when building ASan tests:<br>
clang-6.0: /code/llvm-project/llvm/lib/<wbr>Transforms/InstCombine/<wbr>InstCombinePHI.cpp:228:<br>
llvm::Instruction<br>
*llvm::InstCombiner::<wbr>FoldIntegerTypedPHI(llvm::<wbr>PHINode &): Assertion<br>
`(isa<PHINode>(IncomingVal) || (LoadI && LoadI->hasOneUse())) && "Can<br>
not replace LoadInst with multiple uses"' failed.<br>
#0 0x0000000001d731e4 PrintStackTraceSignalHandler(<wbr>void*)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x1d731e4)<br>
#1 0x0000000001d73506 SignalHandler(int)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x1d73506)<br>
#2 0x00007f61d4edd330 __restore_rt<br>
(/lib/x86_64-linux-gnu/<wbr>libpthread.so.0+0x10330)<br>
#3 0x00007f61d3accc37 gsignal<br>
/build/eglibc-SvCtMH/eglibc-2.<wbr>19/signal/../nptl/sysdeps/<wbr>unix/sysv/linux/raise.c:56:0<br>
#4 0x00007f61d3ad0028 abort /build/eglibc-SvCtMH/eglibc-2.<wbr>19/stdlib/abort.c:91:0<br>
#5 0x00007f61d3ac5bf6 __assert_fail_base<br>
/build/eglibc-SvCtMH/eglibc-2.<wbr>19/assert/assert.c:92:0<br>
#6 0x00007f61d3ac5ca2 (/lib/x86_64-linux-gnu/libc.<wbr>so.6+0x2fca2)<br>
#7 0x0000000001a514ea<br>
llvm::InstCombiner::<wbr>FoldIntegerTypedPHI(llvm::<wbr>PHINode&)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x1a514ea)<br>
#8 0x0000000001a560a2 llvm::InstCombiner::<wbr>visitPHINode(llvm::PHINode&)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x1a560a2)<br>
#9 0x00000000019db61b llvm::InstCombiner::run()<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x19db61b)<br>
#10 0x00000000019dd5a7<br>
combineInstructionsOverFunctio<wbr>n(llvm::Function&,<br>
llvm::InstCombineWorklist&, llvm::AAResults*, llvm::AssumptionCache&,<br>
llvm::TargetLibraryInfo&, llvm::DominatorTree&,<br>
llvm::<wbr>OptimizationRemarkEmitter&, bool, llvm::LoopInfo*)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x19dd5a7)<br>
#11 0x00000000019ddc66<br>
llvm::<wbr>InstructionCombiningPass::<wbr>runOnFunction(llvm::Function&)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x19ddc66)<br>
#12 0x00000000018cbb9f<br>
llvm::FPPassManager::<wbr>runOnFunction(llvm::Function&)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x18cbb9f)<br>
#13 0x0000000001387fc6 (anonymous<br>
namespace)::CGPassManager::<wbr>runOnModule(llvm::Module&)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x1387fc6)<br>
#14 0x00000000018cc2f5<br>
llvm::legacy::PassManagerImpl:<wbr>:run(llvm::Module&)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x18cc2f5)<br>
#15 0x0000000001f0838b<br>
clang::EmitBackendOutput(<wbr>clang::DiagnosticsEngine&,<br>
clang::HeaderSearchOptions const&, clang::CodeGenOptions const&,<br>
clang::TargetOptions const&, clang::LangOptions const&,<br>
llvm::DataLayout const&, llvm::Module*, clang::BackendAction,<br>
std::unique_ptr<llvm::raw_<wbr>pwrite_stream,<br>
std::default_delete<llvm::raw_<wbr>pwrite_stream> >)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x1f0838b)<br>
#16 0x00000000026763ce<br>
clang::BackendConsumer::<wbr>HandleTranslationUnit(clang::<wbr>ASTContext&)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x26763ce)<br>
#17 0x0000000002b25b96 clang::ParseAST(clang::Sema&, bool, bool)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x2b25b96)<br>
#18 0x0000000002319798 clang::FrontendAction::<wbr>Execute()<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x2319798)<br>
#19 0x00000000022c8841<br>
clang::CompilerInstance::<wbr>ExecuteAction(clang::<wbr>FrontendAction&)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x22c8841)<br>
#20 0x00000000023a7d6a<br>
clang::<wbr>ExecuteCompilerInvocation(<wbr>clang::CompilerInstance*)<br>
(/code/build-llvm/bin/clang-6.<wbr>0+0x23a7d6a)<br>
#21 0x00000000008686b4 cc1_main(llvm::ArrayRef<char const*>, char<br>
const*, void*) (/code/build-llvm/bin/clang-6.<wbr>0+0x8686b4)<br>
#22 0x0000000000866214 main (/code/build-llvm/bin/clang-6.<wbr>0+0x866214)<br>
<br>
On Fri, Sep 29, 2017 at 3:10 PM, Xinliang David Li via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: davidxl<br>
> Date: Fri Sep 29 15:10:15 2017<br>
> New Revision: 314561<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314561&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=314561&view=rev</a><br>
> Log:<br>
> Eliminate PHI (int typed) which has only one use by intptr<br>
><br>
> This patch will eliminate redundant intptr/ptrtoint that pessimizes<br>
> analyses such as SCEV, AA and will make optimization passes such<br>
> as auto-vectorization more powerful.<br>
><br>
> Differential revision: <a href="http://reviews.llvm.org/D37832" rel="noreferrer" target="_blank">http://reviews.llvm.org/D37832</a><br>
><br>
> Added:<br>
> llvm/trunk/test/Transforms/<wbr>InstCombine/intptr1.ll<br>
> llvm/trunk/test/Transforms/<wbr>InstCombine/intptr2.ll<br>
> llvm/trunk/test/Transforms/<wbr>InstCombine/intptr3.ll<br>
> llvm/trunk/test/Transforms/<wbr>InstCombine/intptr4.ll<br>
> Modified:<br>
> llvm/trunk/lib/Transforms/<wbr>InstCombine/<wbr>InstCombineInternal.h<br>
> llvm/trunk/lib/Transforms/<wbr>InstCombine/InstCombinePHI.cpp<br>
><br>
> Modified: llvm/trunk/lib/Transforms/<wbr>InstCombine/<wbr>InstCombineInternal.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineInternal.h?rev=314561&r1=314560&r2=314561&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/InstCombine/<wbr>InstCombineInternal.h?rev=<wbr>314561&r1=314560&r2=314561&<wbr>view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Transforms/<wbr>InstCombine/<wbr>InstCombineInternal.h (original)<br>
> +++ llvm/trunk/lib/Transforms/<wbr>InstCombine/<wbr>InstCombineInternal.h Fri Sep 29 15:10:15 2017<br>
> @@ -670,6 +670,10 @@ private:<br>
> Instruction *FoldPHIArgGEPIntoPHI(PHINode &PN);<br>
> Instruction *FoldPHIArgLoadIntoPHI(PHINode &PN);<br>
> Instruction *FoldPHIArgZextsIntoPHI(<wbr>PHINode &PN);<br>
> + /// If an integer typed PHI has only one use which is an IntToPtr operation,<br>
> + /// replace the PHI with an existing pointer typed PHI if it exists. Otherwise<br>
> + /// insert a new pointer typed PHI and replace the original one.<br>
> + Instruction *FoldIntegerTypedPHI(PHINode &PN);<br>
><br>
> /// Helper function for FoldPHIArgXIntoPHI() to get debug location for the<br>
> /// folded operation.<br>
><br>
> Modified: llvm/trunk/lib/Transforms/<wbr>InstCombine/InstCombinePHI.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombinePHI.cpp?rev=314561&r1=314560&r2=314561&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/InstCombine/<wbr>InstCombinePHI.cpp?rev=314561&<wbr>r1=314560&r2=314561&view=diff</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/lib/Transforms/<wbr>InstCombine/InstCombinePHI.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/<wbr>InstCombine/InstCombinePHI.cpp Fri Sep 29 15:10:15 2017<br>
> @@ -39,6 +39,222 @@ DebugLoc InstCombiner::<wbr>PHIArgMergedDebug<br>
> return Loc;<br>
> }<br>
><br>
> +// Replace Integer typed PHI PN if the PHI's value is used as a pointer value.<br>
> +// If there is an existing pointer typed PHI that produces the same value as PN,<br>
> +// replace PN and the IntToPtr operation with it. Otherwise, synthesize a new<br>
> +// PHI node:<br>
> +//<br>
> +// Case-1:<br>
> +// bb1:<br>
> +// int_init = PtrToInt(ptr_init)<br>
> +// br label %bb2<br>
> +// bb2:<br>
> +// int_val = PHI([int_init, %bb1], [int_val_inc, %bb2]<br>
> +// ptr_val = PHI([ptr_init, %bb1], [ptr_val_inc, %bb2]<br>
> +// ptr_val2 = IntToPtr(int_val)<br>
> +// ...<br>
> +// use(ptr_val2)<br>
> +// ptr_val_inc = ...<br>
> +// inc_val_inc = PtrToInt(ptr_val_inc)<br>
> +//<br>
> +// ==><br>
> +// bb1:<br>
> +// br label %bb2<br>
> +// bb2:<br>
> +// ptr_val = PHI([ptr_init, %bb1], [ptr_val_inc, %bb2]<br>
> +// ...<br>
> +// use(ptr_val)<br>
> +// ptr_val_inc = ...<br>
> +//<br>
> +// Case-2:<br>
> +// bb1:<br>
> +// int_ptr = BitCast(ptr_ptr)<br>
> +// int_init = Load(int_ptr)<br>
> +// br label %bb2<br>
> +// bb2:<br>
> +// int_val = PHI([int_init, %bb1], [int_val_inc, %bb2]<br>
> +// ptr_val2 = IntToPtr(int_val)<br>
> +// ...<br>
> +// use(ptr_val2)<br>
> +// ptr_val_inc = ...<br>
> +// inc_val_inc = PtrToInt(ptr_val_inc)<br>
> +// ==><br>
> +// bb1:<br>
> +// ptr_init = Load(ptr_ptr)<br>
> +// br label %bb2<br>
> +// bb2:<br>
> +// ptr_val = PHI([ptr_init, %bb1], [ptr_val_inc, %bb2]<br>
> +// ...<br>
> +// use(ptr_val)<br>
> +// ptr_val_inc = ...<br>
> +// ...<br>
> +//<br>
> +Instruction *InstCombiner::<wbr>FoldIntegerTypedPHI(PHINode &PN) {<br>
> + if (!PN.getType()->isIntegerTy())<br>
> + return nullptr;<br>
> + if (!PN.hasOneUse())<br>
> + return nullptr;<br>
> +<br>
> + auto *IntToPtr = dyn_cast<IntToPtrInst>(PN.<wbr>user_back());<br>
> + if (!IntToPtr)<br>
> + return nullptr;<br>
> +<br>
> + // Check if the pointer is actually used as pointer:<br>
> + auto HasPointerUse = [](Instruction *IIP) {<br>
> + for (User *U : IIP->users()) {<br>
> + Value *Ptr = nullptr;<br>
> + if (LoadInst *LoadI = dyn_cast<LoadInst>(U)) {<br>
> + Ptr = LoadI->getPointerOperand();<br>
> + } else if (StoreInst *SI = dyn_cast<StoreInst>(U)) {<br>
> + Ptr = SI->getPointerOperand();<br>
> + } else if (GetElementPtrInst *GI = dyn_cast<GetElementPtrInst>(U)<wbr>) {<br>
> + Ptr = GI->getPointerOperand();<br>
> + }<br>
> +<br>
> + if (Ptr && Ptr == IIP)<br>
> + return true;<br>
> + }<br>
> + return false;<br>
> + };<br>
> +<br>
> + if (!HasPointerUse(IntToPtr))<br>
> + return nullptr;<br>
> +<br>
> + if (DL.getPointerSizeInBits(<wbr>IntToPtr->getAddressSpace()) !=<br>
> + DL.getTypeSizeInBits(IntToPtr-<wbr>>getOperand(0)->getType()))<br>
> + return nullptr;<br>
> +<br>
> + SmallVector<Value *, 4> AvailablePtrVals;<br>
> + for (unsigned i = 0; i != PN.getNumIncomingValues(); ++i) {<br>
> + Value *Arg = PN.getIncomingValue(i);<br>
> +<br>
> + // First look backward:<br>
> + if (auto *PI = dyn_cast<PtrToIntInst>(Arg)) {<br>
> + AvailablePtrVals.emplace_back(<wbr>PI->getOperand(0));<br>
> + continue;<br>
> + }<br>
> +<br>
> + // Next look forward:<br>
> + Value *ArgIntToPtr = nullptr;<br>
> + for (User *U : Arg->users()) {<br>
> + if (isa<IntToPtrInst>(U) && U->getType() == IntToPtr->getType() &&<br>
> + (DT.dominates(cast<<wbr>Instruction>(U), PN.getIncomingBlock(i)) ||<br>
> + cast<Instruction>(U)-><wbr>getParent() == PN.getIncomingBlock(i))) {<br>
> + ArgIntToPtr = U;<br>
> + break;<br>
> + }<br>
> + }<br>
> +<br>
> + if (ArgIntToPtr) {<br>
> + AvailablePtrVals.emplace_back(<wbr>ArgIntToPtr);<br>
> + continue;<br>
> + }<br>
> +<br>
> + // If Arg is defined by a PHI, allow it. This will also create<br>
> + // more opportunities iteratively.<br>
> + if (isa<PHINode>(Arg)) {<br>
> + AvailablePtrVals.emplace_back(<wbr>Arg);<br>
> + continue;<br>
> + }<br>
> +<br>
> + // For a single use integer load:<br>
> + auto *LoadI = dyn_cast<LoadInst>(Arg);<br>
> + if (!LoadI)<br>
> + return nullptr;<br>
> +<br>
> + if (!LoadI->hasOneUse())<br>
> + return nullptr;<br>
> +<br>
> + // Push the integer typed Load instruction into the available<br>
> + // value set, and fix it up later when the pointer typed PHI<br>
> + // is synthesized.<br>
> + AvailablePtrVals.emplace_back(<wbr>LoadI);<br>
> + }<br>
> +<br>
> + // Now search for a matching PHI<br>
> + auto *BB = PN.getParent();<br>
> + assert(AvailablePtrVals.size() == PN.getNumIncomingValues() &&<br>
> + "Not enough available ptr typed incoming values");<br>
> + PHINode *MatchingPtrPHI = nullptr;<br>
> + for (auto II = BB->begin(), EI = BasicBlock::iterator(BB-><wbr>getFirstNonPHI());<br>
> + II != EI; II++) {<br>
> + PHINode *PtrPHI = dyn_cast<PHINode>(II);<br>
> + if (!PtrPHI || PtrPHI == &PN)<br>
> + continue;<br>
> + MatchingPtrPHI = PtrPHI;<br>
> + for (unsigned i = 0; i != PtrPHI->getNumIncomingValues()<wbr>; ++i) {<br>
> + if (AvailablePtrVals[i] != PtrPHI->getIncomingValue(i)) {<br>
> + MatchingPtrPHI = nullptr;<br>
> + break;<br>
> + }<br>
> + }<br>
> +<br>
> + if (MatchingPtrPHI)<br>
> + break;<br>
> + }<br>
> +<br>
> + if (MatchingPtrPHI) {<br>
> + assert(MatchingPtrPHI-><wbr>getType() == IntToPtr->getType() &&<br>
> + "Phi's Type does not match with IntToPtr");<br>
> + // The PtrToCast + IntToPtr will be simplified later<br>
> + return CastInst::<wbr>CreateBitOrPointerCast(<wbr>MatchingPtrPHI,<br>
> + IntToPtr->getOperand(0)-><wbr>getType());<br>
> + }<br>
> +<br>
> + // If it requires a conversion for every PHI operand, do not do it.<br>
> + if (std::all_of(AvailablePtrVals.<wbr>begin(), AvailablePtrVals.end(),<br>
> + [&](Value *V) {<br>
> + return (V->getType() != IntToPtr->getType()) ||<br>
> + isa<IntToPtrInst>(V);<br>
> + }))<br>
> + return nullptr;<br>
> +<br>
> + PHINode *NewPtrPHI = PHINode::Create(<br>
> + IntToPtr->getType(), PN.getNumIncomingValues(), PN.getName() + ".ptr");<br>
> +<br>
> + InsertNewInstBefore(NewPtrPHI, PN);<br>
> + for (unsigned i = 0; i != PN.getNumIncomingValues(); ++i) {<br>
> + auto *IncomingBB = PN.getIncomingBlock(i);<br>
> + auto *IncomingVal = AvailablePtrVals[i];<br>
> +<br>
> + if (IncomingVal->getType() == IntToPtr->getType()) {<br>
> + NewPtrPHI->addIncoming(<wbr>IncomingVal, IncomingBB);<br>
> + continue;<br>
> + }<br>
> +<br>
> +#ifndef NDEBUG<br>
> + LoadInst *LoadI = dyn_cast<LoadInst>(<wbr>IncomingVal);<br>
> + assert((isa<PHINode>(<wbr>IncomingVal) || (LoadI && LoadI->hasOneUse())) &&<br>
> + "Can not replace LoadInst with multiple uses");<br>
> +#endif<br>
> + // Need to insert a BitCast.<br>
> + // For an integer Load instruction with a single use, the load + IntToPtr<br>
> + // cast will be simplified into a pointer load:<br>
> + // %v = load i64, i64* %a.ip, align 8<br>
> + // %v.cast = inttoptr i64 %v to float **<br>
> + // ==><br>
> + // %v.ptrp = bitcast i64 * %a.ip to float **<br>
> + // %v.cast = load float *, float ** %v.ptrp, align 8<br>
> + auto *CI = CastInst::<wbr>CreateBitOrPointerCast(<br>
> + IncomingVal, IntToPtr->getType(), IncomingVal->getName() + ".ptr");<br>
> + if (auto *IncomingI = dyn_cast<Instruction>(<wbr>IncomingVal)) {<br>
> + BasicBlock::iterator InsertPos(IncomingI);<br>
> + InsertPos++;<br>
> + if (isa<PHINode>(IncomingI))<br>
> + InsertPos = IncomingI->getParent()-><wbr>getFirstInsertionPt();<br>
> + InsertNewInstBefore(CI, *InsertPos);<br>
> + } else {<br>
> + auto *InsertBB = &IncomingBB->getParent()-><wbr>getEntryBlock();<br>
> + InsertNewInstBefore(CI, *InsertBB-><wbr>getFirstInsertionPt());<br>
> + }<br>
> + NewPtrPHI->addIncoming(CI, IncomingBB);<br>
> + }<br>
> +<br>
> + // The PtrToCast + IntToPtr will be simplified later<br>
> + return CastInst::<wbr>CreateBitOrPointerCast(<wbr>NewPtrPHI,<br>
> + IntToPtr->getOperand(0)-><wbr>getType());<br>
> +}<br>
> +<br>
> /// If we have something like phi [add (a,b), add(a,c)] and if a/b/c and the<br>
> /// adds all have a single use, turn this into a phi and a single binop.<br>
> Instruction *InstCombiner::<wbr>FoldPHIArgBinOpIntoPHI(PHINode &PN) {<br>
> @@ -902,6 +1118,9 @@ Instruction *InstCombiner::visitPHINode(<br>
> // this PHI only has a single use (a PHI), and if that PHI only has one use (a<br>
> // PHI)... break the cycle.<br>
> if (PN.hasOneUse()) {<br>
> + if (Instruction *Result = FoldIntegerTypedPHI(PN))<br>
> + return Result;<br>
> +<br>
> Instruction *PHIUser = cast<Instruction>(PN.user_<wbr>back());<br>
> if (PHINode *PU = dyn_cast<PHINode>(PHIUser)) {<br>
> SmallPtrSet<PHINode*, 16> PotentiallyDeadPHIs;<br>
><br>
> Added: llvm/trunk/test/Transforms/<wbr>InstCombine/intptr1.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/intptr1.ll?rev=314561&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Transforms/InstCombine/<wbr>intptr1.ll?rev=314561&view=<wbr>auto</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/Transforms/<wbr>InstCombine/intptr1.ll (added)<br>
> +++ llvm/trunk/test/Transforms/<wbr>InstCombine/intptr1.ll Fri Sep 29 15:10:15 2017<br>
> @@ -0,0 +1,181 @@<br>
> +; RUN: opt < %s -instcombine -S | FileCheck %s<br>
> +<br>
> +<br>
> +define void @test1(float* %a, float* readnone %a_end, i64* %b.i64) {<br>
> +; CHECK-LABEL: @test1<br>
> +entry:<br>
> + %cmp1 = icmp ult float* %a, %a_end<br>
> + br i1 %cmp1, label %for.body.preheader, label %for.end<br>
> +<br>
> +for.body.preheader: ; preds = %entry<br>
> + %b = load i64, i64* %b.i64, align 8<br>
> +; CHECK: load float*, float**<br>
> + br label %for.body<br>
> +<br>
> +for.body: ; preds = %for.body, %for.body.preheader<br>
> + %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> + %b.addr.02 = phi i64 [ %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a>, %for.body ], [ %b, %for.body.preheader ]<br>
> +<br>
> +; CHECK: %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> +; CHECK: %b.addr.02.ptr = phi float* [ %add, %for.body ],<br>
> +; CHECK-NOT: %b.addr.02 = phi i64<br>
> +<br>
> + %tmp = inttoptr i64 %b.addr.02 to float*<br>
> +; CHECK-NOT: inttoptr i64<br>
> + %tmp1 = load float, float* %tmp, align 4<br>
> + %mul.i = fmul float %tmp1, 4.200000e+01<br>
> + store float %mul.i, float* %a.addr.03, align 4<br>
> + %add = getelementptr inbounds float, float* %tmp, i64 1<br>
> + %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a> = ptrtoint float* %add to i64<br>
> +; CHECK-NOT: ptrtoint float*<br>
> + %incdec.ptr = getelementptr inbounds float, float* %a.addr.03, i64 1<br>
> + %cmp = icmp ult float* %incdec.ptr, %a_end<br>
> + br i1 %cmp, label %for.body, label %for.end<br>
> +<br>
> +for.end: ; preds = %for.body, %entry<br>
> + ret void<br>
> +}<br>
> +<br>
> +define void @test1_neg(float* %a, float* readnone %a_end, i64* %b.i64) {<br>
> +; CHECK-LABEL: @test1_neg<br>
> +entry:<br>
> + %cmp1 = icmp ult float* %a, %a_end<br>
> + br i1 %cmp1, label %for.body.preheader, label %for.end<br>
> +<br>
> +for.body.preheader: ; preds = %entry<br>
> + %b = load i64, i64* %b.i64, align 8<br>
> + br label %for.body<br>
> +<br>
> +for.body: ; preds = %for.body, %for.body.preheader<br>
> + %a.addr.03 = phi float* [ %incdec.ptr, %bb ], [ %a, %for.body.preheader ]<br>
> + %b.addr.02 = phi i64 [ %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a>, %bb ], [ %b, %for.body.preheader ]<br>
> +<br>
> +; CHECK: %a.addr.03 = phi float* [ %incdec.ptr, %bb ], [ %a, %for.body.preheader ]<br>
> +; CHECK: %b.addr.02 = phi i64<br>
> +<br>
> + %tmp = inttoptr i64 %b.addr.02 to float*<br>
> +; CHECK: inttoptr i64<br>
> + %ptrcmp = icmp ult float* %tmp, %a_end<br>
> + br i1 %ptrcmp, label %for.end, label %bb<br>
> +<br>
> +bb:<br>
> + %tmp1 = load float, float* %a, align 4<br>
> + %mul.i = fmul float %tmp1, 4.200000e+01<br>
> + store float %mul.i, float* %a.addr.03, align 4<br>
> + %add = getelementptr inbounds float, float* %a, i64 1<br>
> + %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a> = ptrtoint float* %add to i64<br>
> +; CHECK: ptrtoint float*<br>
> + %incdec.ptr = getelementptr inbounds float, float* %a.addr.03, i64 1<br>
> + %cmp = icmp ult float* %incdec.ptr, %a_end<br>
> + br i1 %cmp, label %for.body, label %for.end<br>
> +<br>
> +for.end: ; preds = %for.body, %entry<br>
> + ret void<br>
> +}<br>
> +<br>
> +<br>
> +define void @test2(float* %a, float* readnone %a_end, float** %b.float) {<br>
> +; CHECK-LABEL: @test2<br>
> +entry:<br>
> + %cmp1 = icmp ult float* %a, %a_end<br>
> + br i1 %cmp1, label %for.body.preheader, label %for.end<br>
> +<br>
> +for.body.preheader: ; preds = %entry<br>
> + %b.i64 = bitcast float** %b.float to i64*<br>
> + %b = load i64, i64* %b.i64, align 8<br>
> +; CHECK: load float*, float**<br>
> + br label %for.body<br>
> +<br>
> +for.body: ; preds = %for.body, %for.body.preheader<br>
> + %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> + %b.addr.02 = phi i64 [ %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a>, %for.body ], [ %b, %for.body.preheader ]<br>
> +<br>
> +; CHECK: %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> +; CHECK: %b.addr.02.ptr = phi float* [ %add, %for.body ],<br>
> +; CHECK-NOT: %b.addr.02 = phi i64<br>
> +<br>
> + %tmp = inttoptr i64 %b.addr.02 to float*<br>
> +; CHECK-NOT: inttoptr i64<br>
> + %tmp1 = load float, float* %tmp, align 4<br>
> + %mul.i = fmul float %tmp1, 4.200000e+01<br>
> + store float %mul.i, float* %a.addr.03, align 4<br>
> + %add = getelementptr inbounds float, float* %tmp, i64 1<br>
> + %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a> = ptrtoint float* %add to i64<br>
> +; CHECK-NOT: ptrtoint float*<br>
> + %incdec.ptr = getelementptr inbounds float, float* %a.addr.03, i64 1<br>
> + %cmp = icmp ult float* %incdec.ptr, %a_end<br>
> + br i1 %cmp, label %for.body, label %for.end<br>
> +<br>
> +for.end: ; preds = %for.body, %entry<br>
> + ret void<br>
> +}<br>
> +<br>
> +<br>
> +define void @test3(float* %a, float* readnone %a_end, i8** %b.i8p) {<br>
> +; CHECK-LABEL: @test3<br>
> +entry:<br>
> + %cmp1 = icmp ult float* %a, %a_end<br>
> + br i1 %cmp1, label %for.body.preheader, label %for.end<br>
> +<br>
> +for.body.preheader: ; preds = %entry<br>
> + %b.i64 = bitcast i8** %b.i8p to i64*<br>
> + %b = load i64, i64* %b.i64, align 8<br>
> +; CHECK: load float*, float**<br>
> + br label %for.body<br>
> +<br>
> +for.body: ; preds = %for.body, %for.body.preheader<br>
> + %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> + %b.addr.02 = phi i64 [ %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a>, %for.body ], [ %b, %for.body.preheader ]<br>
> +<br>
> +; CHECK: %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> +; CHECK: %b.addr.02.ptr = phi float* [ %add, %for.body ],<br>
> +; CHECK-NOT: %b.addr.02 = phi i64<br>
> +<br>
> + %tmp = inttoptr i64 %b.addr.02 to float*<br>
> +; CHECK-NOT: inttoptr i64<br>
> + %tmp1 = load float, float* %tmp, align 4<br>
> + %mul.i = fmul float %tmp1, 4.200000e+01<br>
> + store float %mul.i, float* %a.addr.03, align 4<br>
> + %add = getelementptr inbounds float, float* %tmp, i64 1<br>
> + %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a> = ptrtoint float* %add to i64<br>
> +; CHECK-NOT: ptrtoint float*<br>
> + %incdec.ptr = getelementptr inbounds float, float* %a.addr.03, i64 1<br>
> + %cmp = icmp ult float* %incdec.ptr, %a_end<br>
> + br i1 %cmp, label %for.body, label %for.end<br>
> +<br>
> +for.end: ; preds = %for.body, %entry<br>
> + ret void<br>
> +}<br>
> +<br>
> +<br>
> +define void @test4(float* %a, float* readnone %a_end, float** %b.float) {<br>
> +entry:<br>
> +; CHECK-LABEL: @test4<br>
> + %cmp1 = icmp ult float* %a, %a_end<br>
> + br i1 %cmp1, label %for.body.preheader, label %for.end<br>
> +<br>
> +for.body.preheader: ; preds = %entry<br>
> + %b.f = load float*, float** %b.float, align 8<br>
> + %b = ptrtoint float* %b.f to i64<br>
> +; CHECK: load float*, float**<br>
> +; CHECK-NOT: ptrtoint float*<br>
> + br label %for.body<br>
> +<br>
> +for.body: ; preds = %for.body, %for.body.preheader<br>
> + %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> + %b.addr.02 = phi i64 [ %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a>, %for.body ], [ %b, %for.body.preheader ]<br>
> + %tmp = inttoptr i64 %b.addr.02 to float*<br>
> +; CHECK-NOT: inttoptr i64<br>
> + %tmp1 = load float, float* %tmp, align 4<br>
> + %mul.i = fmul float %tmp1, 4.200000e+01<br>
> + store float %mul.i, float* %a.addr.03, align 4<br>
> + %add = getelementptr inbounds float, float* %tmp, i64 1<br>
> + %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a> = ptrtoint float* %add to i64<br>
> +; CHECK-NOT: ptrtoint float*<br>
> + %incdec.ptr = getelementptr inbounds float, float* %a.addr.03, i64 1<br>
> + %cmp = icmp ult float* %incdec.ptr, %a_end<br>
> + br i1 %cmp, label %for.body, label %for.end<br>
> +<br>
> +for.end: ; preds = %for.body, %entry<br>
> + ret void<br>
> +}<br>
><br>
> Added: llvm/trunk/test/Transforms/<wbr>InstCombine/intptr2.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/intptr2.ll?rev=314561&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Transforms/InstCombine/<wbr>intptr2.ll?rev=314561&view=<wbr>auto</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/Transforms/<wbr>InstCombine/intptr2.ll (added)<br>
> +++ llvm/trunk/test/Transforms/<wbr>InstCombine/intptr2.ll Fri Sep 29 15:10:15 2017<br>
> @@ -0,0 +1,37 @@<br>
> +; RUN: opt < %s -instcombine -S | FileCheck %s<br>
> +<br>
> +define void @test1(float* %a, float* readnone %a_end, i32* %b.i) {<br>
> +; CHECK-LABEL: @test1<br>
> +entry:<br>
> + %cmp1 = icmp ult float* %a, %a_end<br>
> + br i1 %cmp1, label %for.body.preheader, label %for.end<br>
> +<br>
> +for.body.preheader: ; preds = %entry<br>
> + %b = ptrtoint i32 * %b.i to i64<br>
> +; CHECK: bitcast<br>
> +; CHECK-NOT: ptrtoint<br>
> + br label %for.body<br>
> +<br>
> +for.body: ; preds = %for.body, %for.body.preheader<br>
> + %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> + %b.addr.02 = phi i64 [ %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a>, %for.body ], [ %b, %for.body.preheader ]<br>
> +<br>
> +; CHECK: %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> +; CHECK-NOT: phi i64<br>
> +<br>
> + %tmp = inttoptr i64 %b.addr.02 to float*<br>
> +; CHECK-NOT: inttoptr<br>
> + %tmp1 = load float, float* %tmp, align 4<br>
> + %mul.i = fmul float %tmp1, 4.200000e+01<br>
> + store float %mul.i, float* %a.addr.03, align 4<br>
> + %add = getelementptr inbounds float, float* %tmp, i64 1<br>
> + %<a href="http://add.int" rel="noreferrer" target="_blank">add.int</a> = ptrtoint float* %add to i64<br>
> +; CHECK-NOT: ptrtoint<br>
> + %incdec.ptr = getelementptr inbounds float, float* %a.addr.03, i64 1<br>
> + %cmp = icmp ult float* %incdec.ptr, %a_end<br>
> + br i1 %cmp, label %for.body, label %for.end<br>
> +<br>
> +for.end: ; preds = %for.body, %entry<br>
> + ret void<br>
> +}<br>
> +<br>
><br>
> Added: llvm/trunk/test/Transforms/<wbr>InstCombine/intptr3.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/intptr3.ll?rev=314561&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Transforms/InstCombine/<wbr>intptr3.ll?rev=314561&view=<wbr>auto</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/Transforms/<wbr>InstCombine/intptr3.ll (added)<br>
> +++ llvm/trunk/test/Transforms/<wbr>InstCombine/intptr3.ll Fri Sep 29 15:10:15 2017<br>
> @@ -0,0 +1,37 @@<br>
> +; RUN: opt < %s -instcombine -S | FileCheck %s<br>
> +<br>
> +<br>
> +define void @test(float* %a, float* readnone %a_end, i64 %b) unnamed_addr {<br>
> +entry:<br>
> + %cmp1 = icmp ult float* %a, %a_end<br>
> + br i1 %cmp1, label %for.body.preheader, label %for.end<br>
> +<br>
> +for.body.preheader: ; preds = %entry<br>
> + %b.float = inttoptr i64 %b to float*<br>
> + br label %for.body<br>
> +<br>
> +for.body: ; preds = %for.body.preheader, %for.body<br>
> + %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> + %b.addr.float = phi float* [ %b.addr.float.inc, %for.body ], [ %b.float, %for.body.preheader ]<br>
> + %b.addr.i64 = phi i64 [ %b.addr.i64.inc, %for.body ], [ %b, %for.body.preheader ]<br>
> +; CHECK: %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> +; CHECK-NEXT: %b.addr.float = phi float* [ %b.addr.float.inc, %for.body ], [ %b.float, %for.body.preheader ]<br>
> +; CHECK-NEXT: = load float<br>
> + %l = load float, float* %b.addr.float, align 4<br>
> + %mul.i = fmul float %l, 4.200000e+01<br>
> + store float %mul.i, float* %a.addr.03, align 4<br>
> + %b.addr.float.2 = inttoptr i64 %b.addr.i64 to float*<br>
> +; CHECK-NOT: inttoptr<br>
> + %b.addr.float.inc = getelementptr inbounds float, float* %b.addr.float.2, i64 1<br>
> + %b.addr.i64.inc = ptrtoint float* %b.addr.float.inc to i64<br>
> +; CHECK-NOT: ptrtoint<br>
> + %incdec.ptr = getelementptr inbounds float, float* %a.addr.03, i64 1<br>
> + %cmp = icmp ult float* %incdec.ptr, %a_end<br>
> + br i1 %cmp, label %for.body, label %for.end<br>
> +<br>
> +for.end: ; preds = %for.body, %entry<br>
> + ret void<br>
> +}<br>
> +<br>
> +<br>
> +<br>
><br>
> Added: llvm/trunk/test/Transforms/<wbr>InstCombine/intptr4.ll<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/intptr4.ll?rev=314561&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>Transforms/InstCombine/<wbr>intptr4.ll?rev=314561&view=<wbr>auto</a><br>
> ==============================<wbr>==============================<wbr>==================<br>
> --- llvm/trunk/test/Transforms/<wbr>InstCombine/intptr4.ll (added)<br>
> +++ llvm/trunk/test/Transforms/<wbr>InstCombine/intptr4.ll Fri Sep 29 15:10:15 2017<br>
> @@ -0,0 +1,47 @@<br>
> +; RUN: opt < %s -instcombine -S | FileCheck %s<br>
> +<br>
> +<br>
> +define void @test(float* %a, float* readnone %a_end, i64 %b, float* %bf) unnamed_addr {<br>
> +entry:<br>
> + %cmp1 = icmp ult float* %a, %a_end<br>
> + %b.float = inttoptr i64 %b to float*<br>
> + br i1 %cmp1, label %bb1, label %bb2<br>
> +<br>
> +bb1:<br>
> + br label %for.body.preheader<br>
> +bb2:<br>
> + %bfi = ptrtoint float* %bf to i64<br>
> + br label %for.body.preheader<br>
> +<br>
> +for.body.preheader: ; preds = %entry<br>
> + %b.phi = phi i64 [%b, %bb1], [%bfi, %bb2]<br>
> +; CHECK-LABEL: for.body.preheader<br>
> +; CHECK-NOT: %b.phi = phi i64<br>
> + br label %for.body<br>
> +<br>
> +for.body: ; preds = %for.body.preheader, %for.body<br>
> +; CHECK-LABEL: for.body<br>
> + %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> + %b.addr.float = phi float* [ %b.addr.float.inc, %for.body ], [ %b.float, %for.body.preheader ]<br>
> + %b.addr.i64 = phi i64 [ %b.addr.i64.inc, %for.body ], [ %b.phi, %for.body.preheader ]<br>
> +; CHECK: %a.addr.03 = phi float* [ %incdec.ptr, %for.body ], [ %a, %for.body.preheader ]<br>
> +; CHECK-NEXT: %b.addr.float = phi float* [ %b.addr.float.inc, %for.body ], [ %b.float, %for.body.preheader ]<br>
> +; CHECK-NOT: = %b.addr.i64<br>
> + %l = load float, float* %b.addr.float, align 4<br>
> + %mul.i = fmul float %l, 4.200000e+01<br>
> + store float %mul.i, float* %a.addr.03, align 4<br>
> + %b.addr.float.2 = inttoptr i64 %b.addr.i64 to float*<br>
> +; CHECK-NOT: inttoptr<br>
> + %b.addr.float.inc = getelementptr inbounds float, float* %b.addr.float.2, i64 1<br>
> + %b.addr.i64.inc = ptrtoint float* %b.addr.float.inc to i64<br>
> +; CHECK-NOT: ptrtoint<br>
> + %incdec.ptr = getelementptr inbounds float, float* %a.addr.03, i64 1<br>
> + %cmp = icmp ult float* %incdec.ptr, %a_end<br>
> + br i1 %cmp, label %for.body, label %for.end<br>
> +<br>
> +for.end: ; preds = %for.body, %entry<br>
> + ret void<br>
> +}<br>
> +<br>
> +<br>
> +<br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>