<div dir="ltr">Hi Douglas,<div><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">I don’t know if you are aware, </blockquote><div><br></div><div>I was, but lost connectivity on my commute and could commit the fix. My apologies. This should be fixed by r314490.<br></div></div><div><br></div><div>- Lang.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 28, 2017 at 8:40 PM, Yung, Douglas <span dir="ltr"><<a href="mailto:douglas.yung@sony.com" target="_blank">douglas.yung@sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_2023745203550153300WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi Lang, I don’t know if you are aware, but the PS4 Windows bot is still broken from your change even with this fix.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/12393" target="_blank">http://lab.llvm.org:8011/<wbr>builders/llvm-clang-lld-x86_<wbr>64-scei-ps4-windows10pro-fast/<wbr>builds/12393</a>:
(building r314486)<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:"Courier New";color:black">C:\ps4-buildslave2\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>unittests\ExecutionEngine\Orc\<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp(261): error C2065: 'ObjLayer':
undeclared identifier<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:"Courier New";color:black">C:\ps4-buildslave2\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>unittests\ExecutionEngine\Orc\<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp(261): error C2651: 'unknown-type':
left of '::' must be a class, struct or union<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:"Courier New";color:black">C:\ps4-buildslave2\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>unittests\ExecutionEngine\Orc\<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp(261): error C2144: syntax error:
'unknown-type' should be preceded by ')'<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:"Courier New";color:black">C:\ps4-buildslave2\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>unittests\ExecutionEngine\Orc\<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp(261): error C3260: 'type':
skipping unexpected token(s) before lambda body<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:"Courier New";color:black">C:\ps4-buildslave2\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>unittests\ExecutionEngine\Orc\<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp(263): error C2664: 'llvm::orc::<wbr>RTDyldObjectLinkingLayer::<wbr>RTDyldObjectLinkingLayer(llvm:<wbr>:orc::RTDyldObjectLinkingLayer
&&)': cannot convert argument 2 from '`anonymous-namespace'::<wbr>RTDyldObjectLinkingLayerExecut<wbr>ionTest_<wbr>TestNotifyLoadedSignature_<wbr>Test::TestBody::<lambda_<wbr>0c2aeba18b2343eb100eeaee81fedf<wbr>3a>' to 'llvm::orc::<wbr>RTDyldObjectLinkingLayer::<wbr>NotifyLoadedFtor'<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:13.5pt;font-family:"Courier New";color:black">C:\ps4-buildslave2\llvm-clang-<wbr>lld-x86_64-scei-ps4-<wbr>windows10pro-fast\llvm.src\<wbr>unittests\ExecutionEngine\Orc\<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp(263): note: No user-defined-conversion
operator available that can perform this conversion, or the operator cannot be called<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Douglas Yung<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-commits [mailto:<a href="mailto:llvm-commits-bounces@lists.llvm.org" target="_blank">llvm-commits-bounces@<wbr>lists.llvm.org</a>]
<b>On Behalf Of </b>Lang Hames via llvm-commits<br>
<b>Sent:</b> Thursday, September 28, 2017 19:13<br>
<b>To:</b> Evgeniy Stepanov<br>
<b>Cc:</b> Commit Messages and Patches for LLVM<br>
<b>Subject:</b> Re: [llvm] r314454 - Fix -Werror build.<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Oops! Thanks Evgeniy!<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">- Lang.<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Thu, Sep 28, 2017 at 12:43 PM, Evgeniy Stepanov via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: eugenis<br>
Date: Thu Sep 28 12:43:53 2017<br>
New Revision: 314454<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314454&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project?rev=314454&view=rev</a><br>
Log:<br>
Fix -Werror build.<br>
<br>
/code/llvm-project/llvm/<wbr>unittests/ExecutionEngine/Orc/<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp:260:38: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-<wbr>capture]<br>
[this](decltype(ObjLayer)::<wbr>ObjHandleT,<br>
<br>
Modified:<br>
llvm/trunk/unittests/<wbr>ExecutionEngine/Orc/<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp<br>
<br>
Modified: llvm/trunk/unittests/<wbr>ExecutionEngine/Orc/<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp?rev=314454&r1=314453&r2=314454&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/unittests/<wbr>ExecutionEngine/Orc/<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp?rev=314454&r1=314453&r2=<wbr>314454&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/unittests/<wbr>ExecutionEngine/Orc/<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp (original)<br>
+++ llvm/trunk/unittests/<wbr>ExecutionEngine/Orc/<wbr>RTDyldObjectLinkingLayerTest.<wbr>cpp Thu Sep 28 12:43:53 2017<br>
@@ -256,11 +256,11 @@ TEST_F(<wbr>RTDyldObjectLinkingLayerExecut<wbr>ion<br>
}<br>
<br>
TEST_F(<wbr>RTDyldObjectLinkingLayerExecut<wbr>ionTest, TestNotifyLoadedSignature) {<br>
- RTDyldObjectLinkingLayer ObjLayer([]() { return nullptr; },<br>
- [this](decltype(ObjLayer)::<wbr>ObjHandleT,<br>
- const decltype(ObjLayer)::ObjectPtr &obj,<br>
- const RuntimeDyld::LoadedObjectInfo &info) {<br>
- });<br>
+ RTDyldObjectLinkingLayer ObjLayer(<br>
+ []() { return nullptr; },<br>
+ [](decltype(ObjLayer)::<wbr>ObjHandleT,<br>
+ const decltype(ObjLayer)::ObjectPtr &obj,<br>
+ const RuntimeDyld::LoadedObjectInfo &info) {});<br>
}<br>
<br>
} // end anonymous namespace<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div>