<div dir="ltr">Thank you all for your help with this!<div><br></div><div>-Mike</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 27, 2017 at 3:59 PM, Topper, Craig <span dir="ltr"><<a href="mailto:craig.topper@intel.com" target="_blank">craig.topper@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_1018658858020785069WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Hopefully fixed in r314360<u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_1018658858020785069__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></a></p>
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="m_1018658858020785069______replyseparator"></a><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Topper, Craig
<br>
<b>Sent:</b> Wednesday, September 27, 2017 3:20 PM<br>
<b>To:</b> 'Vitaly Buka' <<a href="mailto:vitalybuka@google.com" target="_blank">vitalybuka@google.com</a>>; Evgenii Stepanov <<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>><span class=""><br>
<b>Cc:</b> Mike Edwards <<a href="mailto:mike@sqlby.me" target="_blank">mike@sqlby.me</a>>; <a href="mailto:juergen@apple.com" target="_blank">juergen@apple.com</a>; LLVM Commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>><br>
</span><b>Subject:</b> RE: [compiler-rt] r314041 - [lsan] Deadly signal handler for lsan<u></u><u></u></span></p>
</div>
</div><span class="">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">I think the attachment was lost in the reply. Can you reattach?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
</span><p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Vitaly Buka [<a href="mailto:vitalybuka@google.com" target="_blank">mailto:vitalybuka@google.com</a>]
<br><span class="">
<b>Sent:</b> Wednesday, September 27, 2017 2:58 PM<br>
<b>To:</b> Evgenii Stepanov <<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>><br>
<b>Cc:</b> Mike Edwards <<a href="mailto:mike@sqlby.me" target="_blank">mike@sqlby.me</a>>; <a href="mailto:juergen@apple.com" target="_blank">
juergen@apple.com</a>; LLVM Commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>>; Topper, Craig <<a href="mailto:craig.topper@intel.com" target="_blank">craig.topper@intel.com</a>><br>
</span><b>Subject:</b> Re: [compiler-rt] r314041 - [lsan] Deadly signal handler for lsan<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">I don't believe that it has anything to do with compiler-rt.<u></u><u></u></p>
<div>
<p class="MsoNormal">It's in InstCombiner, and the range has several related patches.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">+<span style="font-family:"Helvetica",sans-serif;color:#333333">ctopper It's more likely </span><span style="font-size:10.0pt;font-family:"Helvetica",sans-serif;color:#333333">r314025</span><u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Wed, Sep 27, 2017 at 2:41 PM, Evgenii Stepanov <<a href="mailto:eugeni.stepanov@gmail.com" target="_blank">eugeni.stepanov@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<p class="MsoNormal">Are you a 100% sure you've got the right change? This one only touches<br>
the runtime support library, and error by the buildbot link shows a<br>
compiler crash.<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal"><br>
On Wed, Sep 27, 2017 at 2:32 PM, Mike Edwards via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Hi Vitaly,<br>
> We are seeing a bot failure with this commit. The particular bot which<br>
> caught this error takes quite some time to run and this was bundled with<br>
> around 50 other commits so I apologize for the amount of time it took to get<br>
> the error to you. The bot failure can be seen here:<br>
><br>
> <a href="http://green.lab.llvm.org/green/job/clang-stage2-cmake-RgSan_build/5097/" target="_blank">
http://green.lab.llvm.org/<wbr>green/job/clang-stage2-cmake-<wbr>RgSan_build/5097/</a><br>
><br>
> I have attached a reproducer to this email and here is the command line<br>
> invocation used to reproduce the issue:<br>
><br>
> <path to compiler built on r314041>/bin/clang++ -fPIC<br>
> -fvisibility-inlines-hidden -Werror=date-time<br>
> -Werror=unguarded-<wbr>availability-new -std=c++11 -Wall -W -Wno-unused-parameter<br>
> -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic<br>
> -Wno-long-long -Wcovered-switch-default -Wnon-virtual-dtor<br>
> -Wdelete-non-virtual-dtor -Wstring-conversion -fno-omit-frame-pointer<br>
> -fsanitize=address,undefined -fno-sanitize=vptr,function<br>
> -fno-sanitize-recover=all -fsanitize-address-use-after-<wbr>scope<br>
> -fcolor-diagnostics -O2 -g -fno-exceptions -fno-rtti -o /dev/null -c<br>
> BinaryStreamError.ii<br>
><br>
> This bot has been broken for almost 5 days now (this was my fault as it took<br>
> so much time to reproduce the issue) so if you could have a look and get a<br>
> patch up as soon as possible it would be greatly appreciated.<br>
><br>
> Respectfully,<br>
> Mike Edwards<br>
><br>
> On Fri, Sep 22, 2017 at 3:57 PM, Vitaly Buka via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: vitalybuka<br>
>> Date: Fri Sep 22 15:57:48 2017<br>
>> New Revision: 314041<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314041&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project?rev=314041&view=rev</a><br>
>> Log:<br>
>> [lsan] Deadly signal handler for lsan<br>
>><br>
>> Summary: Part of <a href="https://github.com/google/sanitizers/issues/637" target="_blank">
https://github.com/google/<wbr>sanitizers/issues/637</a><br>
>><br>
>> Reviewers: eugenis, alekseyshl<br>
>><br>
>> Subscribers: llvm-commits, dberris, kubamracek, krytarowski<br>
>><br>
>> Differential Revision: <a href="https://reviews.llvm.org/D37608" target="_blank">
https://reviews.llvm.org/<wbr>D37608</a><br>
>><br>
>> Modified:<br>
>> compiler-rt/trunk/lib/lsan/<wbr>lsan.cc<br>
>> compiler-rt/trunk/lib/lsan/<wbr>lsan_interceptors.cc<br>
>> compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common.h<br>
>> compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common_libcdep.cc<br>
>><br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/allow_user_segv.cc<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/assert.cc<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/ill.cc<br>
>><br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/dedup_token_length_test.<wbr>cc<br>
>><br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/dump_instruction_bytes.<wbr>cc<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/fpe.cc<br>
>><br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/sanitizer_set_report_fd_<wbr>test.cc<br>
>><br>
>> Modified: compiler-rt/trunk/lib/lsan/<wbr>lsan.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/lsan/lsan.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/lib/<wbr>lsan/lsan.cc?rev=314041&r1=<wbr>314040&r2=314041&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/lib/lsan/<wbr>lsan.cc (original)<br>
>> +++ compiler-rt/trunk/lib/lsan/<wbr>lsan.cc Fri Sep 22 15:57:48 2017<br>
>> @@ -65,6 +65,18 @@ static void InitializeFlags() {<br>
>> if (common_flags()->help) parser.PrintFlagDescriptions()<wbr>;<br>
>> }<br>
>><br>
>> +static void OnStackUnwind(const SignalContext &sig, const void *,<br>
>> + BufferedStackTrace *stack) {<br>
>> + GetStackTraceWithPcBpAndContex<wbr>t(stack, kStackTraceMax, sig.pc, sig.bp,<br>
>> + sig.context,<br>
>> + common_flags()->fast_unwind_<wbr>on_fatal);<br>
>> +}<br>
>> +<br>
>> +void LsanOnDeadlySignal(int signo, void *siginfo, void *context) {<br>
>> + HandleDeadlySignal(siginfo, context, GetCurrentThread(),<br>
>> &OnStackUnwind,<br>
>> + nullptr);<br>
>> +}<br>
>> +<br>
>> extern "C" void __lsan_init() {<br>
>> CHECK(!lsan_init_is_running);<br>
>> if (lsan_inited)<br>
>> @@ -80,6 +92,7 @@ extern "C" void __lsan_init() {<br>
>> InitTlsSize();<br>
>> InitializeInterceptors();<br>
>> InitializeThreadRegistry();<br>
>> + InstallDeadlySignalHandlers(<wbr>LsanOnDeadlySignal);<br>
>> u32 tid = ThreadCreate(0, 0, true);<br>
>> CHECK_EQ(tid, 0);<br>
>> ThreadStart(tid, GetTid());<br>
>><br>
>> Modified: compiler-rt/trunk/lib/lsan/<wbr>lsan_interceptors.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/lsan/lsan_interceptors.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/lib/<wbr>lsan/lsan_interceptors.cc?rev=<wbr>314041&r1=314040&r2=314041&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/lib/lsan/<wbr>lsan_interceptors.cc (original)<br>
>> +++ compiler-rt/trunk/lib/lsan/<wbr>lsan_interceptors.cc Fri Sep 22 15:57:48<br>
>> 2017<br>
>> @@ -401,9 +401,14 @@ INTERCEPTOR(void, _exit, int status) {<br>
>> REAL(_exit)(status);<br>
>> }<br>
>><br>
>> +#define COMMON_INTERCEPT_FUNCTION(<wbr>name) INTERCEPT_FUNCTION(name)<br>
>> +#include "sanitizer_common/sanitizer_<wbr>signal_interceptors.inc"<br>
>> +<br>
>> namespace __lsan {<br>
>><br>
>> void InitializeInterceptors() {<br>
>> + InitializeSignalInterceptors()<wbr>;<br>
>> +<br>
>> INTERCEPT_FUNCTION(malloc);<br>
>> INTERCEPT_FUNCTION(free);<br>
>> LSAN_MAYBE_INTERCEPT_CFREE;<br>
>><br>
>> Modified: compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common.h<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common.h?rev=314041&r1=314040&<wbr>r2=314041&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common.h (original)<br>
>> +++ compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common.h Fri Sep 22<br>
>> 15:57:48 2017<br>
>> @@ -318,15 +318,24 @@ void SetSoftRssLimitExceededCallbac<wbr>k(voi<br>
>> typedef void (*SignalHandlerType)(int, void *, void *);<br>
>> HandleSignalMode GetHandleSignalMode(int signum);<br>
>> void InstallDeadlySignalHandlers(<wbr>SignalHandlerType handler);<br>
>> +<br>
>> // Signal reporting.<br>
>> -void StartReportDeadlySignal();<br>
>> // Each sanitizer uses slightly different implementation of stack<br>
>> unwinding.<br>
>> typedef void (*<wbr>UnwindSignalStackCallbackType)<wbr>(const SignalContext &sig,<br>
>> const void<br>
>> *callback_context,<br>
>> BufferedStackTrace *stack);<br>
>> +// Print deadly signal report and die.<br>
>> +void HandleDeadlySignal(void *siginfo, void *context, u32 tid,<br>
>> + UnwindSignalStackCallbackType unwind,<br>
>> + const void *unwind_context);<br>
>> +<br>
>> +// Part of HandleDeadlySignal, exposed for asan.<br>
>> +void StartReportDeadlySignal();<br>
>> +// Part of HandleDeadlySignal, exposed for asan.<br>
>> void ReportDeadlySignal(const SignalContext &sig, u32 tid,<br>
>> UnwindSignalStackCallbackType unwind,<br>
>> const void *unwind_context);<br>
>> +<br>
>> // Alternative signal stack (POSIX-only).<br>
>> void SetAlternateSignalStack();<br>
>> void UnsetAlternateSignalStack();<br>
>><br>
>> Modified:<br>
>> compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common_libcdep.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_common_libcdep.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common_libcdep.cc?rev=314041&<wbr>r1=314040&r2=314041&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common_libcdep.cc<br>
>> (original)<br>
>> +++ compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>common_libcdep.cc Fri<br>
>> Sep 22 15:57:48 2017<br>
>> @@ -254,6 +254,18 @@ void ReportDeadlySignal(const SignalCont<br>
>> else<br>
>> ReportDeadlySignalImpl(sig, tid, unwind, unwind_context);<br>
>> }<br>
>> +<br>
>> +void HandleDeadlySignal(void *siginfo, void *context, u32 tid,<br>
>> + UnwindSignalStackCallbackType unwind,<br>
>> + const void *unwind_context) {<br>
>> + StartReportDeadlySignal();<br>
>> + ScopedErrorReportLock rl;<br>
>> + SignalContext sig(siginfo, context);<br>
>> + ReportDeadlySignal(sig, tid, unwind, unwind_context);<br>
>> + Report("ABORTING\n");<br>
>> + Die();<br>
>> +}<br>
>> +<br>
>> #endif // !SANITIZER_FUCHSIA && !SANITIZER_GO<br>
>><br>
>> void WriteToSyslog(const char *msg) {<br>
>><br>
>> Modified:<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/allow_user_segv.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/allow_user_segv.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/sanitizer_common/<wbr>TestCases/Linux/allow_user_<wbr>segv.cc?rev=314041&r1=314040&<wbr>r2=314041&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> ---<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/allow_user_segv.cc<br>
>> (original)<br>
>> +++<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/allow_user_segv.cc<br>
>> Fri Sep 22 15:57:48 2017<br>
>> @@ -18,7 +18,6 @@<br>
>> // clang-format on<br>
>><br>
>> // Remove when fixed: <a href="https://github.com/google/sanitizers/issues/637" target="_blank">
https://github.com/google/<wbr>sanitizers/issues/637</a><br>
>> -// XFAIL: lsan<br>
>> // XFAIL: msan<br>
>> // XFAIL: tsan<br>
>> // XFAIL: ubsan<br>
>><br>
>> Modified:<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/assert.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/assert.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/sanitizer_common/<wbr>TestCases/Linux/assert.cc?rev=<wbr>314041&r1=314040&r2=314041&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/assert.cc<br>
>> (original)<br>
>> +++ compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/assert.cc Fri<br>
>> Sep 22 15:57:48 2017<br>
>> @@ -7,11 +7,11 @@<br>
>> // RUN: %env_tool_opts=handle_abort=1 not %run %t 2>&1 |<br>
>> FileCheck --check-prefix=CHECK1 %s<br>
>> // clang-format on<br>
>><br>
>> -// FIXME: implement in other sanitizers, not just asan.<br>
>> +// FIXME: implement in other sanitizers.<br>
>> // XFAIL: msan<br>
>> -// XFAIL: lsan<br>
>> // XFAIL: tsan<br>
>> // XFAIL: ubsan<br>
>> +<br>
>> #include <assert.h><br>
>> #include <stdio.h><br>
>> #include <sanitizer/asan_interface.h><br>
>><br>
>> Modified: compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/ill.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/ill.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/sanitizer_common/<wbr>TestCases/Linux/ill.cc?rev=<wbr>314041&r1=314040&r2=314041&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/ill.cc<br>
>> (original)<br>
>> +++ compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/ill.cc Fri Sep<br>
>> 22 15:57:48 2017<br>
>> @@ -7,9 +7,8 @@<br>
>> // RUN: %env_tool_opts=handle_sigill=1 not %run %t 2>&1 |<br>
>> FileCheck --check-prefix=CHECK1 %s<br>
>> // clang-format on<br>
>><br>
>> -// FIXME: implement in other sanitizers, not just asan.<br>
>> +// FIXME: implement in other sanitizers.<br>
>> // XFAIL: msan<br>
>> -// XFAIL: lsan<br>
>> // XFAIL: tsan<br>
>> // XFAIL: ubsan<br>
>> //<br>
>><br>
>> Modified:<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/dedup_token_length_test.<wbr>cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/dedup_token_length_test.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/sanitizer_common/<wbr>TestCases/Posix/dedup_token_<wbr>length_test.cc?rev=314041&r1=<wbr>314040&r2=314041&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> ---<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/dedup_token_length_test.<wbr>cc<br>
>> (original)<br>
>> +++<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/dedup_token_length_test.<wbr>cc<br>
>> Fri Sep 22 15:57:48 2017<br>
>> @@ -9,7 +9,6 @@<br>
>> // REQUIRES: stable-runtime<br>
>> // FIXME: implement SEGV handler in other sanitizers, not just asan.<br>
>> // XFAIL: msan<br>
>> -// XFAIL: lsan<br>
>> // XFAIL: tsan<br>
>> // XFAIL: ubsan<br>
>><br>
>><br>
>> Modified:<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/dump_instruction_bytes.<wbr>cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/dump_instruction_bytes.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/sanitizer_common/<wbr>TestCases/Posix/dump_<wbr>instruction_bytes.cc?rev=<wbr>314041&r1=314040&r2=314041&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> ---<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/dump_instruction_bytes.<wbr>cc<br>
>> (original)<br>
>> +++<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/dump_instruction_bytes.<wbr>cc<br>
>> Fri Sep 22 15:57:48 2017<br>
>> @@ -8,7 +8,10 @@<br>
>> // clang-format on<br>
>><br>
>> // REQUIRES: x86-target-arch<br>
>> -// XFAIL: lsan, msan, tsan, ubsan<br>
>> +// FIXME: implement in other sanitizers.<br>
>> +// XFAIL: msan<br>
>> +// XFAIL: tsan<br>
>> +// XFAIL: ubsan<br>
>><br>
>> int main() {<br>
>> #if defined(__x86_64__)<br>
>><br>
>> Modified: compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/fpe.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/fpe.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/sanitizer_common/<wbr>TestCases/Posix/fpe.cc?rev=<wbr>314041&r1=314040&r2=314041&<wbr>view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/fpe.cc<br>
>> (original)<br>
>> +++ compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/fpe.cc Fri Sep<br>
>> 22 15:57:48 2017<br>
>> @@ -5,7 +5,6 @@<br>
>> // RUN: %env_tool_opts=handle_sigfpe=1 not %run %t 2>&1 |<br>
>> FileCheck --check-prefix=CHECK1 %s<br>
>> // FIXME: implement in other sanitizers, not just asan.<br>
>> // XFAIL: msan<br>
>> -// XFAIL: lsan<br>
>> // XFAIL: tsan<br>
>> // XFAIL: ubsan<br>
>> //<br>
>><br>
>> Modified:<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/sanitizer_set_report_fd_<wbr>test.cc<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Posix/sanitizer_set_report_fd_test.cc?rev=314041&r1=314040&r2=314041&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/sanitizer_common/<wbr>TestCases/Posix/sanitizer_set_<wbr>report_fd_test.cc?rev=314041&<wbr>r1=314040&r2=314041&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> ---<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/sanitizer_set_report_fd_<wbr>test.cc<br>
>> (original)<br>
>> +++<br>
>> compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Posix/sanitizer_set_report_fd_<wbr>test.cc<br>
>> Fri Sep 22 15:57:48 2017<br>
>> @@ -8,7 +8,6 @@<br>
>> // XFAIL: android && i386-target-arch && asan<br>
>> // FIXME: implement SEGV handler in other sanitizers, not just asan.<br>
>> // XFAIL: msan<br>
>> -// XFAIL: lsan<br>
>> // XFAIL: tsan<br>
>> // XFAIL: ubsan<br>
>><br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">
http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
><br>
><br>
><br>
> ______________________________<wbr>_________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" target="_blank">
http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
><u></u><u></u></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div>