<div dir="ltr">Done in r314182, thanks for the feedback </div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Sep 26, 2017 at 2:01 PM, Friedman, Eli <span dir="ltr"><<a href="mailto:efriedma@codeaurora.org" target="_blank">efriedma@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 9/25/2017 5:51 PM, Dylan McKay via llvm-commits wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: dylanmckay<br>
Date: Mon Sep 25 17:51:03 2017<br>
New Revision: 314180<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314180&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=314180&view=rev</a><br>
Log:<br>
[AVR] When lowering shifts into loops, put newly generated MBBs in the same<br>
spot as the original MBB<br>
<br>
Discovered in avr-rust/rust#62<br>
<a href="https://github.com/avr-rust/rust/issues/62" rel="noreferrer" target="_blank">https://github.com/avr-rust/ru<wbr>st/issues/62</a><br>
<br>
Patch by Gergo Erdi.<br>
<br>
Modified:<br>
     llvm/trunk/lib/Target/AVR/AVR<wbr>ISelLowering.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/AVR/AVRI<wbr>SelLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AVR/AVRISelLowering.cpp?rev=314180&r1=314179&r2=314180&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-pr<wbr>oject/llvm/trunk/lib/Target/AV<wbr>R/AVRISelLowering.cpp?rev=3141<wbr>80&r1=314179&r2=314180&view=<wbr>diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/AVR/AVRI<wbr>SelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/AVR/AVRI<wbr>SelLowering.cpp Mon Sep 25 17:51:03 2017<br>
@@ -1469,8 +1469,10 @@ MachineBasicBlock *AVRTargetLowering::in<br>
    }<br>
      const BasicBlock *LLVM_BB = BB->getBasicBlock();<br>
-  MachineFunction::iterator I = BB->getParent()->begin();<br>
-  ++I;<br>
+<br>
+  MachineFunction::iterator I;<br>
+  for (I = F->begin(); I != F->end() && &(*I) != BB; ++I);<br>
+  if (I != F->end()) ++I;<br>
  <br>
</blockquote>
<br></div></div>
You can convert a MachineBasicBlock* to a MachineFunction::iterator by calling "BB->getIterator()".<span class="HOEnZb"><font color="#888888"><br>
<br>
-Eli<br>
<br>
-- <br>
Employee of Qualcomm Innovation Center, Inc.<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project<br>
<br>
</font></span></blockquote></div><br></div>