<div dir="ltr">Ping</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Sep 18, 2017 at 11:30 AM David Blaikie via Phabricator via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">dblaikie added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/trunk/tools/llvm-objdump/MachODump.cpp:5884<br>
     outs() << "\n";<br>
+    xar_iter_free(xp);<br>
   }<br>
----------------<br>
Any chance of an RAII API for this resource, to avoid the accident-prone manual cleanup/free?<br>
<br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D37750" rel="noreferrer" target="_blank">https://reviews.llvm.org/D37750</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>