<div dir="ltr">Hello Pranav,<br><br>It looks like this commit broke one of our builders:<br><a href="http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/5037">http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/5037</a><br><br>Please have a look?<br><br>Thanks<br><br>Galina<br><br>. . . <br>Failing Tests (1):<br> LLVM :: CodeGen/Hexagon/hexagon_vector_loop_carried_reuse_constant.ll<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 22, 2017 at 9:43 AM, Pranav Bhandarkar via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: pranavb<br>
Date: Fri Sep 22 09:43:31 2017<br>
New Revision: 313993<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=313993&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=313993&view=rev</a><br>
Log:<br>
Check vector elements for equivalence in the HexagonVectorLoopCarriedReuse pass<br>
<br>
If the two instructions being compared for equivalence have corresponding operands<br>
that are integer constants, then check their values to determine equivalence.<br>
<br>
Patch by Suyog Sarda!<br>
<br>
<br>
Added:<br>
llvm/trunk/test/CodeGen/<wbr>Hexagon/hexagon_vector_loop_<wbr>carried_reuse_constant.ll<br>
Modified:<br>
llvm/trunk/lib/Target/Hexagon/<wbr>HexagonVectorLoopCarriedReuse.<wbr>cpp<br>
<br>
Modified: llvm/trunk/lib/Target/Hexagon/<wbr>HexagonVectorLoopCarriedReuse.<wbr>cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonVectorLoopCarriedReuse.cpp?rev=313993&r1=313992&r2=313993&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/Target/<wbr>Hexagon/<wbr>HexagonVectorLoopCarriedReuse.<wbr>cpp?rev=313993&r1=313992&r2=<wbr>313993&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Target/Hexagon/<wbr>HexagonVectorLoopCarriedReuse.<wbr>cpp (original)<br>
+++ llvm/trunk/lib/Target/Hexagon/<wbr>HexagonVectorLoopCarriedReuse.<wbr>cpp Fri Sep 22 09:43:31 2017<br>
@@ -302,6 +302,21 @@ bool HexagonVectorLoopCarriedReuse:<wbr>:isEq<br>
return false;<br>
}<br>
}<br>
+<br>
+ // If both the Instructions are of Vector Type and any of the element<br>
+ // is integer constant, check their values too for equivalence.<br>
+ if (I1->getType()->isVectorTy() && I2->getType()->isVectorTy()) {<br>
+ unsigned NumOperands = I1->getNumOperands();<br>
+ for (unsigned i = 0; i < NumOperands; ++i) {<br>
+ ConstantInt *C1 = dyn_cast<ConstantInt>(I1-><wbr>getOperand(i));<br>
+ ConstantInt *C2 = dyn_cast<ConstantInt>(I2-><wbr>getOperand(i));<br>
+ if(!C1) continue;<br>
+ assert(C2);<br>
+ if (C1->getSExtValue() != C2->getSExtValue())<br>
+ return false;<br>
+ }<br>
+ }<br>
+<br>
return true;<br>
}<br>
<br>
<br>
Added: llvm/trunk/test/CodeGen/<wbr>Hexagon/hexagon_vector_loop_<wbr>carried_reuse_constant.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Hexagon/hexagon_vector_loop_carried_reuse_constant.ll?rev=313993&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/test/<wbr>CodeGen/Hexagon/hexagon_<wbr>vector_loop_carried_reuse_<wbr>constant.ll?rev=313993&view=<wbr>auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/test/CodeGen/<wbr>Hexagon/hexagon_vector_loop_<wbr>carried_reuse_constant.ll (added)<br>
+++ llvm/trunk/test/CodeGen/<wbr>Hexagon/hexagon_vector_loop_<wbr>carried_reuse_constant.ll Fri Sep 22 09:43:31 2017<br>
@@ -0,0 +1,86 @@<br>
+; RUN: opt < %s -hexagon-vlcr -adce -S | FileCheck %s<br>
+<br>
+; CHECK-NOT: %.hexagon.vlcr<br>
+; ModuleID = 'hexagon_vector_loop_carried_<wbr>reuse.c'<br>
+source_filename = "hexagon_vector_loop_carried_<wbr>reuse.c"<br>
+target datalayout = "e-m:e-p:32:32:32-a:0-n16:32-<wbr>i64:64:64-i32:32:32-i16:16:16-<wbr>i1:8:8-f32:32:32-f64:64:64-<wbr>v32:32:32-v64:64:64-v512:512:<wbr>512-v1024:1024:1024-v2048:<wbr>2048:2048"<br>
+target triple = "hexagon"<br>
+<br>
+@W = external local_unnamed_addr global i32, align 4<br>
+<br>
+; Function Attrs: nounwind<br>
+define void @foo(i8* noalias nocapture readonly %src, i8* noalias nocapture %dst, i32 %stride) local_unnamed_addr #0 {<br>
+entry:<br>
+ %add.ptr = getelementptr inbounds i8, i8* %src, i32 %stride<br>
+ %mul = mul nsw i32 %stride, 2<br>
+ %add.ptr1 = getelementptr inbounds i8, i8* %src, i32 %mul<br>
+ %0 = load i32, i32* @W, align 4, !tbaa !1<br>
+ %cmp55 = icmp sgt i32 %0, 0<br>
+ br i1 %cmp55, label %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a>, label %for.end<br>
+<br>
+<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a>: ; preds = %entry<br>
+ %1 = bitcast i8* %add.ptr1 to <32 x i32>*<br>
+ %2 = load <32 x i32>, <32 x i32>* %1, align 128, !tbaa !5<br>
+ %incdec.ptr4 = getelementptr inbounds i8, i8* %add.ptr1, i32 128<br>
+ %3 = bitcast i8* %incdec.ptr4 to <32 x i32>*<br>
+ %4 = bitcast i8* %add.ptr to <32 x i32>*<br>
+ %5 = load <32 x i32>, <32 x i32>* %4, align 128, !tbaa !5<br>
+ %incdec.ptr2 = getelementptr inbounds i8, i8* %add.ptr, i32 128<br>
+ %6 = bitcast i8* %incdec.ptr2 to <32 x i32>*<br>
+ %7 = bitcast i8* %src to <32 x i32>*<br>
+ %8 = load <32 x i32>, <32 x i32>* %7, align 128, !tbaa !5<br>
+ %incdec.ptr = getelementptr inbounds i8, i8* %src, i32 128<br>
+ %9 = bitcast i8* %incdec.ptr to <32 x i32>*<br>
+ %10 = bitcast i8* %dst to <32 x i32>*<br>
+ br label %for.body<br>
+<br>
+for.body: ; preds = %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a>, %for.body<br>
+ %out.063 = phi <32 x i32>* [ %10, %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a> ], [ %incdec.ptr18, %for.body ]<br>
+ %p2.062 = phi <32 x i32>* [ %3, %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a> ], [ %incdec.ptr10, %for.body ]<br>
+ %p1.061 = phi <32 x i32>* [ %6, %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a> ], [ %incdec.ptr8, %for.body ]<br>
+ %p0.060 = phi <32 x i32>* [ %9, %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a> ], [ %incdec.ptr6, %for.body ]<br>
+ %i.059 = phi i32 [ 0, %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a> ], [ %add, %for.body ]<br>
+ %a.sroa.0.058 = phi <32 x i32> [ %8, %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a> ], [ %11, %for.body ]<br>
+ %b.sroa.0.057 = phi <32 x i32> [ %5, %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a> ], [ %12, %for.body ]<br>
+ %c.sroa.0.056 = phi <32 x i32> [ %2, %<a href="http://for.body.lr.ph" rel="noreferrer" target="_blank">for.body.lr.ph</a> ], [ %13, %for.body ]<br>
+ %incdec.ptr6 = getelementptr inbounds <32 x i32>, <32 x i32>* %p0.060, i32 1<br>
+ %11 = load <32 x i32>, <32 x i32>* %p0.060, align 128, !tbaa !5<br>
+ %incdec.ptr8 = getelementptr inbounds <32 x i32>, <32 x i32>* %p1.061, i32 1<br>
+ %12 = load <32 x i32>, <32 x i32>* %p1.061, align 128, !tbaa !5<br>
+ %incdec.ptr10 = getelementptr inbounds <32 x i32>, <32 x i32>* %p2.062, i32 1<br>
+ %13 = load <32 x i32>, <32 x i32>* %p2.062, align 128, !tbaa !5<br>
+ %14 = tail call <32 x i32> @llvm.hexagon.V6.valignbi.<wbr>128B(<32 x i32> %a.sroa.0.058, <32 x i32> %b.sroa.0.057, i32 4)<br>
+ %15 = tail call <32 x i32> @llvm.hexagon.V6.vmaxub.128B(<<wbr>32 x i32> %14, <32 x i32> %c.sroa.0.056)<br>
+ %16 = tail call <32 x i32> @llvm.hexagon.V6.valignbi.<wbr>128B(<32 x i32> %11, <32 x i32> %12, i32 5)<br>
+ %17 = tail call <32 x i32> @llvm.hexagon.V6.vmaxub.128B(<<wbr>32 x i32> %16, <32 x i32> %13)<br>
+ %18 = tail call <32 x i32> @llvm.hexagon.V6.valignbi.<wbr>128B(<32 x i32> %17, <32 x i32> %15, i32 1)<br>
+ %incdec.ptr18 = getelementptr inbounds <32 x i32>, <32 x i32>* %out.063, i32 1<br>
+ store <32 x i32> %18, <32 x i32>* %out.063, align 128, !tbaa !5<br>
+ %add = add nuw nsw i32 %i.059, 128<br>
+ %cmp = icmp slt i32 %add, %0<br>
+ br i1 %cmp, label %for.body, label %for.end.loopexit<br>
+<br>
+for.end.loopexit: ; preds = %for.body<br>
+ br label %for.end<br>
+<br>
+for.end: ; preds = %for.end.loopexit, %entry<br>
+ ret void<br>
+}<br>
+<br>
+; Function Attrs: nounwind readnone<br>
+declare <32 x i32> @llvm.hexagon.V6.vmaxub.128B(<<wbr>32 x i32>, <32 x i32>) #1<br>
+<br>
+; Function Attrs: nounwind readnone<br>
+declare <32 x i32> @llvm.hexagon.V6.valignbi.<wbr>128B(<32 x i32>, <32 x i32>, i32) #1<br>
+<br>
+attributes #0 = { nounwind "correctly-rounded-divide-<wbr>sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-<wbr>leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="<wbr>false" "no-trapping-math"="false" "stack-protector-buffer-size"=<wbr>"8" "target-cpu"="hexagonv60" "target-features"="+hvx,+hvx-<wbr>double,-long-calls" "unsafe-fp-math"="false" "use-soft-float"="false" }<br>
+attributes #1 = { nounwind readnone }<br>
+<br>
+!llvm.ident = !{!0}<br>
+<br>
+!0 = !{!"QuIC LLVM Hexagon Clang version hexagon-clang-82-2622 (based on LLVM 5.0.0)"}<br>
+!1 = !{!2, !2, i64 0}<br>
+!2 = !{!"int", !3, i64 0}<br>
+!3 = !{!"omnipotent char", !4, i64 0}<br>
+!4 = !{!"Simple C/C++ TBAA"}<br>
+!5 = !{!3, !3, i64 0}<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>