<div dir="ltr">+1<br></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Sep 25, 2017 at 8:45 AM Benjamin Kramer via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This now fails again with reverse iteration order. Why do we have test<br>
coverage for iteration order but not for the behavior you depend on<br>
here?<br>
<br>
On Wed, Sep 20, 2017 at 2:07 AM, Daniel Berlin via llvm-commits<br>
<<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br>
> Author: dannyb<br>
> Date: Tue Sep 19 17:07:25 2017<br>
> New Revision: 313701<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=313701&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=313701&view=rev</a><br>
> Log:<br>
> Revert "[GVNSink] Remove dependency on SmallPtrSet iteration order."<br>
><br>
> This reverts commit r312156, because now the op and block arrays are not in the same order :(.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp<br>
><br>
> Modified: llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp?rev=313701&r1=313700&r2=313701&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp?rev=313701&r1=313700&r2=313701&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp Tue Sep 19 17:07:25 2017<br>
> @@ -229,14 +229,12 @@ public:<br>
>    ModelledPHI(const VArray &V, const BArray &B) {<br>
>      std::copy(V.begin(), V.end(), std::back_inserter(Values));<br>
>      std::copy(B.begin(), B.end(), std::back_inserter(Blocks));<br>
> -    std::sort(Blocks.begin(), Blocks.end());<br>
>    }<br>
><br>
>    /// Create a PHI from [I[OpNum] for I in Insts].<br>
>    template <typename BArray><br>
>    ModelledPHI(ArrayRef<Instruction *> Insts, unsigned OpNum, const BArray &B) {<br>
>      std::copy(B.begin(), B.end(), std::back_inserter(Blocks));<br>
> -    std::sort(Blocks.begin(), Blocks.end());<br>
>      for (auto *I : Insts)<br>
>        Values.push_back(I->getOperand(OpNum));<br>
>    }<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>