<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">To further explain the rationale: While this may seem like overkill for a utility like dwarfdump (though even there it is useful when e.g., loading dSYMs over NFS), the end goal for lib/DebugInfo is to be good enough to be used by LLDB, and LLDB has a strong requirement for lazy parsing.<div class=""><br class=""></div><div class="">-- adrian<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Sep 25, 2017, at 9:37 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">+1 - I'm not sure there is a way. But worth checking/considering it.<br class=""><br class="">I think the issue, at least pre DWARF5 maybe (hopefully it's been fixed? I know a few efforts have been made to make things more independently parsed), is that you can't parse the line table without the CU, and you don't know which CU this line table is for - so you have to walk all the CUs... - but worth checking.</div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Mon, Sep 25, 2017 at 9:16 AM Adrian Prantl via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="">reviews@reviews.llvm.org</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">aprantl accepted this revision.<br class="">
aprantl added a comment.<br class="">
<br class="">
Without having checked out API yet — this is still traversing over all CUs to find the one with the entry. This could be slow for something like clang.dSYM. Is there a way to find the one CU containing the entry quicker? If not, this LGTM.<br class="">
<br class="">
<br class="">
Repository:<br class="">
rL LLVM<br class="">
<br class="">
<a href="https://reviews.llvm.org/D38240" rel="noreferrer" target="_blank" class="">https://reviews.llvm.org/D38240</a><br class="">
<br class="">
<br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>