<div dir="ltr">Yeah. Now I see why original mmap approach could be better.<div>Still I don't see this as a big issue. So up you, to fix same way or return back to dynamic allocations.</div><div><br></div><div><br></div><div>Also real problem here that platforms which do not care about <span style="font-size:12.8px">MemoryMappingLayoutData need to include header for other purpose.<br></span><span style="font-size:12.8px">So maybe move GetMemoryProfile into common. </span><span style="font-size:12.8px">Then </span><span style="font-size:12.8px">guard entire sanitizer_procmaps.h with SANITIZER_POSIX, a</span><span style="font-size:12.8px">nd now win and fuchsia will not need that header and </span><span style="font-size:12.8px">MemoryMappingLayoutData </span><span style="font-size:12.8px">at all.</span></div><div><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 22, 2017 at 11:38 AM, Francis Ricci <span dir="ltr"><<a href="mailto:francisjricci@gmail.com" target="_blank" class="gmail-cremed cremed">francisjricci@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">I could fix that the same way I fixed windows, but that starts to look<br>
a bit hacky. What do you think? (We could also revert and try to<br>
figure something else out)<br>
<div class="gmail-m_3115211823351044627HOEnZb"><div class="gmail-m_3115211823351044627h5"><br>
On Fri, Sep 22, 2017 at 2:34 PM, Vitaly Buka <<a href="mailto:vitalybuka@google.com" target="_blank" class="gmail-cremed cremed">vitalybuka@google.com</a>> wrote:<br>
> I suspect Fuchsia is still broken<br>
><br>
> On Fri, Sep 22, 2017 at 11:17 AM, Francis Ricci via llvm-commits<br>
> <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="gmail-cremed cremed">llvm-commits@lists.llvm.org</a>> wrote:<br>
>><br>
>> Author: fjricci<br>
>> Date: Fri Sep 22 11:17:26 2017<br>
>> New Revision: 314001<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=314001&view=rev" rel="noreferrer" target="_blank" class="gmail-cremed cremed">http://llvm.org/viewvc/llvm-pr<wbr>oject?rev=314001&view=rev</a><br>
>> Log:<br>
>> Fix windows buildbot broken by r313999<br>
>><br>
>> Modified:<br>
>>     compiler-rt/trunk/lib/sanitiz<wbr>er_common/sanitizer_procmaps.h<br>
>>     compiler-rt/trunk/lib/sanitiz<wbr>er_common/sanitizer_win.h<br>
>><br>
>> Modified: compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_procmaps.h<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_procmaps.h?rev=314001&r1=314000&r2=314001&view=diff" rel="noreferrer" target="_blank" class="gmail-cremed cremed">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/lib/sa<wbr>nitizer_common/sanitizer_procm<wbr>aps.h?rev=314001&r1=314000&r2=<wbr>314001&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_procmaps.h (original)<br>
>> +++ compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_procmaps.h Fri Sep 22<br>
>> 11:17:26 2017<br>
>> @@ -19,6 +19,7 @@<br>
>>  #include "sanitizer_linux.h"<br>
>>  #include "sanitizer_mac.h"<br>
>>  #include "sanitizer_mutex.h"<br>
>> +#include "sanitizer_win.h"<br>
>><br>
>>  namespace __sanitizer {<br>
>><br>
>><br>
>> Modified: compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_win.h<br>
>> URL:<br>
>> <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.h?rev=314001&r1=314000&r2=314001&view=diff" rel="noreferrer" target="_blank" class="gmail-cremed cremed">http://llvm.org/viewvc/llvm-pr<wbr>oject/compiler-rt/trunk/lib/sa<wbr>nitizer_common/sanitizer_win.<wbr>h?rev=314001&r1=314000&r2=3140<wbr>01&view=diff</a><br>
>><br>
>> ==============================<wbr>==============================<wbr>==================<br>
>> --- compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_win.h (original)<br>
>> +++ compiler-rt/trunk/lib/sanitize<wbr>r_common/sanitizer_win.h Fri Sep 22<br>
>> 11:17:26 2017<br>
>> @@ -20,6 +20,7 @@<br>
>>  namespace __sanitizer {<br>
>>  // Check based on flags if we should handle the exception.<br>
>>  bool IsHandledDeadlyException(DWORD exceptionCode);<br>
>> +struct MemoryMappingLayoutData {};<br>
>>  }  // namespace __sanitizer<br>
>><br>
>>  #endif  // SANITIZER_WINDOWS<br>
>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@lists.llvm.org" target="_blank" class="gmail-cremed cremed">llvm-commits@lists.llvm.org</a><br>
>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="gmail-cremed cremed">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
><br>
><br>
</div></div></blockquote></div><br></div></div>