<div dir="ltr">Interesting. I think we can do better here by improving the diagnostics and fallback handling, but it doesn't seem critical, so I can do it later.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 20, 2017 at 6:58 PM David Jones <<a href="mailto:dlj@google.com">dlj@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">This fixes the issue that I found... the programs were elsewhere on the system PATH... it just so happened that cmp.exe was somewhere other than the explicit lit tools directory. (It was installed by Chocolatey, but grep was from a gnuwin32 distribution, both of which are, in fact, in the system path.)</div><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 20, 2017 at 6:31 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" class="m_-5969718651933282345m_-4201392172042259966cremed m_-5969718651933282345cremed" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Does this actually fix the bots? I'm concerned they'll fail anyway as a result of not finding the tools<div class="m_-5969718651933282345m_-4201392172042259966m_6016417036548448244HOEnZb"><div class="m_-5969718651933282345m_-4201392172042259966m_6016417036548448244h5"><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 20, 2017 at 6:27 PM David L. Jones via Phabricator <<a href="mailto:reviews@reviews.llvm.org" class="m_-5969718651933282345m_-4201392172042259966cremed m_-5969718651933282345cremed" target="_blank">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This revision was automatically updated to reflect the committed changes.<br>
Closed by commit rL313854: [lit/Win] Check if a path was found before attempting to use it. (authored by dlj).<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a href="https://reviews.llvm.org/D38115" rel="noreferrer" class="m_-5969718651933282345m_-4201392172042259966cremed m_-5969718651933282345cremed" target="_blank">https://reviews.llvm.org/D38115</a><br>
<br>
Files:<br>
llvm/trunk/utils/lit/lit/llvm/config.py<br>
<br>
<br>
Index: llvm/trunk/utils/lit/lit/llvm/config.py<br>
===================================================================<br>
--- llvm/trunk/utils/lit/lit/llvm/config.py<br>
+++ llvm/trunk/utils/lit/lit/llvm/config.py<br>
@@ -27,7 +27,8 @@<br>
path = self.lit_config.getToolsPath(config.lit_tools_dir,<br>
config.environment['PATH'],<br>
['cmp.exe', 'grep.exe', 'sed.exe'])<br>
- self.with_environment('PATH', path, append_path=True)<br>
+ if path is not None:<br>
+ self.with_environment('PATH', path, append_path=True)<br>
self.use_lit_shell = True<br>
<br>
# Choose between lit's internal shell pipeline runner and a real shell. If<br>
<br>
<br>
</blockquote></div>
</div></div></blockquote></div><br></div></div></blockquote></div>