<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">If we don't merge it we will have to accept that the clang-5.0 bots have one test failure. This might be acceptable since the compiler release will also have this as a known bug?<div class=""><br class=""></div><div class="">-- adrian<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Sep 21, 2017, at 2:10 PM, Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">I think I may have introduced a debug info availability regression in that change. It should be fixed with <a href="https://reviews.llvm.org/D37932" class="">https://reviews.llvm.org/D37932</a>.<div class=""><br class=""></div><div class="">I'm not sure we should merge to 5.0.1. There might be dependent changes that aren't on the release_50 branch.</div></div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Thu, Sep 21, 2017 at 10:16 AM, Adrian Prantl <span dir="ltr" class=""><<a href="mailto:aprantl@apple.com" target="_blank" class="">aprantl@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It looks like the commits 313775 + 313786 should address this now.<br class="">
Reid, can you confirm?<br class="">
<br class="">
Could we get them cherry-picked to 5.0 and un-revert the debuginfo-test?<br class="">
<span class="HOEnZb"><font color="#888888" class=""><br class="">
-- adrian<br class="">
</font></span><div class="HOEnZb"><div class="h5"><br class="">
> On Sep 18, 2017, at 4:56 PM, Hans Wennborg <<a href="mailto:hans@chromium.org" class="">hans@chromium.org</a>> wrote:<br class="">
><br class="">
> I've removed the -O1 case from this test in r313600 until r313400 gets<br class="">
> fixed again.<br class="">
><br class="">
> On Mon, Sep 18, 2017 at 4:12 PM, Hans Wennborg <<a href="mailto:hans@chromium.org" class="">hans@chromium.org</a>> wrote:<br class="">
>> +Tom for 5.0.1.<br class="">
>><br class="">
>> r313400 was just reverted though, so we'd need to merge it when it relands.<br class="">
>><br class="">
>> On Sat, Sep 16, 2017 at 9:23 AM, Adrian Prantl <<a href="mailto:aprantl@apple.com" class="">aprantl@apple.com</a>> wrote:<br class="">
>>> This new test is (expectedly) failing on the clang-5.0 release branch and we<br class="">
>>> don't branch the debuginfo-tests repository.<br class="">
>>><br class="">
>>> <a href="http://green.lab.llvm.org/green/job/clang-stage1-configure-RA-release-5/83/" rel="noreferrer" target="_blank" class="">http://green.lab.llvm.org/<wbr class="">green/job/clang-stage1-<wbr class="">configure-RA-release-5/83/</a><br class="">
>>><br class="">
>>> Since this fixes a regression clang-5.0, I hereby nominate r313400 and<br class="">
>>> r313399 for clang-5.0.1 if such a thing exists.<br class="">
>>><br class="">
>>> -- adrian<br class="">
>>><br class="">
>>><br class="">
>>><br class="">
>>> On Sep 15, 2017, at 2:59 PM, Reid Kleckner via llvm-commits<br class="">
>>> <<a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a>> wrote:<br class="">
>>><br class="">
>>> Author: rnk<br class="">
>>> Date: Fri Sep 15 14:59:39 2017<br class="">
>>> New Revision: 313401<br class="">
>>><br class="">
>>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=313401&view=rev" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project?rev=313401&view=rev</a><br class="">
>>> Log:<br class="">
>>> [debuginfo-tests] Add string NRVO test for PR34513<br class="">
>>><br class="">
>>> It should pass in -O0 and -O1 after r313400 and r313399.<br class="">
>>><br class="">
>>> Added:<br class="">
>>> debuginfo-tests/trunk/nrvo-<wbr class="">string.cpp<br class="">
>>><br class="">
>>> Added: debuginfo-tests/trunk/nrvo-<wbr class="">string.cpp<br class="">
>>> URL:<br class="">
>>> <a href="http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/nrvo-string.cpp?rev=313401&view=auto" rel="noreferrer" target="_blank" class="">http://llvm.org/viewvc/llvm-<wbr class="">project/debuginfo-tests/trunk/<wbr class="">nrvo-string.cpp?rev=313401&<wbr class="">view=auto</a><br class="">
>>> ==============================<wbr class="">==============================<wbr class="">==================<br class="">
>>> --- debuginfo-tests/trunk/nrvo-<wbr class="">string.cpp (added)<br class="">
>>> +++ debuginfo-tests/trunk/nrvo-<wbr class="">string.cpp Fri Sep 15 14:59:39 2017<br class="">
>>> @@ -0,0 +1,27 @@<br class="">
>>> +// This ensures that DW_OP_deref is inserted when necessary, such as when<br class="">
>>> NRVO<br class="">
>>> +// of a string object occurs in C++.<br class="">
>>> +//<br class="">
>>> +// RUN: %clangxx -O0 -fno-exceptions %target_itanium_abi_host_<wbr class="">triple %s -o<br class="">
>>> %t.out -g<br class="">
>>> +// RUN: %test_debuginfo %s %t.out<br class="">
>>> +// RUN: %clangxx -O1 -fno-exceptions %target_itanium_abi_host_<wbr class="">triple %s -o<br class="">
>>> %t.out -g<br class="">
>>> +// RUN: %test_debuginfo %s %t.out<br class="">
>>> +//<br class="">
>>> +// PR34513<br class="">
>>> +<br class="">
>>> +struct string {<br class="">
>>> + string() {}<br class="">
>>> + string(int i) : i(i) {}<br class="">
>>> + ~string() {}<br class="">
>>> + int i = 0;<br class="">
>>> +};<br class="">
>>> +string get_string() {<br class="">
>>> + string unused;<br class="">
>>> + string result = 3;<br class="">
>>> +// DEBUGGER: break 21<br class="">
>>> + return result;<br class="">
>>> +}<br class="">
>>> +int main() { get_string(); }<br class="">
>>> +<br class="">
>>> +// DEBUGGER: r<br class="">
>>> +// DEBUGGER: print result.i<br class="">
>>> +// CHECK: = 3<br class="">
>>><br class="">
>>><br class="">
>>> ______________________________<wbr class="">_________________<br class="">
>>> llvm-commits mailing list<br class="">
>>> <a href="mailto:llvm-commits@lists.llvm.org" class="">llvm-commits@lists.llvm.org</a><br class="">
>>> <a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank" class="">http://lists.llvm.org/cgi-bin/<wbr class="">mailman/listinfo/llvm-commits</a><br class="">
>>><br class="">
>>><br class="">
<br class="">
</div></div></blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></body></html>