<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Ping?<br>
<br>
-Eli<br>
<br>
On 9/11/2017 10:01 AM, David Blaikie wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAENS6EtyjqVv-o2dxy841dm42R5+c-=hXuv87oaUh3f1pAfTwA@mail.gmail.com">
<div dir="ltr">Good point Eli - Ben, thoughts?</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Wed, Aug 30, 2017 at 11:54 AM Friedman, Eli
via llvm-commits <<a
href="mailto:llvm-commits@lists.llvm.org"
moz-do-not-send="true">llvm-commits@lists.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">On 8/30/2017
11:46 AM, Benjamin Kramer via llvm-commits wrote:<br>
> Author: d0k<br>
> Date: Wed Aug 30 11:46:37 2017<br>
> New Revision: 312156<br>
><br>
> URL: <a
href="http://llvm.org/viewvc/llvm-project?rev=312156&view=rev"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project?rev=312156&view=rev</a><br>
> Log:<br>
> [GVNSink] Remove dependency on SmallPtrSet iteration
order.<br>
><br>
> Found by LLVM_ENABLE_REVERSE_ITERATION.<br>
><br>
> Modified:<br>
> llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp<br>
><br>
> Modified: llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp<br>
> URL: <a
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp?rev=312156&r1=312155&r2=312156&view=diff"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp?rev=312156&r1=312155&r2=312156&view=diff</a><br>
>
==============================================================================<br>
> --- llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp
(original)<br>
> +++ llvm/trunk/lib/Transforms/Scalar/GVNSink.cpp Wed Aug
30 11:46:37 2017<br>
> @@ -229,12 +229,14 @@ public:<br>
> ModelledPHI(const VArray &V, const BArray &B)
{<br>
> std::copy(V.begin(), V.end(),
std::back_inserter(Values));<br>
> std::copy(B.begin(), B.end(),
std::back_inserter(Blocks));<br>
> + std::sort(Blocks.begin(), Blocks.end());<br>
> }<br>
><br>
<br>
Does this actually solve anything? "Blocks" is a<br>
"SmallVector<BasicBlock *, 4>", so sorting it will put
it into a<br>
non-deterministic order.<br>
<br>
-Eli<br>
<br>
--<br>
Employee of Qualcomm Innovation Center, Inc.<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora
Forum, a Linux Foundation Collaborative Project<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank"
moz-do-not-send="true">llvm-commits@lists.llvm.org</a><br>
<a
href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
</blockquote>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project</pre>
</body>
</html>