<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Sun, Sep 17, 2017 at 4:21 AM Benjamin Kramer via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Sun Sep 17 04:19:53 2017<br>
New Revision: 313482<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=313482&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=313482&view=rev</a><br>
Log:<br>
Remove uses of deprecated std::not1.<br>
<br>
Lambdas are slightly more verbose, but also more readable. No<br>
functionality change intended.<br>
<br>
Modified:<br>
    llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp<br>
<br>
Modified: llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp?rev=313482&r1=313481&r2=313482&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp?rev=313482&r1=313481&r2=313482&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp (original)<br>
+++ llvm/trunk/utils/TableGen/CodeGenDAGPatterns.cpp Sun Sep 17 04:19:53 2017<br>
@@ -147,7 +147,7 @@ template <typename Predicate><br>
 bool TypeSetByHwMode::constrain(Predicate P) {<br>
   bool Changed = false;<br>
   for (auto &I : *this)<br>
-    Changed |= berase_if(I.second, std::not1(std::ref(P)));<br>
+    Changed |= berase_if(I.second, [&P](MVT VT) { return !P(VT); });<br></blockquote><div><br>For locally used lambdas (lambdas that don't escape their scope (through type erasure in std::function, etc)) I think it's probably best to just use [&] as a rule?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   return Changed;<br>
 }<br>
<br>
@@ -436,11 +436,11 @@ bool TypeInfer::EnforceSmallerThan(TypeS<br>
     TypeSetByHwMode::SetType &B = Big.get(M);<br>
<br>
     if (any_of(S, isIntegerOrPtr) && any_of(S, isIntegerOrPtr)) {<br>
-      auto NotInt = std::not1(std::ref(isIntegerOrPtr));<br>
+      auto NotInt = [](MVT VT) { return !isIntegerOrPtr(VT); };<br>
       Changed |= berase_if(S, NotInt) |<br>
                  berase_if(B, NotInt);<br>
     } else if (any_of(S, isFloatingPoint) && any_of(B, isFloatingPoint)) {<br>
-      auto NotFP = std::not1(std::ref(isFloatingPoint));<br>
+      auto NotFP = [](MVT VT) { return !isFloatingPoint(VT); };<br>
       Changed |= berase_if(S, NotFP) |<br>
                  berase_if(B, NotFP);<br>
     } else if (S.empty() || B.empty()) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>