<div dir="ltr">This is why we should not have #ifdefs in the code. </div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Sep 17, 2017 at 2:38 AM, Ulrich Weigand via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: uweigand<br>
Date: Sun Sep 17 02:38:55 2017<br>
New Revision: 313480<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=313480&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=313480&view=rev</a><br>
Log:<br>
[compiler-rt] Fix build break after r313277 on s390x<br>
<br>
Commit r313277 moved IsStackOverflow to inside the SignalContext<br>
class, but didn't update a code block in #ifdef s390x accordingly.<br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>posix_libcdep.cc<br>
<br>
Modified: compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>posix_libcdep.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_posix_libcdep.cc?rev=313480&r1=313479&r2=313480&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>posix_libcdep.cc?rev=313480&<wbr>r1=313479&r2=313480&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>posix_libcdep.cc (original)<br>
+++ compiler-rt/trunk/lib/<wbr>sanitizer_common/sanitizer_<wbr>posix_libcdep.cc Sun Sep 17 02:38:55 2017<br>
@@ -223,7 +223,7 @@ bool SignalContext::<wbr>IsStackOverflow() co<br>
   // On s390, the fault address in siginfo points to start of the page, not<br>
   // to the precise word that was accessed.  Mask off the low bits of sp to<br>
   // take it into account.<br>
-  bool IsStackAccess = sig.addr >= (sig.sp & ~0xFFF) && sig.addr < sp + 0xFFFF;<br>
+  bool IsStackAccess = addr >= (sp & ~0xFFF) && addr < sp + 0xFFFF;<br>
 #else<br>
   bool IsStackAccess = addr + 512 > sp && addr < sp + 0xFFFF;<br>
 #endif<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>