<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" id="owaParaStyle"></style>
</head>
<body fpstyle="1" ocsi="0">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Hi Vitaly,
<div><br>
</div>
<div>I was already investigating why the patch didn't fix the mips buildbot, and spotted the potiential</div>
<div>cause of this test failure which is the <span style="font-size: 13.3333px;">"(defined(__mips64) ||.."</span> instead of <span style="font-size: 13.3333px;">"(defined(__mips64) &&.."</span></div>
<div><span style="font-size: 10pt;">which probably triggered the issue </span><span style="font-size: 10pt;">with this bot. Unfortunately, even after correcting that problem,</span></div>
<div>the test fails anyway.</div>
<div><br>
</div>
<div>http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20170911/487215.html</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Simon</div>
<div>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF53735" style="direction: ltr;"><font face="Tahoma" size="2" color="#000000"><b>From:</b> Vitaly Buka [vitalybuka@google.com]<br>
<b>Sent:</b> 14 September 2017 20:49<br>
<b>To:</b> Simon Dardis<br>
<b>Cc:</b> llvm-commits; maxim.kuvyrkov@gmail.com<br>
<b>Subject:</b> Re: [compiler-rt] r313248 - [mips] Fix sem_init_glibc test for MIPS.<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">
<div>After this path the test fails on this bot:</div>
<a href="http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/10513" target="_blank">http://lab.llvm.org:8011/<wbr>builders/clang-cmake-armv7-<wbr>a15-full/builds/10513</a><br>
<div><br>
</div>
<div>
<pre style="font-family:"Courier New",courier,monotype,monospace; color:rgb(0,0,0); font-size:medium"><span class="m_-4482729351606975059gmail-stdout">Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
FAIL: SanitizerCommon-asan-armhf-<wbr>Linux :: Linux/sem_init_glibc.cc (35440 of 35754)
******************** TEST 'SanitizerCommon-asan-armhf-<wbr>Linux :: Linux/sem_init_glibc.cc' FAILED ********************
Script:
--
/home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=address -mcpu=cortex-a15 -mfpu=vfpv3 -marm -O0 -g /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>llvm/projects/compiler-rt/<wbr>test/sanitizer_common/<wbr>TestCases/Linux/sem_init_<wbr>glibc.cc -lutil -o /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/projects/compiler-rt/<wbr>test/sanitizer_common/asan-<wbr>armhf-Linux/Linux/Output/sem_<wbr>init_glibc.cc.tmp && /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/projects/compiler-rt/<wbr>test/sanitizer_common/asan-<wbr>armhf-Linux/Linux/Output/sem_<wbr>init_glibc.cc.tmp
--
Exit Code: 134
Command Output (stderr):
--
sem_init_glibc.cc.tmp: /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>llvm/projects/compiler-rt/<wbr>test/sanitizer_common/<wbr>TestCases/Linux/sem_init_<wbr>glibc.cc:62: int main(): Assertion `GET_SEM_VALUE(a) == 43' failed.
/home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/projects/compiler-rt/<wbr>test/sanitizer_common/asan-<wbr>armhf-Linux/Linux/Output/sem_<wbr>init_glibc.cc.script: line 1: 30487 Aborted /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/projects/compiler-rt/<wbr>test/sanitizer_common/asan-<wbr>armhf-Linux/Linux/Output/sem_<wbr>init_glibc.cc.tmp
--
********************
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
FAIL: SanitizerCommon-lsan-armhf-<wbr>Linux :: Linux/sem_init_glibc.cc (35500 of 35754)
******************** TEST 'SanitizerCommon-lsan-armhf-<wbr>Linux :: Linux/sem_init_glibc.cc' FAILED ********************
Script:
--
/home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/./bin/clang --driver-mode=g++ -gline-tables-only -fsanitize=leak -mcpu=cortex-a15 -mfpu=vfpv3 -marm -O0 -g /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>llvm/projects/compiler-rt/<wbr>test/sanitizer_common/<wbr>TestCases/Linux/sem_init_<wbr>glibc.cc -lutil -o /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/projects/compiler-rt/<wbr>test/sanitizer_common/lsan-<wbr>armhf-Linux/Linux/Output/sem_<wbr>init_glibc.cc.tmp && /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/projects/compiler-rt/<wbr>test/sanitizer_common/lsan-<wbr>armhf-Linux/Linux/Output/sem_<wbr>init_glibc.cc.tmp
--
Exit Code: 134
Command Output (stderr):
--
sem_init_glibc.cc.tmp: /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>llvm/projects/compiler-rt/<wbr>test/sanitizer_common/<wbr>TestCases/Linux/sem_init_<wbr>glibc.cc:59: int main(): Assertion `b != 0xAB' failed.
/home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/projects/compiler-rt/<wbr>test/sanitizer_common/lsan-<wbr>armhf-Linux/Linux/Output/sem_<wbr>init_glibc.cc.script: line 1: 30850 Aborted /home/buildslave/buildslave/<wbr>clang-cmake-armv7-a15-full/<wbr>stage1/projects/compiler-rt/<wbr>test/sanitizer_common/lsan-<wbr>armhf-Linux/Linux/Output/sem_<wbr>init_glibc.cc.tmp
--
********************
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. </span></pre>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Thu, Sep 14, 2017 at 3:36 AM, Simon Dardis via llvm-commits
<span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
Author: sdardis<br>
Date: Thu Sep 14 03:36:04 2017<br>
New Revision: 313248<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=313248&view=rev" rel="noreferrer" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project?rev=313248&view=rev</a><br>
Log:<br>
[mips] Fix sem_init_glibc test for MIPS.<br>
<br>
glibc changed the implementation of semaphores for glibc 2.21 requiring<br>
some target specific changes for this compiler-rt test. Modify the test<br>
to cope with MIPS64 and do some future/correctness work by tying the<br>
define for MIPS64 to exactly the define of __HAVE_64B_ATOMICS in glibc.<br>
<br>
Contributions from Nitesh Jain.<br>
<br>
Reviewers: eugenis<br>
<br>
Differential Revision: <a href="https://reviews.llvm.org/D37829" rel="noreferrer" target="_blank">
https://reviews.llvm.org/<wbr>D37829</a><br>
<br>
Modified:<br>
compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/sem_init_glibc.cc<br>
<br>
Modified: compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/sem_init_glibc.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/sem_init_glibc.cc?rev=313248&r1=313247&r2=313248&view=diff" rel="noreferrer" target="_blank">
http://llvm.org/viewvc/llvm-<wbr>project/compiler-rt/trunk/<wbr>test/sanitizer_common/<wbr>TestCases/Linux/sem_init_<wbr>glibc.cc?rev=313248&r1=313247&<wbr>r2=313248&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/sem_init_glibc.cc (original)<br>
+++ compiler-rt/trunk/test/<wbr>sanitizer_common/TestCases/<wbr>Linux/sem_init_glibc.cc Thu Sep 14 03:36:04 2017<br>
@@ -13,9 +13,11 @@<br>
typedef uint64_t semval_t;<br>
<br>
// This condition needs to correspond to __HAVE_64B_ATOMICS macro in glibc.<br>
-#elif (defined(__x86_64__) || defined(__aarch64__) || defined(__powerpc64__) || \<br>
- defined(__s390x__) || defined(__sparc64__) || defined(__alpha__) || \<br>
- defined(__ia64__) || defined(__m68k__)) && __GLIBC_PREREQ(2, 21)<br>
+#elif (defined(__x86_64__) || defined(__aarch64__) || \<br>
+ defined(__powerpc64__) || defined(__s390x__) || defined(__sparc64__) || \<br>
+ defined(__alpha__) || defined(__ia64__) || defined(__m68k__) || \<br>
+ (defined(__mips64) || _MIPS_SIM == _ABI64)) && \<br>
+ __GLIBC_PREREQ(2, 21)<br>
typedef uint64_t semval_t;<br>
#else<br>
typedef unsigned semval_t;<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</body>
</html>