<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p><br>
</p>
<div class="moz-cite-prefix">On 09/11/2017 06:45 PM, Kyle Butt
wrote:<br>
</div>
<blockquote
cite="mid:CABeP02A5B2hsQp_cPdiskkukr05wL6SW7Mu_rzeK_-5wYHM2DQ@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div dir="auto">No, it failed to emit any code. The frame index
fixup code scavenges a Register to materialize the offset.
Nothing reserves an emergency spill slot for the scavenging.
Boom!
<div dir="auto"><br>
</div>
<div dir="auto">I'm thinking of adjusting the slot to be
sufficiently aligned.<br>
</div>
</div>
</blockquote>
<br>
That also seems reasonable (although the the correctness fix seems
good regardless).<br>
<br>
-Hal<br>
<br>
<blockquote
cite="mid:CABeP02A5B2hsQp_cPdiskkukr05wL6SW7Mu_rzeK_-5wYHM2DQ@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sep 9, 2017 1:46 AM, "Nemanja
Ivanovic" <<a moz-do-not-send="true"
href="mailto:nemanja.i.ibm@gmail.com">nemanja.i.ibm@gmail.com</a>>
wrote:<br type="attribution">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div>Ah, OK good. So I imagine it failed the machine
verifier.<br>
</div>
That's good - as long as we don't emit bad code :)<br>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Sat, Sep 9, 2017 at 9:54 AM,
Eric Christopher <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<p dir="ltr">It failed in the register scavenger :)</p>
<br>
<div class="gmail_quote">
<div dir="ltr">On Fri, Sep 8, 2017, 11:46 PM Nemanja
Ivanovic via Phabricator <<a
moz-do-not-send="true"
href="mailto:reviews@reviews.llvm.org"
target="_blank">reviews@reviews.llvm.org</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">nemanjai
added a comment.<br>
<br>
I imagine this patch was prompted by a bug. Just
out of curiosity, did the assert:<br>
<br>
assert(MO.isImm() && !(MO.getImm() % 16)
&&<br>
"Expecting an immediate that is a
multiple of 16");<br>
<br>
fire for the case where the frame op was lowered
to an lxv/stxv with an offset that isn't a
multiple of 16? If not, perhaps we need another
assert somewhere else?<br>
<br>
<br>
Repository:<br>
rL LLVM<br>
<br>
<a moz-do-not-send="true"
href="https://reviews.llvm.org/D37654"
rel="noreferrer" target="_blank">https://reviews.llvm.org/D3765<wbr>4</a><br>
<br>
<br>
<br>
</blockquote>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
</div>
</div>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory</pre>
</body>
</html>