<div dir="ltr">The recommended pattern is to put the llvm_unreachable after the switch:<div><br></div><div><a href="https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations">https://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations</a><br></div><div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 8, 2017 at 4:34 PM, Guozhi Wei via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: carrot<br>
Date: Fri Sep  8 16:34:28 2017<br>
New Revision: 312834<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=312834&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=312834&view=rev</a><br>
Log:<br>
[TargetTransformInfo] Remove the extra "default" in a switch that all enum values has been covered.<br>
<br>
In function TargetTransformInfo::<wbr>getInstructionCost, all enum values in the switch statement has been covered, so the default is unnecessary, and may cause error with option -Werror,-Wcovered-switch-<wbr>default, so remove it.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/<wbr>Analysis/TargetTransformInfo.h<br>
<br>
Modified: llvm/trunk/include/llvm/<wbr>Analysis/TargetTransformInfo.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/TargetTransformInfo.h?rev=312834&r1=312833&r2=312834&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/include/<wbr>llvm/Analysis/<wbr>TargetTransformInfo.h?rev=<wbr>312834&r1=312833&r2=312834&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/include/llvm/<wbr>Analysis/TargetTransformInfo.h (original)<br>
+++ llvm/trunk/include/llvm/<wbr>Analysis/TargetTransformInfo.h Fri Sep  8 16:34:28 2017<br>
@@ -141,11 +141,9 @@ public:<br>
<br>
     case TCK_CodeSize:<br>
       return getUserCost(I);<br>
-<br>
-    default:<br>
-      llvm_unreachable("Unknown instruction cost kind");<br>
-      return 0;<br>
     }<br>
+<br>
+    return 0;<br>
   }<br>
<br>
   /// \brief Underlying constants for 'cost' values in this interface.<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>