<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Aug 24, 2017 at 6:24 PM, Justin Bogner via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: bogner<br>
Date: Thu Aug 24 18:24:54 2017<br>
New Revision: 311742<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=311742&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=311742&view=rev</a><br>
Log:<br>
[sanitizer-coverage] Make sure pc-tables aren't dead stripped<br>
<br>
Add a reference to the PC array in llvm.used so that linkers that<br>
aggressively dead strip (like ld64) don't remove it.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/<wbr>Instrumentation/<wbr>SanitizerCoverage.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/<wbr>Instrumentation/<wbr>SanitizerCoverage.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/SanitizerCoverage.cpp?rev=311742&r1=311741&r2=311742&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/llvm/trunk/lib/<wbr>Transforms/Instrumentation/<wbr>SanitizerCoverage.cpp?rev=<wbr>311742&r1=311741&r2=311742&<wbr>view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- llvm/trunk/lib/Transforms/<wbr>Instrumentation/<wbr>SanitizerCoverage.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/<wbr>Instrumentation/<wbr>SanitizerCoverage.cpp Thu Aug 24 18:24:54 2017<br>
@@ -557,6 +557,10 @@ void SanitizerCoverageModule::<wbr>CreatePCAr<br>
   FunctionPCsArray-><wbr>setInitializer(<br>
       ConstantArray::get(ArrayType::<wbr>get(Int8PtrTy, N), PCs));<br>
   FunctionPCsArray->setConstant(<wbr>true);<br>
+<br>
+  // We don't reference the PCs array in any of our runtime functions, so we<br>
+  // need to prevent it from being dead stripped.<br>
+  appendToUsed(*F.getParent(), {FunctionPCsArray});<br></blockquote><div><br></div><div>Sadly, this seems to break everything. </div><div>E.g. now to build clang's tools/clang/lib/Sema/SemaExpr.cpp with -fsanitize=fuzzer it takes ~6Gb  of RAM and all time/RAM is spent here. </div><div><br></div><div>I'll try to come up with a simple repro. </div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
 }<br>
<br>
 void SanitizerCoverageModule::<wbr>CreateFunctionLocalArrays(<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>