<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 8, 2017 at 11:41 AM, Rafael Espindola via llvm-commits <span dir="ltr"><<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Fri Sep  8 11:41:49 2017<br>
New Revision: 312812<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=312812&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project?rev=312812&view=rev</a><br>
Log:<br>
Handle lazy symbols is computeIsPreemptible.<br>
<br>
Added:<br>
    lld/trunk/test/ELF/Inputs/<wbr>dynamic-list-weak-archive.s<br>
    lld/trunk/test/ELF/dynamic-<wbr>list-weak-archive.s<br>
Modified:<br>
    lld/trunk/ELF/Writer.cpp<br>
<br>
Modified: lld/trunk/ELF/Writer.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=312812&r1=312811&r2=312812&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/ELF/Writer.<wbr>cpp?rev=312812&r1=312811&r2=<wbr>312812&view=diff</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/ELF/Writer.cpp (original)<br>
+++ lld/trunk/ELF/Writer.cpp Fri Sep  8 11:41:49 2017<br>
@@ -1240,7 +1240,7 @@ static bool computeIsPreemptible(const S<br>
   // executables are automatically exported so that the runtime linker<br>
   // can try to resolve them. In that case, they are preemptible. So, we<br>
   // return true for an undefined symbols in all cases.<br>
-  if (B.isUndefined() || B.isShared())<br>
+  if (!B.isInCurrentDSO())<br>
     return true;<br></blockquote><div><br></div><div>The comment here probably needs some updating.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
   // If we have a dynamic list it specifies which local symbols are preemptible.<br>
<br>
Added: lld/trunk/test/ELF/Inputs/<wbr>dynamic-list-weak-archive.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/dynamic-list-weak-archive.s?rev=312812&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/test/ELF/<wbr>Inputs/dynamic-list-weak-<wbr>archive.s?rev=312812&view=auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/test/ELF/Inputs/<wbr>dynamic-list-weak-archive.s (added)<br>
+++ lld/trunk/test/ELF/Inputs/<wbr>dynamic-list-weak-archive.s Fri Sep  8 11:41:49 2017<br>
@@ -0,0 +1,2 @@<br>
+.globl foo<br>
+foo:<br>
<br>
Added: lld/trunk/test/ELF/dynamic-<wbr>list-weak-archive.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/dynamic-list-weak-archive.s?rev=312812&view=auto" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-<wbr>project/lld/trunk/test/ELF/<wbr>dynamic-list-weak-archive.s?<wbr>rev=312812&view=auto</a><br>
==============================<wbr>==============================<wbr>==================<br>
--- lld/trunk/test/ELF/dynamic-<wbr>list-weak-archive.s (added)<br>
+++ lld/trunk/test/ELF/dynamic-<wbr>list-weak-archive.s Fri Sep  8 11:41:49 2017<br>
@@ -0,0 +1,18 @@<br>
+# REQUIRES: x86<br>
+<br>
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t1.o<br>
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %S/Inputs/dynamic-list-weak-<wbr>archive.s -o %t2.o<br>
+# RUN: rm -f %t.a<br>
+# RUN: llvm-ar rcs %t.a %t2.o<br>
+# RUN: echo "{ zed; };" > %t.list<br>
+# RUN: ld.lld -shared --dynamic-list %t.list %t1.o %t.a -o %t.so<br>
+# RUN: llvm-readobj -r %t.so | FileCheck %s<br>
+<br>
+# CHECK:      Relocations [<br>
+# CHECK-NEXT:   Section ({{.*}}) .rela.plt {<br>
+# CHECK-NEXT:     0x2018 R_X86_64_JUMP_SLOT foo<br>
+# CHECK-NEXT:   }<br>
+# CHECK-NEXT: ]<br>
+<br>
+callq foo@PLT<br>
+.weak foo<br>
<br>
<br>
______________________________<wbr>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org">llvm-commits@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>